Many deployer export format fixes

Many deployer export format fixes Export Annotations Skip export of default service options. Services is a dict, not an array Use qualified charm names https://code.launchpad.net/~bcsaller/juju-gui/export-improvements/+merge/174485 (do not edit description out of merge proposal)

[bcsaller, 2013-07-12 19:20:24]

Please take a look.

[rharding, 2013-07-12 21:15:00]

LGTM with a suggestion to go XXX vs "doesn't make sense" note. https://codereview.appspot.com/11227043/diff/1/app/models/models.js File app/models/models.js (right): https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode919 app/models/models.js:919: // than relative which would make more sense in an export. should this be an XXX vs a note then if it doesn't make much sense as is?

[gary.poster, 2013-07-12 21:32:10]

LGTM with trivials, thank you! https://codereview.appspot.com/11227043/diff/1/app/models/models.js File app/models/models.js (right): https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode889 app/models/models.js:889: // Process the serivce_options removing any values trivial: service_options https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode900 app/models/models.js:900: // Using package name here so the default series This comment is no longer correct. Delete? https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode919 app/models/models.js:919: // than relative which would make more sense in an export. Good point. File a bug? Low priority until someone asks for it.

[benjamin.saller, 2013-07-12 21:40:43]

Thanks for the reviews https://codereview.appspot.com/11227043/diff/1/app/models/models.js File app/models/models.js (right): https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode889 app/models/models.js:889: // Process the serivce_options removing any values On 2013/07/12 21:32:11, gary.poster wrote: > trivial: service_options Done. https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode900 app/models/models.js:900: // Using package name here so the default series On 2013/07/12 21:32:11, gary.poster wrote: > This comment is no longer correct. Delete? Ha, the "this is likely..." part was still valid, removed though as its happened. https://codereview.appspot.com/11227043/diff/1/app/models/models.js#newcode919 app/models/models.js:919: // than relative which would make more sense in an export. On 2013/07/12 21:15:00, rharding wrote: > should this be an XXX vs a note then if it doesn't make much sense as is? XXX'd :)

[bcsaller, 2013-07-12 23:54:40]

*** Submitted: Many deployer export format fixes Export Annotations Skip export of default service options. Services is a dict, not an array Use qualified charm names R=rharding, gary.poster, benjamin.saller CC= https://codereview.appspot.com/11227043