Add support for tags#1002

Can we add a progress indicator when we switch with filter, and for pages load? For creating tag, If I tap on create tag. Will it create a release too or just tag? Maybe we can enhance creating release screen to accomodate tag properly.

mmarif requested changes

2021-10-24 12:36:00 +02:00

app/src/main/java/org/mian/gitnex/fragments/ReleasesFragment.java Outdated

              @ -43,2 +50,4 @@  
      private String repoOwner;  
      private String releaseTag;  
      private boolean viewTypeIsTags = false;  
      private int page = 1;  
  

Just initlization would work, private int page;

Just initlization would work, `private int page;`

Well, I tried this and in this case page was 0 at the beginning, it must be 1.

Well, I tried this and in this case `page` was 0 at the beginning, it must be 1.

6543 marked this conversation as resolved

app/src/main/java/org/mian/gitnex/viewmodels/ReleasesViewModel.java Outdated

              @ -59,0 +73,4 @@  
        
     Call<List<GitTag>> call = RetrofitClient  
     .getApiInterface(ctx)  
     .getTags(token, owner, repo, 1, 50);  
  

Page limit should come from helpers/Constants. Our default is 25 for new and 10 for old.

Page limit should come from `helpers/Constants`. Our default is 25 for new and 10 for old.

👍 1

qwerty287 marked this conversation as resolved

app/src/main/java/org/mian/gitnex/viewmodels/ReleasesViewModel.java Outdated

              @ -59,0 +99,4 @@  
        
     Call<List<GitTag>> call = RetrofitClient  
     .getApiInterface(ctx)  
     .getTags(token, owner, repo, page, 50);  
  

Page limit should come from helpers/Constants. Our default is 25 for new and 10 for old.

Page limit should come from `helpers/Constants`. Our default is 25 for new and 10 for old.

👍 1

qwerty287 marked this conversation as resolved

app/src/main/res/values/strings.xml Outdated

              @ -772,0 +775,4 @@  
      <string name="tagCreated">Tag created</string>  
      <string name="asRef">Use as reference</string>  
      <string name="deleteTagConfirmation">Do you really want to delete this tag?</string>  
      <string name="deleteTagTitle">Delete tag %s</string>  
  

How to delete a tag?

There should be a button with three dots next to the tag name in the list, there is the option.

Unfortunately I don't see one. I am on GitNex repo.

Ok, I'll see what's wrong.

Oh, I missed the permission system. I added the values used in #977 and currently this will always be false and it will be hidden... I'll disable the permission check so we can enable it if #977 is merged

Could you try again with this gitnex/GitNex@d27b0e0db7?

Could you try again with this https://codeberg.org/gitnex/GitNex/commit/d27b0e0db7b6c43a8ddefe686e5a5f13cb890595?

6543 marked this conversation as resolved

mmarif commented

2021-10-24 12:36:41 +02:00

And while you are at it, can you add pagination to Releases too?

qwerty287 commented

2021-10-24 14:37:27 +02:00

@mmarif

Can we add a progress indicator when we switch with filter, and for pages load?

Sure!

For creating tag, If I tap on create tag. Will it create a release too or just tag?

Only the tag

Maybe we can enhance creating release screen to accomodate tag properly.

I mostly copied this ui from gitea itself, but yes that would be probably good.

@mmarif >Can we add a progress indicator when we switch with filter, and for pages load? Sure! >For creating tag, If I tap on create tag. Will it create a release too or just tag? Only the tag >Maybe we can enhance creating release screen to accomodate tag properly. I mostly copied this ui from gitea itself, but yes that would be probably good.

qwerty287 commented

2021-10-24 14:37:57 +02:00

@mmarif

And while you are at it, can you add pagination to Releases too?

Requires a tea4j update, but yes I can do this👍

@mmarif >And while you are at it, can you add pagination to Releases too? Requires a tea4j update, but yes I can do this👍

👍 1

mmarif requested changes

2021-10-24 15:00:23 +02:00

app/src/main/res/values/strings.xml Outdated

              @ -771,1 +771,4 @@  
      <string name="selectUpdateStrategy">Select Update Strategy</string>  
      <string name="tags">Tags</string>  
      <string name="releasesTags">Releases/Tags</string>  
      <string name="create_tag">Create Tag</string>  
  

As it is following the web UI, in that case can you change the button text to Create Tag Only

As it is following the web UI, in that case can you change the button text to `Create Tag Only`

👍 1

gitnex/GitNex@49ce876332

https://codeberg.org/gitnex/GitNex/commit/49ce8763323c14dd75a1d822e1019e6ce12cce89

qwerty287 marked this conversation as resolved

qwerty287 added 2 commits

2021-10-24 15:06:04 +02:00

Use Constants result limit 546f797370

Show progress bars 548a711b2d

qwerty287 added 1 commit

2021-10-24 15:08:14 +02:00

Update str 49ce876332

qwerty287 added 1 commit

2021-10-24 15:10:12 +02:00

Rm permission check d27b0e0db7

qwerty287 added 1 commit

2021-10-24 15:20:11 +02:00

Add pagination to releases deef3709f6

qwerty287 added 1 commit

2021-11-07 19:59:25 +01:00

Merge branch 'main' into tags 1340fe0a02

qwerty287 referenced this pull request

2021-11-28 10:32:02 +01:00

Use pagination option of API calls #278

6543 commented

2021-12-15 20:32:50 +01:00

@qwerty287 can you add a check and only show this if gitea instance is >= 1.15 ?

👍 1

qwerty287 added 1 commit

2021-12-16 18:15:23 +01:00

Merge branch 'main' into tags 83deb6271b

qwerty287 added 2 commits

2021-12-19 10:14:03 +01:00

Merge branch 'main' into tags be900516a9

Add version check 4eae0075e2

6543 commented

2021-12-19 13:40:15 +01:00

conflicts :D

qwerty287 added 1 commit

2021-12-21 10:02:04 +01:00

Merge branch 'main' into tags 68470da5a8

mmarif commented

2022-01-22 11:59:43 +01:00

@qwerty287 can you fix the conflicts?

qwerty287 added 1 commit

2022-01-24 19:57:22 +01:00

Merge branch 'main' into tags 2a4cc6fcab

qwerty287 self-assigned this

2022-02-05 07:51:31 +01:00

mmarif added 1 commit

2022-02-09 07:19:04 +01:00

Merge branch 'main' into tags 761059d3fb

mmarif added 1 commit

2022-02-09 21:12:03 +01:00

Merge branch 'main' into tags e7e5f323c5

mmarif commented

2022-02-09 21:16:58 +01:00

This @string/labelMenuDelete does not exist in bottom_sheet_tag_in_list.xml. Am I missing something?

This `@string/labelMenuDelete` does not exist in `bottom_sheet_tag_in_list.xml`. Am I missing something?

qwerty287 commented

2022-02-10 15:24:39 +01:00

It does in line 21 - 34?

mmarif commented

2022-02-10 17:05:38 +01:00

@qwerty287

It does in line 21 - 34?

Sorry I was not clear. I mean that string is missing in strings.xml.

@qwerty287 >It does in line 21 - 34? Sorry I was not clear. I mean that string is missing in strings.xml.

qwerty287 added 1 commit

2022-02-10 17:41:10 +01:00

Fix missing string 1c2e550f9b

qwerty287 commented

2022-02-10 17:41:17 +01:00

Yes, fixed it.

👍 1 ❤️ 1

mmarif requested changes

2022-02-11 14:41:44 +01:00

app/src/main/java/org/mian/gitnex/activities/CreateReleaseActivity.java Outdated

              @ -111,0 +159,4 @@  
      enableProcessButton();  
      AlertDialogs.authorizationTokenRevokedDialog(ctx, ctx.getResources().getString(R.string.alertDialogTokenRevokedTitle),  
      ctx.getResources().getString(R.string.alertDialogTokenRevokedMessage),  
      ctx.getResources().getString(R.string.alertDialogTokenRevokedCopyNegativeButton),  
  

This should be R.string.cancelButton as there is no such string for alertDialogTokenRevokedCopyNegativeButton.

This should be `R.string.cancelButton` as there is no such string for `alertDialogTokenRevokedCopyNegativeButton`.

app/src/main/java/org/mian/gitnex/activities/CreateReleaseActivity.java Outdated

              @ -111,0 +160,4 @@  
      AlertDialogs.authorizationTokenRevokedDialog(ctx, ctx.getResources().getString(R.string.alertDialogTokenRevokedTitle),  
      ctx.getResources().getString(R.string.alertDialogTokenRevokedMessage),  
      ctx.getResources().getString(R.string.alertDialogTokenRevokedCopyNegativeButton),  
      ctx.getResources().getString(R.string.alertDialogTokenRevokedCopyPositiveButton));  
  

This should be R.string.navLogout instead of alertDialogTokenRevokedCopyPositiveButton. No such string.

This should be `R.string.navLogout` instead of `alertDialogTokenRevokedCopyPositiveButton`. No such string.

mmarif commented

2022-02-11 14:42:32 +01:00

Can you help build the app from this PR to fix the missing bits. Thanks

mmarif added 1 commit

2022-02-11 15:13:09 +01:00

Merge branch 'main' into tags 4b76cbd92e

qwerty287 added 2 commits

2022-02-11 17:44:25 +01:00

Fix strings 661d87ebe5

Hide actions if the user can't use them (#977 ) 5661fd2423

closes #919 TODO - [X] repo and file actions (create release, label...)	- [X] allow for repo admins - [x] label actions (edit, delete)	- [x] allow for repo admins - [X] issue/pr action that are available for creators (close...)	- [X] allow for creator - [X] allow for repo admins - [x] pr actions that are allowed when having push access to pr source (there was a bug in Gitea that makes that this was not working and these features were not accessible -> https://github.com/go-gitea/gitea/issues/17181) - [x] allow deleting of head branch/updates only if you can do this - [x] issue/pr action that are available for repo admins (merge) - [x] allow for repo admins - [x] milestone actions (close/reopen) - [x] allow for repo admins - [x] comment actions (delete, edit...)	- [X] allow for creators - [x] allow for repo admins - [x] org actions (create label, team, repo; req gitea 1.16.0) - [x] actions when creating/editing issues - [x] delete head when merging - [x] All actions available to instance admins? (handled through API) Maybe as extras: - [x] Allow close/reopen also for PRs - [x] Improve handling of these (multiple btns for the same action) Co-authored-by: qwerty287 <ndev@web.de> Co-authored-by: M M Arif <mmarif@noreply.codeberg.org> Reviewed-on: #977 Reviewed-by: M M Arif <mmarif@noreply.codeberg.org> Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org> Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>

qwerty287 added 2 commits

2022-02-11 17:45:57 +01:00

Merge branch 'main' into tags 127aa286f5

Merge branch 'tags' of codeberg.org:qwerty287/GitNex into tags 693467f368

mmarif added 1 commit

2022-02-12 14:37:35 +01:00

Cleanup and fixes b6d09c4248

mmarif commented

2022-02-12 14:39:44 +01:00

@qwerty287 this is ready for mergning. Just one thing I wish was there, when delete a tag, refresh the view with updated list. But it can be done in another PR.

mmarif approved these changes

2022-02-12 14:40:24 +01:00

mmarif merged commit f79d227bff into main

2022-02-12 14:41:12 +01:00

mmarif referenced this pull request from a commit

2022-02-12 14:41:12 +01:00

Add support for tags (#1002)

qwerty287 deleted branch tags

2022-02-12 15:08:41 +01:00

Sign in to join this conversation.

No reviewers