Pass logger to fasthttp#98

Gusted · 2022-07-03T02:14:51+02:00

Gusted commented

2022-07-03 02:14:51 +02:00

Use a logger with FASTHTTP prefix as fasthttp's logger so it's easy to see what fasthttp is logging in console/journal.

- Use a logger with `FASTHTTP` prefix as fasthttp's logger so it's easy to see what fasthttp is logging in console/journal.

Gusted added 1 commit

2022-07-03 02:14:52 +02:00

Pass logger to fasthttp

ci/woodpecker/pr/woodpecker Pipeline failed

Details

4789d2e869

- Use a logger with `FASTHTTP` prefix as fasthttp's logger so it's easy to see what fasthttp is logging in console/journal.

6543 reviewed

2022-07-03 13:00:07 +02:00

server/setup.go

              @ -14,0 +16,4 @@  
     type fasthttpLogger struct{}  
        
     func (fasthttpLogger) Printf(format string, args ...interface{}) {  
     log.Printf("[FASTHTTP] "+format, args...)  
  

I think we should use something like
log.Str("fasthttp").Printf(...)
as zerolog is a structural logger

I think we should use something like `log.Str("fasthttp").Printf(...)` as zerolog is a structural logger

👍 1

Could you point to the function of zerolog? I don't see it has an exported function called log.Str(...)

Could you point to the function of zerolog? I don't see it has an exported function called `log.Str(...)`

I'll have a look into it

- log.Printf("[FASTHTTP] "+format, args...) + log.Info().Bool("fasthttp", true).Msgf(format, args...)

that would be more the zerolog way ... through I dont know if we sould use Debug or Info or Trace

```diff - log.Printf("[FASTHTTP] "+format, args...) + log.Info().Bool("fasthttp", true).Msgf(format, args...) ``` that would be more the zerolog way ... through I dont know if we sould use Debug or Info or Trace

I guess for now info, fasthttp isn't clear on the usage of logger(currently it's just printing errors)

I don't think this is correct, https://go.dev/play/p/dx3bHPMsAXD

It's printing the raw info:

{"level":"info","fasthttp":true,"time":"2009-11-10T23:00:00Z","message":"Hi o/"}

I don't think this is correct, https://go.dev/play/p/dx3bHPMsAXD It's printing the raw info: ``` {"level":"info","fasthttp":true,"time":"2009-11-10T23:00:00Z","message":"Hi o/"} ```