Fork 51

WIP: Add gzip compression#302

Draft

video-prize-ranch wants to merge 2 commits from video-prize-ranch/pages-server:main into main

video-prize-ranch commented

2024-03-30 02:47:24 +01:00

Contributor

Fixes #223

Responses are compressed with gzip and cached.

Fixes #223 Responses are compressed with gzip and cached.

video-prize-ranch added 2 commits

2024-03-30 02:47:25 +01:00

Add gzip compression 6f7e694fd4

code review fixes woohoo

ci/woodpecker/pr/woodpecker Pipeline failed

Details

924ad83ac6

momar commented

2024-04-02 00:26:57 +02:00

Owner

This is as of now uncovers an existing bug that's unfortunately a DoS vector, as the whole file is loaded at once into memory without a size limit, instead of streaming its contents. #301 will change quite some things that are touched in this PR, including that DoS issue, and then streamed Gzip and caching Gzip-compressed responses and thus saving CPU for often accessed resources should become a lot easier to implement.

Thank you for the contribution, I've marked it as "WIP" due to #301 breaking most of the changes, and also because I think that this will still need some discussion specifically on caching of compressed contents. This is as of now uncovers an existing bug that's unfortunately a DoS vector, as the whole file is loaded at once into memory without a size limit, instead of streaming its contents. #301 will change quite some things that are touched in this PR, including that DoS issue, and then streamed Gzip and caching Gzip-compressed responses and thus saving CPU for often accessed resources should become a lot easier to implement.

👍 1