Codeberg/pages-server
Codeberg/pages-server
Fork 51
Code Issues 109 Pull requests 10 Releases 31 Packages 1 Wiki Activity

Document more flags & make http port customizable#183

Merged
6543 merged 5 commits from refactor_nits into main 2023-02-13 21:14:47 +01:00
Conversation 1 Commits 5 Files changed 9 +97 -77
6543 commented 2023-02-13 20:36:00 +01:00
Contributor
Copy link
No description provided.
❤️ 2
6543 added this to the v5.0 milestone 2023-02-13 20:36:00 +01:00
more flag documentation
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details
ci/woodpecker/pr/woodpecker Pipeline failed
Details
e2a84390df
fix lint
Some checks failed
ci/woodpecker/push/woodpecker Pipeline is pending
Details
ci/woodpecker/pr/woodpecker Pipeline failed
Details
045c09b518
just docker
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
d6dbfcf61d
6543 merged commit 9a3d1c36dc into main 2023-02-13 21:14:47 +01:00
6543 deleted branch refactor_nits 2023-02-13 21:14:47 +01:00
fsologureng reviewed 2023-02-13 22:18:57 +01:00
cmd/flags.go
@ -138,2 +146,2 @@
Name: "acme-eab-hmac",
// TODO: Usage
Name: "acme-eab-hmac",
Usage: "Register the current account to the ACME server with external binding.",
fsologureng commented 2023-02-13 22:16:12 +01:00
Contributor
Copy link

Hi. There is no difference with the previous usage.

Hi. There is no difference with the previous usage.
6543 commented 2023-02-13 22:45:19 +01:00
Author
Contributor
Copy link

@fsologureng what do you revere to "previous usage" ?

@fsologureng what do you revere to "previous usage" ?
fsologureng commented 2023-02-13 22:51:50 +01:00
Contributor
Copy link

@fsologureng what do you revere to "previous usage" ?

Sorry, not previous in versioning but between this and previous flag which appear to be identical in usage.

> @fsologureng what do you revere to "previous usage" ? Sorry, not previous in versioning but between this and previous flag which appear to be identical in usage.
6543 commented 2023-02-14 03:03:41 +01:00
Author
Contributor
Copy link

yes the function has not changed, it's just documented now

yes the function has not changed, it's just documented now
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking

   
bug

Something is not working

  
build_pr_image

When this label is set, Pull Requests will build and publish images for testing purposes

  
documentation

Something is not correctly documented

  
​d̶u̶p̶l̶i̶c̶a̶t̶e̶

This issue or pull request already exists

  
feature

New feature

  
good first issue

easy to contribute

  
improvement

An improvement to the existing code or an existing feature

  
​i̶n̶v̶a̶l̶i̶d̶

Something is wrong

  
open questions

More information is needed

  
performance

improve performance

  
refactor

Maintain existing code

  
research required

More research is needed to solve the issue

No labels
breaking
bug
build_pr_image
documentation
​d̶u̶p̶l̶i̶c̶a̶t̶e̶
feature
good first issue
improvement
​i̶n̶v̶a̶l̶i̶d̶
open questions
performance
refactor
research required
Milestone
Clear milestone
No items
No milestone
v5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/pages-server!183
No description provided.