Butane example#66

Merged
pat-s merged 8 commits from :main into main 2025-01-08 18:31:59 +01:00
Contributor

This PR add an example to translate all Butane config in directory to Ignition config with a simple bash script.

This PR add an example to translate all Butane config in directory to Ignition config with a simple bash script.
add Butane example
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
a72a9f58d3
add Git CI for sync with upstream repo
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
00af8efc1a
Revert "add Git CI for sync with upstream repo"
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
920f0f60f4
This reverts commit 00af8efc1a.
pat-s requested changes 2025-01-06 00:00:33 +01:00
Dismissed
pat-s left a comment
Owner

Thanks.

Please address the lints and follow the instructions in the README.

Thanks. Please address the lints and follow the instructions in the README.
colgrave34 force-pushed main from 1e1a108f89
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
to 665ae70ea4
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2025-01-06 05:37:02 +01:00
Compare
Author
Contributor

I have fixed all the issues you mentioned in both pull requests, #67. Please let me know if there are any other issues.

First time contributing, sorry I didn't read through the README.

I have fixed all the issues you mentioned in both pull requests, [#67](https://codeberg.org/Codeberg-CI/examples/pulls/67). Please let me know if there are any other issues. First time contributing, sorry I didn't read through the README.
Owner

No worries, that's what reviews are for. Thanks for contributing!

As you also use the git step here, #67 (comment) also applies for this PR.

No worries, that's what reviews are for. Thanks for contributing! As you also use the git step here, https://codeberg.org/Codeberg-CI/examples/pulls/67#issuecomment-2568832 also applies for this PR.
colgrave34 force-pushed main from 9abed54185
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
to f209b596f6
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2025-01-07 05:35:01 +01:00
Compare
Author
Contributor

I made the changes and made sure it worked.

I made the changes and made sure it worked.
pat-s requested changes 2025-01-08 08:58:40 +01:00
Dismissed
pat-s left a comment
Owner

See comment and lints.

See comment and lints.
@ -0,0 +20,4 @@
- name: push
image: docker.io/appleboy/drone-git-push
environment:
Owner

While environment: still works in 2.8.2, it will stop working in 3.0 (which is being published soon). You need to use the ssh_key setting instead.

While `environment:` still works in 2.8.2, it will stop working in 3.0 (which is being published soon). You need to use the `ssh_key` setting instead.
deprecate environment and use ssh_key setting
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
baea7256d4
Author
Contributor

I made the changes.

I made the changes.
pat-s approved these changes 2025-01-08 18:31:31 +01:00
pat-s left a comment
Owner

Thanks! Much appreciated, also for addressing the review points.

Thanks! Much appreciated, also for addressing the review points.
pat-s merged commit 472428a7ce into main 2025-01-08 18:31:59 +01:00
pat-s referenced this pull request from a commit 2025-01-08 18:32:02 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg-CI/examples!66
No description provided.