Code review comment for lp:~mvo/unity-scope-click/empty-frameworks-query

Revision history for this message
dobey (dobey) wrote :

On Mon, 2014-05-19 at 18:43 +0000, Michael Vogt wrote:
> I don't really see the conflict with my other branch here,
> configuration->get_available_frameworks() may still return a empty
> array (but maybe I'm missing something).

Oh, sorry. I was reading the change in index.cpp here, and
configuration.cpp there, as the same code. :)

This branch does conflict with the tip of /devel now though. But I still
think this isn't how we should fix the issue, and instead we should have
a proper dependency on the data from other packages we need, and should
fail appropriately rather than trying to pass empty data to the server.
Although, I think tip of /devel will pass empty data to the server now
anyway, as we're passing an empty header, rather than not passing
frameworks at all, in the empty list case.

« Back to merge proposal