Code review comment for lp:~mvo/unity-scope-click/empty-frameworks-query

Revision history for this message
dobey (dobey) wrote :

I'm voting Disapprove here, because it directly conflicts with your other branch https://code.launchpad.net/~mvo/unity-scope-click/lp1292645-use-libclick/+merge/220061 and I'm not sure it's the solution we should be going for here.

Also, please file a new bug for this issue where results are given, but not installable, when there are no frameworks. As the frameworks data is a core piece of information we depend on for a working scope, I think we should fail when they are none available, and have a runtime dependency on the package that provides them (ubuntu-sdk-libs).

review: Disapprove

« Back to merge proposal