Code review comment for lp:~andreas-pokorny/unity-system-compositor/expose-powerkey-state-and-screen-toggle-controller-interface

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

DBus methods for controlling wither power button toggles screen power mode:
  * enablePowerModeToggle
  * disablePowerModeToggle

Umm I wonder if this should be exposed. We certainly don't want just any client to override this policy - say what if the client requesting this crashed and never restored the power key policy?
The user now can't get the screen to shut off.

Maybe a request like in keepDisplayOn is needed, at least if the requesting client dies the power key policy can go back to default.

I guess an apparmor policy would be needed to access those controls so that they are not abused either.

review: Needs Information

« Back to merge proposal