Nux

Code review comment for lp:~3v1n0/nux/x11-conffile-on-unity-only

Revision history for this message
Iain Lane (laney) wrote :

Thanks for the changes.

No sorry, I can't ack the symlink change. I don't think this complies with the Debian recommendations. It talks about whether *every* user has to modify the file, which isn't the case here. I don't see why this file is different to any of the other ones. Can we please just not rename it?

The rest of it looks good. I tested the subshell bit using /bin/sh here and it seems to work fine, thanks for doing it like that.

review: Needs Fixing

« Back to merge proposal