Activity
From 08/16/2023 to 08/22/2023
08/22/2023
-
10:59 PM Revision 00054de6 (git): Remove nd_entry from NODE_GASGN and NODE_GVAR
- After a0f12a0258e4020bd657ee80b7d8f22bd33ea223 NODE_GASGN and
NODE_GVAR hold same value on both nd_vid and nd_entry.
This commit stops setting value to nd_entry and makes to use only
nd_vid. -
10:43 PM Revision ff552389 (git): YJIT: x64: Split mem-to-mem Insn::Store like Insn::Mov
- The ARM backend allows for this so let's make x64 consistent.
-
10:35 PM Feature #14579: Hash value omission
- Has it been considered to ever expand this feature to allow instance variables and global variables. Or was it strictly reserved for local variables intentionally, to avoid incompatible or dangerous behavior?
Thanks for adding this r... -
10:33 PM Bug #12725: Trying to use ./miniruby before it exists
- @duerst Have you seen this issue reoccur since it was initially posted? If not, do you think this can be closed?
-
- A fix for this has been submitted as an upstream pull request: https://github.com/ruby/net-http/pull/87
-
-
-
- @duerst Do you think this can be closed?
-
-
-
09:36 PM Revision c23e2e19 (git): YJIT: add code_region_overhead stat output (#8262)
-
09:19 PM Revision 2d750697 (git): [ruby/yarp] Use require_relative for yarp/ffi
- https://github.com/ruby/yarp/commit/c0598f8805
-
- I don't think this is a bug in Ruby, it is a general issue with Windows. As @nobu mentioned, you shouldn't use quotes in `PATH`. See https://serverfault.com/questions/349179/path-variable-and-quotation-marks-windows/349216#349216
-
- Readline support was removed in commit:59fd67fc3d405e529e038172e769ff20a8fb5535. If this is still an issue, please file it upstream https://github.com/ruby/readline-ext
-
- Readline was removed from Ruby in commit:59fd67fc3d405e529e038172e769ff20a8fb5535. If this is still an issue, please file it upstream: https://github.com/ruby/readline-ext/issues
-
- Looking at recent Ruby versions:
* `-Wimplicit-function-declaration` is in `warnflags`
* `warnflags` is included in `cflags`
* `cflags` is included in `CFLAGS` but not `CXXFLAGS`
* C++ compilation rules use `CXXFLAGS` and not `CFLA... -
08:31 PM Revision 837c12b0 (git): Use STR_EMBED_P instead of testing STR_NOEMBED
-
07:13 PM Bug #19844 (Feedback): Ruby 3.2 fails to build with openssl version 3
- Ruby version 3.2 code base: https://github.com/ruby/ruby/tree/1c7624469880bcb964be09a49e4907873f45b026
openssl v3 is installed under /usr/local_ssl_3.0.0.
```
./configure --with-openssl-dir=/usr/local_ssl_3.0.0
```
I get the f... -
06:04 PM Revision 9b373fb4 (git): [ruby/yarp] Fix small typo in templating to specify where template comes from
- https://github.com/ruby/yarp/commit/96d69ceef6
-
02:46 PM Revision 7127f39b (git): Add notes and name a magic number
-
01:43 PM Feature #19842: Introduce M:N threads
- > `Thread#lock_native_thread` may be what you want.
Well, it depends if locked thread are counted as part of `RUBY_MAX_PROC` or not. If not then yes that would be what I want.
> ...
Ah, I indeed missed that. Thank you. The idea wou... -
08:53 AM Feature #19842: Introduce M:N threads
- byroot (Jean Boussier) wrote in #note-16:
> Another question I have is around being able to opt-out of N:M for a specific thread.
> ...
may be what you want.
> > how to switch the behavior
> ...
You can try your application with:
... -
- > `rb_thread_local_aref`
Ah, I totally missed that API, thank you.
Another question I have is around being able to opt-out of N:M for a specific thread.
e.g if you have something like:
```ruby
$background_check = Thread.new ... -
- byroot (Jean Boussier) wrote in #note-14:
> > Thread Local Storage issue
> ...
```C
VALUE rb_thread_local_aref(VALUE thread, ID key);
VALUE rb_thread_local_aset(VALUE thread, ID key, VALUE val);
```
are exposed.
Anyway I bel... -
- > Thread Local Storage issue
Is there any plan to expose a c API to store data on the Ruby thread to replace the native APIs?
Locking to a native thread is fine for making old code compatible, but if we wish to upgrade that code to... -
- > Ok. So Ruby Threads and Ractors will both share time on native threads. The difference being that Ractors can run in parallel and Ruby Threads that belong to the same Ractor cannot. I guess we kind of have that with cached pthreads rig...
-
- > Hoping my guess was correct, I'm not quite sure what "2 level scheduling" means though. Is it just that the single-ractor mode applies some optimization (what is it?) instead of reusing the scheduler for the multi-ractor mode? To me, i...
-
- > Ruby threads of a Ractor is managed by 1:N threads
is also typo (updated)
"Ruby threads of a Ractor is managed by M:1 threads" -
- > We can run N ractors on N native threads simultaneously if the machine has N cores.
Sorry it was typo (updated).
"We can run M ractors on N native threads simultaneously if the machine has N cores."
-
- tenderlovemaking (Aaron Patterson) wrote in #note-2:
> ko1 (Koichi Sasada) wrote:
> ...
You are right.
The reason is:
> On the multiple Ractors, N (+ alpha) native threads run M ractors. Now there is no way to disable M:N threads... -
12:21 AM Feature #19842: Introduce M:N threads
- k0kubun (Takashi Kokubun) wrote in #note-3:
> > when M:N is enabled, threads become green threads, and Ractors are truly parallel (but CPU time is divided among N threads)
> ...
Ok. So Ruby Threads and Ractors will both share time on n... -
12:10 AM Feature #19842: Introduce M:N threads
- > when M:N is enabled, threads become green threads, and Ractors are truly parallel (but CPU time is divided among N threads)
I thought he used `[num_ractors]:[num_native_threads]` for "1:N threads" as well (neither 1 nor N is the numbe... -
- I think `YARP` is already too widely used and talked about to be renamed without causing significant confusion and downsides.
In fact the gem already has [multiple releases](https://rubygems.org/gems/yarp).
> I don't think "YA-" name... -
- If the motivation of this API is testing YARP compilation to ISeq, I agree to introduce `ISeq.compile_yarp` to Ruby 3.3 and remove it from Ruby 3.4.
(Note that the name `YARP` is renaming one)
Because if YARP is introduced as the MRI... -
12:50 PM Feature #19777: Make `Kernel#lambda` raise when called without a literal block
- The ship has sailed, but I should at least mention I am disappointed at this turn of things. Again deprecating things for no concrete benefit. How ironic that #15973 started with "change Kernel#lambda so it always returns a lambda" and e...
-
-
05:36 AM Feature #19843 (Closed): Promote bigdecimal as bundled gems at Ruby 3.4
- Applied in changeset commit:git|1c93288f8bbf667cb95eb7137b2fe64213894b77.
----------
Added bigdecimal to warning targets for the bundled gems.
[Bug #19843] -
03:17 AM Feature #19843: Promote bigdecimal as bundled gems at Ruby 3.4
- @hsbt I agree with you. I've wanted to make bigdecimal a bundled gem for a long time but I didn't have much time to work for it. Thank you very much.
-
- I triaged target list for bundled gems at https://bugs.ruby-lang.org/issues/19351.
After that, I resolved bigdecimal dependency from our test suite at https://github.com/ruby/ruby/commit/3ef6364a988ab24ca7fdbb7d1b6840b2a40f1466
I p... -
- [Bug #19843]
-
- I would say only a file if the environment variable is set, with perhaps just a message on stderr saying the report was written into that path.
But I don't have a strong opinion about this, if others think it should be written in both... -
- Does it print to both STDERR and a file? or only to a file?
-
- It doesn't use optparse, so the location is not flexible.
- 04:46 AM Revision ccc80043 (git): Update default gems list at eec7a3f9ee0a40f4f5e22e0131c3ac [ci skip]
-
- https://github.com/ruby/erb/commit/c594f2fb86
-
- 04:41 AM Revision 0955ca34 (git): [ruby/erb] Enable frozen_string_literal in all files
- (https://github.com/ruby/erb/pull/49)
I was surprised to see erb show up when I was using memory_profiler on
my app. ERB::Compiler#compile has a blank string literal, and it
ended up allocating some 41532 blank strings for a relatively ... -
- * [Bug #19843] Promote bigdecimal as bundled gems at Ruby 3.4
* mrkn: Is it okay? - 01:25 AM Revision 4a8d7246 (git): zlib 1.2.13 is gone from zlib.net
08/21/2023
-
- ko1 (Koichi Sasada) wrote:
> This ticket proposes to introduce M:N threads to improve Threads/Ractors performance.
> ...
Should this be "M ractors on N native threads"? It sounds like Ractors are not 1:1 with threads in this design.
... -
- This ticket proposes to introduce M:N threads to improve Threads/Ractors performance.
## Background
Ruby threads (RT in short) are implemented from old Ruby versions and they have the following features:
* Can be created with si... -
11:36 PM Bug #19246: Rebuilding the loaded feature index much slower in Ruby 3.1
- Applied at https://github.com/ruby/ruby/commit/788b03d5ba82fd8b35ce1fe2618ce6bacc648333.
-
11:33 PM Revision 788b03d5 (git): Re-apply "Ruby 3.2 - Speed up rebuilding the loaded feature index and realpath cache (#8023)" (#8252)
- * Re-apply "Ruby 3.2 - Speed up rebuilding the loaded feature index and realpath cache (#8023)"
* [CI] mingw.yml - remove IBM437 encoding for test-all, use cmd shell for test & test-all
* Skip failing test on mingw with readline.so
Co... -
- * [Feature #19842] Introduce M:N threads (ko1)
* Do you have any questions about it?
-
-
-
- 08:14 PM Revision b9ef8191 (git): [rubygems/rubygems] Support `ruby file: ".tool-versions"` in Gemfile
- (https://github.com/rubygems/rubygems/pull/6898)
Supports .tool-versions (ASDF) by checking for a line starting with "ruby"
before falling back to reading the entire file, as in .ruby-version.
https://github.com/rubygems/rubygems/commi... -
07:00 PM Revision 95e29b04 (git): [ruby/yarp] fix: avoid invalid memory read when CR is present without LF
- https://github.com/ruby/yarp/commit/2296c037de
-
- Previously this failed an assertion and aborted.
https://github.com/ruby/yarp/commit/a037d942a8 -
06:23 PM Revision ca6db02c (git): [ruby/irb] Avoid overriding user's `irb_name` setting in debugger
- integration
(https://github.com/ruby/irb/pull/688)
* Avoid overriding user's irb_name setting in debugger integration
Instead of always setting `irb_name` to `irb:rdbg`, it should respect
the user's setting and only append `:rdbg` to i... -
- YARP commits were synced out of order. We are doing this reset
commit to ensure that all files are currently correct and we can
proceed with monitoring syncs so this doesn't happen again. -
- https://github.com/ruby/yarp/commit/1e4940864b
-
- https://github.com/ruby/yarp/commit/149c74291b
-
- Previously, parsing a snippet like this:
%r\nfoo\n
would result in tracking the second newline twice, resulting in a
failed runtime assertion.
Fixing that issue reveals another bug, which is that the _first_
newline was not being ... -
05:43 PM Revision e63bac31 (git): [ruby/yarp] Rename statements to body where appropriate
- https://github.com/ruby/yarp/commit/0aa7d9d10c
-
- It makes it more difficult to find all locations where a variable
is written to if they're just read nodes. To keep things consistent
we should make them write nodes.
https://github.com/ruby/yarp/commit/840e094045 -
- https://github.com/ruby/yarp/commit/9e680a7598
-
05:43 PM Revision 339b34be (git): [ruby/yarp] handle missing HEREDOC endline at start of heredoc
- https://github.com/ruby/yarp/commit/7b72493b6d
-
- https://github.com/ruby/yarp/commit/9da0bc4452
-
- https://github.com/ruby/yarp/commit/db95191207
-
- https://github.com/ruby/yarp/commit/5ba7394261
-
- https://github.com/ruby/yarp/commit/3607efb01d
-
- https://github.com/ruby/yarp/commit/1e4940864b
-
- https://github.com/ruby/yarp/commit/149c74291b
-
-
-
- We have reflected on the name YARP and would like to propose Prism as a new name for the external API. The parser is similar to a prism because it takes Ruby code as input and returns it “refracted” into an AST. Also, [the existing prism...
-
- Previously, parsing a snippet like this:
%r\nfoo\n
would result in tracking the second newline twice, resulting in a
failed runtime assertion.
Fixing that issue reveals another bug, which is that the _first_
newline was not being ... -
- https://github.com/ruby/yarp/commit/d5365f08d0
-
-
- (https://github.com/ruby/irb/pull/683)
* Add a test case for Ctrl-C handling
* Test symbol aliases with integration tests
There are a few places that also need to check symbol aliases before
`Irb#eval_input`. But since the current com... -
- https://github.com/ruby/yarp/commit/a328f27d8f
-
- We don't really need obj_ivar_heap_alloc and obj_ivar_heap_realloc since
they're just one liners. -
- Fix up https://github.com/rubygems/rubygems/pull/6882
https://github.com/rubygems/rubygems/commit/71c73ac6d9
08/20/2023
-
- * For example in ProgramNode:
# attr_reader statements: Node
=>
# attr_reader statements: StatementsNode
https://github.com/ruby/yarp/commit/ffed35238c -
05:22 PM Revision 725ca2f9 (git): [ruby/irb] Support `VISUAL` env var, and prefer it over `EDITOR`
- (https://github.com/ruby/irb/pull/686)
* Support `VISUAL` env var, and prefer it over `EDITOR`
* Update test/irb/test_cmd.rb
---------
https://github.com/ruby/irb/commit/399b872c31
Co-authored-by: Stan Lo <stan001212@gmail.com> - 05:17 PM Revision 5c75dc51 (git): Update default gems list at 314ccdd60c5fe3dfa90651d271209e [ci skip]
-
- (https://github.com/ruby/reline/pull/582)
https://github.com/ruby/reline/commit/3840d1f958 -
05:03 PM Revision 405c295a (git): [ruby/reline] Use fdiv for keyseq_timeout msec to sec conversion
- (https://github.com/ruby/reline/pull/583)
https://github.com/ruby/reline/commit/a6504acd63 -
- https://github.com/nobu/ruby/tree/marshal-recursive-userdef
-
02:24 PM Bug #19794: Ruby 3.2.2 fails to build on macOS Sonoma betas
- Thanks for the analysis. I've reported this as FB13016123 in Apple's feedback system.
Diagnosing situations like this would be easier if the configure script did a better job of surfacing the LD warnings. The "something wrong with LDFL... -
05:56 AM Bug #19794: Ruby 3.2.2 fails to build on macOS Sonoma betas
- > ld maintains a list of directories to search for a library or framework to use. The default library search path is /usr/lib then /usr/local/lib. The -L option will add a new library search path. The default framework search path is ...
-
-
-
- (https://github.com/ruby/reline/pull/580)
Timeout's implementation relies on Thread, which would conflict with
`ruby/debug`'s thread-freezing implementation and has casued issues like
- ruby/debug#877
- ruby/debug#934
- ruby/debug#1000... - 09:07 AM Revision 35442005 (git): [rubygems/rubygems] fix lint
- https://github.com/rubygems/rubygems/commit/75c0f27b7e
- 09:07 AM Revision 7c4431e6 (git): [rubygems/rubygems] use a one-liner
- https://github.com/rubygems/rubygems/commit/46745885e8
- 09:07 AM Revision e5efa01c (git): [rubygems/rubygems] handle removing `BUNDLE_`, since using start_with? would still include that
- https://github.com/rubygems/rubygems/commit/235d9b38d8
- 09:06 AM Revision f0bf9391 (git): [rubygems/rubygems] Don't rely on globals when not matching regexp for "local."
- https://github.com/rubygems/rubygems/commit/e79ccdafd8
- 09:06 AM Revision b5a0630c (git): [rubygems/rubygems] Use ! methods once we have a new copy of the string. Use .prepend to avoid allocating a new string.
- https://github.com/rubygems/rubygems/commit/2ac35a661f
- 09:06 AM Revision 29aab66e (git): [rubygems/rubygems] call key.to_s once instead of multiple times to save when it's a symbol
- https://github.com/rubygems/rubygems/commit/535feb817c
- 09:06 AM Revision 239e3525 (git): [rubygems/rubygems] Use value.match? only on Strings, which avoids allocating a matchdata, which is not used
- https://github.com/rubygems/rubygems/commit/cbf9ac93d7
- 09:06 AM Revision 598048e3 (git): [rubygems/rubygems] Use .to_s once in the beginning to save allocations if it's a symbol.
- https://github.com/rubygems/rubygems/commit/f8167db8a2
- 09:06 AM Revision e921efa4 (git): [rubygems/rubygems] name is often a symbol, so only to_s once to avoid allocating it multiple times
- https://github.com/rubygems/rubygems/commit/8eac49c429
- 09:06 AM Revision 7cb6cbee (git): [rubygems/rubygems] String#start_with? is faster than regex with beginning boundaries
- https://github.com/rubygems/rubygems/commit/d7cde68034
- 09:06 AM Revision b97e45d0 (git): [rubygems/rubygems] Use ! methods on the array, since it is brand new. The individual keys are also new, so we can use ! methods on each individual one as well.
- https://github.com/rubygems/rubygems/commit/f2e912b9bb
- 09:06 AM Revision 2a61e1dc (git): [rubygems/rubygems] Use Array#union to join these, instead of with | multiple times. This saves allocating 2 arrays
- https://github.com/rubygems/rubygems/commit/48c03b33b7
- 09:06 AM Revision 79b187a4 (git): [rubygems/rubygems] config is a new Hash, and config.values is a new Array. that means we can use bang methods to avoid allocating new copies
- https://github.com/rubygems/rubygems/commit/8bc13fa55f
- 09:05 AM Revision 921c2bba (git): [rubygems/rubygems] ENV.to_h returns a new hash, so we can `select!` it to avoid allocating another hash.
- `String#start_with?` is faster than regex that is bound to the start of
a string.
https://github.com/rubygems/rubygems/commit/9b2006ef09 -
09:05 AM Revision 7e5c3ec5 (git): Update specification.rb
- Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
-
- For ruby-core compat
https://github.com/rubygems/rubygems/commit/83aa7b794e -
- Before this, you would get constant redefinition warnings on Psych::DefaultKey
Additionally, ensure the retries wont continue infinitely in the case of the ArgumentError not being caused by Marshal trying to load the undefined classes
... -
09:04 AM Revision f69f775f (git): [rubygems/rubygems] choose_from_list may return nil index since
- https://github.com/rubygems/rubygems/commit/abacb0cb34cd
https://github.com/rubygems/rubygems/commit/5e2e9d6e50 -
-
-
- For `70ce3c8947c7f95897e56b397270c061dd50f280`, I did a fresh build with `-fsanitize=address` CFLAGS, not reproduced. (using M1 macOS 14.0 beta and Xcode 15 beta toolchain) Maybe x86_64 specific issue?
-
- @MSP-Greg Thank you for investigations and providing patches! I will handle it soon.
08/19/2023
-
- @nagachika
Thanks for your work on this. Please see https://github.com/ruby/ruby/pull/8252 -
- Fix up https://github.com/rubygems/rubygems/pull/6882
https://github.com/rubygems/rubygems/commit/525b94a89f -
- Right, I fear the best we can do is to detect this case and raise a cleaner error.
-
- Not only would be data compatibility broken, but I think data created by "remembering" the index of an instance first cannot be loaded.
This is a case specific to `TYPE_USERDEF`.
Instance variables of such types are dumped/loaded via a... -
- Hum, this is tricky.
`Time` implements `_dump`, so we enter this branch:
```c
if (rb_obj_respond_to(obj, s_dump, TRUE)) {
VALUE ivobj2 = Qundef;
st_index_t hasiv2;
VALUE encname2;
... -
- It repros on 3.0, 3.1 and `master`.
- 01:14 AM Revision 79558738 (git): Update default gems list at bd440bf85d6eff5ecf5132e93a0721 [ci skip]
-
- https://github.com/ruby/yarp/commit/bfde753702
-
- https://github.com/ruby/yarp/commit/0aa7d9d10c
08/18/2023
-
10:27 PM Revision 3dff315e (git): YJIT: Quiet mode when running with `--yjit-stats` (#8251)
- Quiet mode for running with --yjit-stats
-
- https://github.com/ruby/yarp/commit/22b287e2b1
-
- https://github.com/ruby/yarp/commit/9e680a7598
- 07:14 PM Revision 3d7a0301 (git): [rubygems/rubygems] Resolve ruby version file relative to bundle root
- This is a follow up to https://github.com/rubygems/rubygems/issues/6742.
This change makes it so that the version file is resolved relative to
the Bundle root instead of the working directory.
Why is this useful?
If you run a commnad (... -
- ``` ruby
#!/usr/bin/env ruby
puts RUBY_VERSION
t = Time.at(0, 1, :nanosecond)
t.instance_variable_set :@itself, t
Marshal.dump(t)
```
Yields a stack overflow error from the `Marshal.dump` call, even though Marshal is expli... -
- Set heredoc_end to NULL at the start of lexing a heredoc, to avoid
having state from the previous heredoc confuse the parser's current
location.
https://github.com/ruby/yarp/commit/21ee304f0e -
- https://github.com/ruby/yarp/commit/7b72493b6d
-
- Related to #16757
-
06:56 AM Feature #19839: Need a method to check if two ranges overlap
- Thank you for your feedback.
> I've made several helpers for this exact same problem, as well as a `Range#merge` in the past.
Yes, `Range` class can have methods such as `Range#merge` but I wanted to start small and see what happen... -
- What do you expect when it is called with a non-Range object, `TypeError`, same as `cover?` or something else?
-
02:09 AM Feature #19839: Need a method to check if two ranges overlap
- I've made several helpers for this exact same problem, as well as a `Range#merge` in the past. I would very much be in favor of this change.
Example usage from an interview problem, though I have some internal usecases which have done... -
- It would be convenient to have a method that checks if two ranges overlap. For example,
```
(0..10).overlap?(5..15) #=> true
(0..10).overlap?(20..30) #=> false
``` -
- * [Bug #19779] `eval "return"` at top level raises `LocalJumpError` (jeremyevans0)
* Do we want to allow `eval "return"` at top level with the same sematics as `return`?
* [Bug #19749] Confirm correct behaviour when attaching private... - 04:42 PM Revision 744bc4d5 (git): [rubygems/rubygems] Make nil a valid license spec
- https://github.com/rubygems/rubygems/commit/675effb67e
-
- Issue found by running ruby/spec with `--yjit-verify-ctx`. Thanks!
-
02:35 PM Bug #19837: Concurrent calls to Process.waitpid2 misbehave on Ruby 3.1 & 3.2
- Thanks - yeah it’s no problem if it doesn’t get back ported to 3.0.
-
- This updates the backport flags. Note that Ruby 3.0 is in security maintenance, and this doesn't appear to be security related, so it is unlikely to be backported to Ruby 3.0.
-
- OK - I hope I've done this right, let me know otherwise :)
* Ruby 3.0: https://github.com/ruby/ruby/pull/8248
* Ruby 3.1: https://github.com/ruby/ruby/pull/8246
* Ruby 3.2: https://github.com/ruby/ruby/pull/8247
Also, I opened a ... -
-
- * YJIT: implement fast path for integer multiplication in opt_mult
* Update yjit/src/codegen.rs
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
* Implement mul with overflow checking on arm64
* Fix missing semicolon
* Add ar... -
- We don't need to check for STR_NOEMBED because the check above for
STR_EMBED_P means that it can never be false. -
- https://github.com/ruby/yarp/commit/efb3102369
- 08:21 AM Revision 20106fe2 (git): [rubygems/rubygems] Update SPDX license list as of 2023-06-18
- https://github.com/rubygems/rubygems/commit/3db9165335
-
- This reverts commit 6fff5c5ba23a2790c9d189de82e157c9fa986f96.
Revert "Use $(top_srcdir) entries for mswin (#8244)"
This reverts commit e327bf32bdfa610a0f1834048bb1422de992c073.
Revert "Update dependencies"
This reverts commit aba26a8... -
-
- While the $(VPATH) rules live in common.mk, mswin seems to ignore them.
We need to use $(VPATH) for OpenBSD, but we need to use the other one for mswin. -
-
- Scratch build on OpenBSD has been failing since 67b5f63e97.
`make; make` works though. (`make` alone doesn't work)
I have no idea what I'm doing, but I do know that this patch fixes
scratch build on an OpenBSD machine.
My best guess is... -
-
-
04:28 AM Feature #19840 (Feedback): [Proposal] Expand Find pattern to Multiple Find
- Hello! I love Ruby's pattern matching features. I would like to propose an expansion of the Find pattern which allows the selection of multiple matching elements of an array.
I often find myself dealing with data like this:
``` ruby
... -
- I submitted a pull request to fix this, by adding an rb_no_keywords_accepted C-API function and using that for both C methods and Ruby methods that do not accept keywords: https://github.com/ruby/ruby/pull/8243
-
- https://github.com/ruby/io-console/commit/653c1cd33f
-
- https://github.com/ruby/io-console/commit/5f71354332
-
- https://github.com/ruby/io-console/commit/15e36af171
-
- https://github.com/ruby/io-console/commit/040a1d6259
-
- https://github.com/ruby/io-console/commit/57f9649df4
-
- https://github.com/ruby/io-console/commit/85a155f25f
-
- https://github.com/ruby/io-console/commit/a0544eb74f
-
- There were no clear example of this very useful method's usage anywhere
in the IO or IO::Console docs, which was a shame.
https://github.com/ruby/io-console/commit/4d324586a8 -
- The `git reset` and `rm_rf` are not necessary because `bundler/` is
considered as a `toplevels` and removed from the commit when there's
no conflict.
For conflict cases, it's useful to remove them from the conflict targets
before moving... -
-
- https://github.com/ruby/yarp/commit/66ecec218d
08/17/2023
-
11:16 PM Revision e9134316 (git): [rubygems/rubygems] Raise Gem::Package::FormatError on EOF, indicating corrupt gem
- Gem::Package::TarReader::Entry now raises EOFError or returns nil
appropriately based on Ruby core IO.read and IO.readpartial behavior.
Zlib will respond accordingly by raising Zlib::GzipFile::Error on EOF.
When verifying a gem or extr... -
- * [Misc #19777] Make `Kernel#lambda` raise when called without a literal block
* There are two code paths for detecting whether a literal block was passed, best to have just one
* The way `f_lambda_warn()` does it allows `block_cod... -
- @kjtsanaktsidis Yes, please prepare backport pull requests for ruby_3_2 and ruby_3_1, then we can update the backport flags in this issue to let the branch maintainer know it is ready for backporting.
-
- This has not been relevant since https://github.com/ruby/yarp/pull/1199.
-
- Those files should be part of CRuby distributions.
-
-
-
- Schachi65 (Joachim Schachermayer) wrote in #note-2:
> In that case, the hostname is a human readable IP: 192.168.55.11
The line raising the exception is only reached if you pass a non-String to `IPAddr.new`. Your "(assumption: the ad... -
- to `main`.
This is what lib/ruby_vm/rjit/instruction.rb currently does. Letting
.time depend on those files was just a workaround. -
-
- We previously falsely asserted that String#<< always returns a ::String
instance. Issue was discovered on CI with `--yjit-verify-ctx`.
https://github.com/ruby/ruby/actions/runs/5893760435/job/15986002531 -
- Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
-
- We should return false for this type of special methods but wasn't
previously. Was reproducible with:
make test-all TESTS=../test/-ext-/test_notimplement.rb RUN_OPTS='--yjit-call-threshold=1' -
-
- This commit moves the `total_freed_objects` statistic to the size pool
which allows for `total_freed_objects` key in `GC.stat_heap`. -
- This commit moves the `total_allocated_objects` statistic to the size
pool which allows for `total_allocated_objects` key in `GC.stat_heap`. -
- `.git.*` covers those two cases.
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org> -
- nobu (Nobuyoshi Nakada) wrote in #note-5:
> I don't think "YA-" names nice in general, unless for development code name.
Agreed with you that `"YA-"` prefix is overloaded. Is your preference then something like `YARP.parse.compile` (... -
-
-
- Right now, we have to keep the buffer FFI object in sync with the
definition of yp_buffer_t because we access its fields directly. If
we add more fields or change the order, things will get out of sync.
Instead, let's treat yp_buffer_t ... - 04:07 PM Revision 75a47675 (git): [rubygems/rubygems] Add `file` option to `ruby` method in Gemfile
- https://github.com/rubygems/rubygems/commit/fb9354b7bf
-
- * YJIT: implement side chain fallback for setlocal to avoid exiting
* Update yjit/src/codegen.rs
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
---------
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com> -
10:39 AM Revision 7433c8f7 (git): [rubygems/rubygems] Clarify that `bundle info` takes a gem name
- https://github.com/rubygems/rubygems/commit/09ef74ef73
-
-
- `$(LIBRUBYARG_SHARED)` is included in `$(LIBS)` in extension
libraries. -
- Co-authored-by: Alan Wu <alansi.xingwu@shopify.com>
-
- Applied in changeset commit:git|5bb946228550c7f171c27725860b153a675404f3.
----------
[Bug #19831] Remove duplicate library options
`$(MAINLIBS)` should be included in `$(LIBRUBYARG)` in cases it is
needed. -
- `$(MAINLIBS)` should be included in `$(LIBRUBYARG)` in cases it is
needed. -
- https://github.com/ruby/yarp/commit/8fae286bc9
-
-
-
- 12:48 AM Revision f1778870 (git): Update default gems list at 45740e7a248b4b995644646e38d94b [ci skip]
-
- Ruby CI has informed us that snprintf is not available on Windows
versions, but _sprintf is supported. This commit allows us to use
_sprintf where applicable
https://github.com/ruby/yarp/commit/818cc96afe -
- https://github.com/ruby/yarp/commit/809d046f36
-
-
-
-
- https://github.com/ruby/yarp/commit/e49b63a79e
-
- https://github.com/ruby/yarp/commit/e6cea4fa08
-
- https://github.com/ruby/yarp/commit/a723f40baf
-
- https://github.com/ruby/yarp/commit/908244ba12
-
- Whenever you see a `not` or a `!`, the receiver of that method should
potentially be marked as a flip-flop.
https://github.com/ruby/yarp/commit/ba5977a40a -
- https://github.com/ruby/yarp/commit/6315890390
-
- https://github.com/ruby/yarp/commit/b490ff0919
-
- https://github.com/ruby/yarp/commit/4815d77e82
-
- Prior to this commit, we folded the flags into the type. This created
extra overhead when calculating the type and setting the flags. This
commit separates them.
https://github.com/ruby/yarp/commit/b783a5678c -
- https://github.com/ruby/yarp/commit/771f7ed789
-
- https://github.com/ruby/yarp/commit/58f839a3eb
-
- https://github.com/ruby/yarp/commit/1f9a6e05c4
-
- Right now whenever you go to create a Ruby object from a C struct
we dynamically look up the constants. This is not great for
performance. Now instead we template out a constant for each VALUE
that holds the classes, and then directly re... -
12:47 AM Revision 96aebb42 (git): [ruby/yarp] Address PR comments
- - odd whitespace
- a couple of name changes
- properly read uint32_t when not properly aligned
https://github.com/ruby/yarp/commit/3208ee3983 -
- https://github.com/ruby/yarp/commit/ad0eb4b2c3
-
- https://github.com/ruby/yarp/commit/4b157a8352
-
- https://github.com/ruby/yarp/commit/60315d0f13
-
- https://github.com/ruby/yarp/commit/8dd0a1b281
-
- Accidentally declared int32_t and not uint32_t and it was caught
on macos.
https://github.com/ruby/yarp/commit/6581520793 -
- Missing any tests and in fact this is untested so still a WIP.
https://github.com/ruby/yarp/commit/5411abd651 -
- https://github.com/ruby/yarp/commit/c1064a65e3
-
- https://github.com/ruby/yarp/commit/08081dd24f
-
- * To ensure the parser does not try to read bytes further than the end of each snippet.
https://github.com/ruby/yarp/commit/1c4438bdde -
- https://github.com/ruby/yarp/commit/d694e3ebf2
-
- https://github.com/ruby/yarp/commit/a22b204a11
-
- https://github.com/ruby/yarp/commit/5908130541
-
- https://github.com/ruby/yarp/commit/aa0dc2f301
-
- https://github.com/ruby/yarp/commit/0071bee0bb
-
- https://github.com/ruby/yarp/commit/2f83265653
-
- https://github.com/ruby/yarp/commit/a62f2f0153
-
- https://github.com/ruby/yarp/commit/837522217c
-
- https://github.com/ruby/yarp/commit/e5f6ffa23a
-
- * Otherwise it is undefined behavior to access the field of another `.as`.
* Accessing the right `.as` field according mode would be extra overhead.
https://github.com/ruby/yarp/commit/7dc41ee803 -
- https://github.com/ruby/yarp/commit/c603bba89a
-
- https://github.com/ruby/yarp/commit/638f6849be
-
- * So it can be reused by the Fiddle backend, etc and not just the C extension.
* Add YP_STRING_MAPPED to use a consistent interface for yp_string_t.
That way yp_string_free() can be used like for other string types.
* Fix handling of e... -
- * Moves logic from the C extension to librubyparser which can be shared with the Fiddle backend.
https://github.com/ruby/yarp/commit/aa48d5e444 -
- https://github.com/ruby/yarp/commit/bc9049418d
-
- https://github.com/ruby/yarp/commit/33b06f252c
-
- https://github.com/ruby/yarp/commit/584a49f123
-
- https://github.com/ruby/yarp/commit/8736c17359
-
- https://github.com/ruby/yarp/commit/2ec671fe1e
-
- https://github.com/ruby/yarp/commit/aff40871e6
-
- https://github.com/ruby/yarp/commit/638163f6c6
-
- https://github.com/ruby/yarp/commit/eeb4f6cb9d
-
- https://github.com/ruby/yarp/commit/479e835756
-
- https://github.com/ruby/yarp/commit/1cfce46107
-
- https://github.com/ruby/yarp/commit/04de272383
-
- This is more or less the code I used in my POC in JRuby
to parse evals. Evals depend on parent variable scopes
and will produce a different syntax tree.
Questions:
1. How does MRI compile evals currently? I cannot find anything.
2... - 12:47 AM Revision 0f809194 (git): [ruby/yarp] Move the gem's C extension into lib/yarp/
- and change the require from "yarp.so" to "yarp/yarp", which is more
aligned with existing community conventions for gems.
https://github.com/ruby/yarp/commit/64b70e2658 -
08/16/2023
-
-
- Appreciation to the reporter, Huichiao Tsai <hctsai.cs10@nycu.edu.tw>.
-
-
-
- 01:51 PM Revision 089227e9 (git): [DOC] Specify the unit of return value for `Time#-`
-
- (https://github.com/ruby/irb/pull/682)
* Introduce Statement class
* Split Statement class for better clarity
https://github.com/ruby/irb/commit/65e8e68690 -
- Previous sync included unrelated files and missed template file update.
-
06:03 AM Revision fe240b67 (git): [rubygems/rubygems] Show better error when PAT can't authenticate to a private server
- Before:
```
Fetching gem metadata from https://rubygems.org/........
Fetching source index from https://rubygems.pkg.github.com/my-org/
Bad username or password for https://x-access-token@rubygems.pkg.github.com/my-org/.
Please double-... -
- https://github.com/rubygems/rubygems/commit/ba3ea27869
-
- https://github.com/rubygems/rubygems/commit/ffa395411f
-
- https://github.com/rubygems/rubygems/commit/9a0e0dfd5b
-
- https://github.com/rubygems/rubygems/commit/689c39b42f
-
- This should be only for path sources, and unrelated to git.
https://github.com/rubygems/rubygems/commit/0d8f31eeed -
- https://github.com/rubygems/rubygems/commit/cfc82b592a
-
- https://github.com/rubygems/rubygems/commit/784e08348e
-
- https://github.com/rubygems/rubygems/commit/efebc64250
-
- We only need to check whether the spec if for a direct dependency once.
https://github.com/rubygems/rubygems/commit/65b455a5cb -
- https://github.com/rubygems/rubygems/commit/2ab63bb94d
- 05:48 AM Revision f1df0629 (git): [ruby/openssl] Enhance printing OpenSSL versions.
- * Updated the `OpenSSL::OPENSSL_VERSION_NUMBER` comment explaining the format.
* Added the `OpenSSL::LIBRESSL_VERSION_NUMBER` to print LibreSSL version number,
in the case that Ruby OpenSSL binding is compiled with LibreSSL. Note
`te... - 05:48 AM Revision f5ca8d0e (git): [ruby/openssl] test/openssl/test_pkey.rb: Fix pending tests in FIPS case.
- https://github.com/ruby/openssl/commit/f9980d88aa
- 05:48 AM Revision 8ca0d53f (git): [ruby/openssl] Use openssl? instead of OpenSSL::OPENSSL_VERSION_NUMBER.
- Update the `openssl?` method by adding status argument.
Note the format is below.
* OpenSSL 3: 0xMNN00PP0 (major minor 00 patch 0)
* OpenSSL 1: 0xMNNFFPPS (major minor fix patch status)
See <https://www.openssl.org/docs/man1.1.1/man3/... -
05:48 AM Revision 12bdacdc (git): [ruby/openssl] Include "additional data" message in OpenSSL errors
- Error entries in the OpenSSL error queue may contain additional
contextual information associated with the error, which can be helpful
when debugging.
This "additional data" is currently only printed to stderr when
OpenSSL.debug is enab... -
- Test that the error message contains the necessary text instead of the
exact match. Exceptions raised by ossl_raise() may carry additional
context information in the message.
https://github.com/ruby/openssl/commit/fd6f76c0d3 -
- When compiled with OpenSSL <= 1.1.1, OpenSSL::SSL::SSLContext#setup
does not raise an exception on an error return from
SSL_CTX_load_verify_locations(), but instead only prints a verbose-mode
warning. This is not helpful since it very li... - 05:48 AM Revision 8dd5c202 (git): [ruby/openssl] Raise an error when the specified OpenSSL library directory doesn't exist.
- OpenSSL built from the source creates the library directory to the
`/path/to/openssl_dir/lib64` as a default.
In the case, the `bundle exec rake compile -- --with-openssl-dir=<openssl_dir>`
cannot compile with the lib64 directory, and ma... -
- Describe the behavior of OpenSSL::PKey::{DH,DSA,EC,RSA}#to_pem
and #to_der more clearly. They return a different result depending on
whether the pkey is a public or private key. This was not documented
adequately.
Also, suggest the use ... -
- Suggest the use of OpenSSL::PKey::PKey#private_to_pem and #public_to_pem
in the top-level documentation. For new programs, these are recommended
over OpenSSL::PKey::RSA#export (also aliased as #to_s and #to_pem)
unless there is a specifi... -
- Let's consistently use the word "password". Although they are considered
synonymous, the mixed usage in the rdoc can cause confusion.
OpenSSL::KDF.scrypt is an exception. This is because RFC 7914 refers to
the input parameter as "passph... -
- This reverts commit https://github.com/ruby/openssl/commit/fc4629d246f2.
The test case "test_connect_certificate_verify_failed_exception_message"
does want to check the reason behind a certificate verification failure
to be included in ... -
- Enrich SSLError's message with the low-level certificate verification
result, even if SSL_get_error() returns SSL_ERROR_SYSCALL. This is
currently done on SSL_ERROR_SSL only.
According to the man page of SSL_get_error(), SSL_ERROR_SYSCA... -
- Expand tabs, insert some spaces, and adjust indentation of switch-case
to match Ruby's style.
https://github.com/ruby/openssl/commit/10833aa8f6 -
- ```
$ rm -f ruby; make -n ruby
rm -f ruby
echo linking ruby
clang -fdeclspec -O3 -fno-fast-math -ggdb3 -Wall -Wextra -Wextra-tokens -Wdeprecated-declarations -Wdivision-by-zero -Wdiv-by-zero -Wimplicit-function-declaration -Wimplicit... -
- This warnings are still happend with https://github.com/ruby/ruby/commit/af67ced3b0945e8ea67434f8e66ef1e602656438
```
linking ruby
ld: warning: ignoring duplicate library '-lgmp'
ld: warning: ignoring duplicate library '-ldl'
ld: ... - 01:40 AM Revision af67ced3 (git): [ruby/net-http] Update lib/net/http.rb
- @natematykiewicz's suggestion to avoid another string allocation
https://github.com/ruby/net-http/commit/4a22c42338
Co-authored-by: Nate Matykiewicz <natematykiewicz@gmail.com> - 01:40 AM Revision ae68a8df (git): [ruby/net-http] Update lib/net/http/response.rb
- @natematykiewicz's suggestion to avoid a string allocation
https://github.com/ruby/net-http/commit/925630f227
Co-authored-by: Nate Matykiewicz <natematykiewicz@gmail.com> - 01:40 AM Revision ea321a65 (git): [ruby/net-http] use +'' everywhere
- https://github.com/ruby/net-http/commit/1077427152
- 01:40 AM Revision 70da92cd (git): [ruby/net-http] Fix on 2.7
- https://github.com/ruby/net-http/commit/5194fd541e
- 01:40 AM Revision 4d21134f (git): [ruby/net-http] freeze rest of lib
- https://github.com/ruby/net-http/commit/455a74734a
- 01:40 AM Revision 4165ec91 (git): [ruby/net-http] update net/http/response to be frozen string literal
- https://github.com/ruby/net-http/commit/dc3b4a75ca
- 01:40 AM Revision 2fbd8dca (git): [ruby/net-http] turn on frozen strings for net/http/generic_request
- https://github.com/ruby/net-http/commit/b92ade088d
- 01:40 AM Revision 8d04260a (git): [ruby/net-http] turn on frozen strings for net/http/header
- https://github.com/ruby/net-http/commit/a5203c9f92
- 01:39 AM Revision 0300ea5a (git): [ruby/net-http] Improve performance of HTTPHeader#content_type
- In the existing implementation, `main_type` and `sub_type` would end up
being called multiple times potentially.
Instead of doing that, save the result so it can be re-used.
https://github.com/ruby/net-http/commit/179976f7ea -