Activity
From 05/22/2019 to 05/28/2019
05/28/2019
-
11:56 PM Revision 797d7efd (git): Prevent MJIT compilation from running while moving
- pointers.
Instead of 4fe908c1643c3f355edd787bb651aefb53b996c0, just locking the MJIT
worker may be fine for this case. And also we might have the same issue
in all `gc_compact_after_gc` calls. -
- People seem to consider BASERUBY is either 1.8 or 1.9 now. Since this
file may be executed by BASERUBY from file2lastrev.rb, I think we should
not rely on Ruby 2.0 in this file for now. -
- is yes.
We ignored the failure status of file2lastrev.rb on 73da429c36c, but it
was for an environment without BASERUBY. I think we should skip running
file2lastrev.rb on HAVE_BASERUBY=no, and run it and check the status on
HAVE_BASERUB... -
- like https://app.wercker.com/ruby/ruby/runs/mjit-test1/5cedad11105780001c4e7001?step=5cedaf6b48fad200076fe77b
-
- because it's hard to identify which test causes a hang for now.
-
09:57 PM Revision 8d837431 (git): Use IO.copy_stream
-
-
-
-
- We have no clear assertion or check of BASERUBY requirement.
I want to make the current situation more explicit.
I'm NOT saying we should support Ruby 1.9.3 here,
but I'm just checking the situation as per 05bc14d81a1d7f6af826a92371aeff... -
09:15 PM Revision 91f5a8db (git): Update to ruby/spec@0c5c5c1
-
-
-
-
- This has been unused since b7f5c573ef20dbbf5534ee3a45625c7f9d45f2ec.
-
- As ko1 added some improvements on GC.compact, I want to check if it
solved the problem too. -
03:37 PM Bug #15884: Time module fails to identify timezone correctly
- I think this shows the logic behind what is occurring here.
On my system
Time.new(2002, 12, 1).zone
=> PST
(Time.new(2002, 12, 1) + 60 * 60 * 24 * 180).zone # Add 180 days
=> PDT
Time.new(2002, 12, 1).utc.zone
=> UTC
(Time... -
03:05 PM Bug #15884 (Rejected): Time module fails to identify timezone correctly - I think the following snippet is the best summary of the problem I could write:
```
irb(main):001:0> Time.new(2012, 12, 1).utc?
=> false
irb(main):002:0> Time.new(2012, 12, 1).zone == 'UTC'
=> true
``` - 03:07 PM Revision abd55695 (git): * 2019-05-29
-
03:00 PM Revision c730c253 (git): parse.y: warn escaped whitespace
- * parse.y (warn_space_char_code): warn whitespace characters
escaped with meta/control prefix. -
-
01:45 PM Feature #15799: pipeline operator
- phluid61 (Matthew Kerwin) wrote:
> `a|:b` means `a | :b` and `a=:b` means `a = :b`
Yes I implied that a space is necessary for |: or =: to be distinguishable. It's better to have that requirement than have the three-character operat... -
11:41 AM Feature #15799: pipeline operator
- ```ruby
1.. |> take 10 |> map {|x| x*2} |> (x)
```
I believe that the ONLY sane reason for the new operator is ending the long chain with "...and now, put it into variable". The rest is total mistery, however you look at it, e.g. wh... -
09:33 AM Feature #15799: pipeline operator
- `a|:b` means `a | :b` and `a=:b` means `a = :b`
-
- konsolebox (K B) wrote:
> nobu (Nobuyoshi Nakada) wrote:
> ...
Or `=:` which is the reverse of Pascal's assignment operator. Personally I would want it to have it as an alias to `|:` than replace `|:` because `=:` would look good if i... -
- nobu (Nobuyoshi Nakada) wrote:
> duerst (Martin Dürst) wrote:
> ...
`|>=` looks heavy. Please consider `|:` instead.
-
11:26 AM Feature #10344: [PATCH] Implement Fiber#raise
- Shortly after I started to work on a library implementing algebraic effects (https://github.com/dry-rb/dry-effects) I stumbled upon lack of `Fiber#raise`. From the user POV it is important to signal improper use of effects with a meaning...
-
09:54 AM Misc #15874: DevelopersMeeting20190613Japan
- * [Feature #15777] `Module#autoload?(cname, inherit=true)`
* By default `autoload?` also check in the ancestors chain, such option would be consistent with `Module#const_defined?` and totally backward compatible.
* For more context... -
06:59 AM Bug #15880: Wrong precedence of the if modifier in pattern matching
- It's clear that the order of evaluation has to be the way it is currently. But in this case, `if` just sounds wrong, not only because of examples such as `puts 1 if condition`, but also because of general English.
So I think changing ... -
06:57 AM Revision 8a2b497e (git): remove obsolete rb_gc_finalize_deferred().
- rb_gc_finalize_deferred() is remained for compatibility with
C-extensions. However, this function is no longer working
from Ruby 2.4 (crash with SEGV immediately).
So remove it completely. -
-
-
-
05:28 AM Feature #15879: Proposal: Time#to_i accepts :unit keyword
- > In contrast to this, your proposal with Time#to_i seems to return rounded results even though the method name is to_i. I think this is confusing. Is this your intention?
It is not important whether the result is rounded or truncated... -
-
03:55 AM Revision 05bc14d8 (git): Fix building with 1.8 BASERUBY
-
- Here malloc() is enough because all elements of the page_list
will be overwrite. -
-
- The size of page_list is heap_eden->total_pages, but
init_cursors() assumes the size of page_list is `heap_allocated_pages`.
This patch fix it. -
-
-
- `heap_pages_sorted` includes eden and tomb pages, so we should not
use tomb pages for GC.compact (or we should move all of tomb pages
into eden pages). Now, I choose only eden pages. If we allow to
move Zombie objects (objects waiting fo... -
-
01:24 AM Revision fa7a768f (git): Removed inconsistency file from upstream repository of rubygems.
- followed up ae2a904ce9bffedee7d110dc60fd51c0a2879a5b
- 01:07 AM Revision 165ddfda (git): * remove trailing spaces.
-
01:07 AM Revision ae2a904c (git): Update the certificate files to make the test pass on Debian 10
- The old certificate files (for example, test/rubygems/ca_cert.pem) were
signed by SHA1. This message digest is considered too weak and rejected
by OpenSSL 1.1.1 or later. Because of this, the test suite does not
pass on Debian 10.
htt... -
- but on "master" branch.
For Pull Request, I changed the approach from
d9b338a53f520b2dbb05555f18b8de8072300f40 and
277e68825a8e4d0e6503a32e41f8b1b6c078b567. -
12:57 AM Feature #15883 (Closed): Include inspect value of object in FrozenError messages
- `FrozenError#receiver` was added recently for getting the related object programmatically. However, there are cases where FrozenError is raised and not handled, and in those cases the resulting error messages lack detail, which makes de...
-
-
-
- * parse.y (parse_atmark): numbered parameter name is not allowed
as a symbol regardless the context.
05/27/2019
-
-
09:01 PM Bug #15877: Incorrect constant lookup result in method on cloned class
- I tested this on 2.5, 2.4 and the behavior is the same there. Also this applies to subclasses as well. The first class READ determines the values for all of them.
``` ruby
class Unrelated
TEST='UNRELATED'
def test
T... -
-
-
-
-
-
05:13 PM Bug #15882 (Closed): OpenSSL::X509::Name.parse usage
- in ruby 2.5 and 2.6 the OpenSSL::X509::Name.parse_ssl method requires strings to start with forward slashes to use it as a delimiter
-
-
-
04:37 PM Bug #15880 (Rejected): Wrong precedence of the if modifier in pattern matching
- This is necessary so the `if` can depend on the variables of the matching, e.g. `in [Integer => x] if x.odd?`
-
01:51 PM Bug #15880 (Rejected): Wrong precedence of the if modifier in pattern matching
- When "If" is used as an "If modifier" it runs before the expression that it wraps:
``` ruby
=> puts 1 if (puts 2; true)
2
1
```
However, when it's used in the pattern matching destructuring runs first:
``` ruby
class A
def d... -
04:32 PM Revision b2b5ed14 (git): Supress duplicated warning
-
- ```ruby
class A
def deconstruct
puts 'deconstruct called'
[1]
end
end
case A.new
in [2]
2
in [1]
1
else
end
```
Currently this outputs:
```
deconstruct called
deconstruct called
=> 1
```
Shouldn... -
-
- This reverts commit 77bfebebc44c5e46ebd156d074081846c037f882.
- 03:20 PM Revision 11778fd2 (git): * 2019-05-28
-
-
-
-
- * parse.y (ripper_token): added Ripper#token which returns the
current token string. [EXPERIMENTAL] -
10:50 AM Feature #15879: Proposal: Time#to_i accepts :unit keyword
- I agree with sawa's comment - this is a bit surprising, at the least to me as well. It would
be better to re-use the same idioms, so that ruby users are not surprised by behaviour, if
it can be avoided.
But I think this is only one ... -
- You can also use `Time#to_r`:
```ruby
{
event_id: id,
name: name,
tracked_at: (tracked_at.to_r * 1_000).to_i,
tracked_at_micro: (tracked_at.to_r * 1_000_000).to_i
}
```
At least it's always the same multiply-and-trun... -
10:17 AM Feature #15879: Proposal: Time#to_i accepts :unit keyword
- With `Float#to_i`, the decimal part is truncated, not rounded:
```ruby
123.7.to_i # => 123
123.7.round # => 124
```
In contrast to this, your proposal with `Time#to_i` seems to return rounded results even though the method name ... -
- By analogy from `Time#round`, which takes as an argument an integer representing the precision in decimal places, and from `String#to_i`, which takes an integer, I think that passing an integer representing the number of decimal places w...
-
- I often need Unix time as microseconds or nanoseconds to serialize for other language environments.
For example, Java uses milliseconds(nanoseconds) basically.
In such a situation, current Ruby code is like below.
``` ruby
{
e... -
09:53 AM Misc #15874: DevelopersMeeting20190613Japan
- * [Bug #15733] Inconsistent `__FILE__` and `Kernel#__dir__`
-
01:00 AM Misc #15874: DevelopersMeeting20190613Japan
- * [Feature #15725] Add `Array#reverse_sort`, `#revert_sort!`, `#reverse_sort_by`, and `#reverse_sort_by!`
I would like to propose these methods as the preferred way for developers to create reverse sorted array, which is to call `sort... -
-
-
-
- Fix debug output to dump more useful information on GC.compact
debugging.
check_rvalue_consistency_force() now accepts `terminate` flag
to terminate a program with rb_bug() or only print error message.
GC.verify_internal_consistency use... -
- is_pointer_to_heap(obj) checks this obj belong to a heap page.
However, this function returns TRUE even if the page is tomb page.
This is re-commit of [712c027524].
heap_page_add_freeobj() should not use is_pointer_to_heap(), but
should... -
-
-
- OpenSSL 1.1.1 requires 2048 bits or more. This change will fix:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian/ruby-master/log/20190527T003004Z.fail.html.gz#test%2Fopen-uri -
03:27 AM Bug #15875 (Closed): const_defined? behavior inconsistency in 2.6.x series
-
-
02:19 AM Feature #15878: Make exit faster by not running GC
- chrisseaton (Chris Seaton) wrote:
> Is Ruby's GC conservative? So even if a GC is performed at exit are IO buffers guaranteed to be flushed?
Yes and yes. There is a special handling code for process termination, somewhere around htt... -
01:55 AM Feature #15878: Make exit faster by not running GC
- Is Ruby's GC conservative? So even if a GC is performed at exit are IO buffers guaranteed to be flushed?
-
- IMHO it is challenging to make a GC-less exit fundamentally safer than exit!
GC does some important tidy-up tasks for you, like ensuring contents in IO buffers flushed. -
- * lib/irb/context.rb (IRB::Context#evaluate): separate the code
from wrapping lines to propagate the given exception, not to show
the wrapping lines when SyntaxError. -
-
-
- Thank you for your initial feedback. I would like to quote one thing:
> I myself usually use `.sort` and `.sort_by`, and then apply `.reverse` afterwards.
That's definitely the reason why I submit this proposal, because `array.sort...
05/26/2019
-
-
-
-
- 09:32 PM Revision 29c16b30 (git): Add support for history with Reline backend
-
-
-
-
- to avoid cancelling overall build pipeline when stucking there.
-
07:13 PM Feature #15878 (Assigned): Make exit faster by not running GC
- I noticed that exit takes 0.2 ... I'm trying to write a fast cli, so any improvement here would be great or an option to opt-out of certain cleanup tasks
exit! takes a constant low time
```
ruby -rbenchmark -e 'puts Benchmark.realti... -
-
- for improving readability of the condition. It may be slightly faster, or may not.
-
- Applied in changeset commit:git|39eadca76b48fc7841da688f6745e40897ec37ff.
----------
Add FrozenError#receiver
Similar to NameError#receiver, this returns the object on which
the modification was attempted. This is useful as it can pin... - 06:10 PM Revision 5a6c77bb (git): * expand tabs.
-
- Similar to NameError#receiver, this returns the object on which
the modification was attempted. This is useful as it can pinpoint
exactly what is frozen. In many cases when a FrozenError is
raised, you cannot determine from the context... -
- The reason why we were checking lexer state in addition to token was
that we do not want to colorize local variable, method call, etc., while
they share the :on_ident token with a name of method definition which
should be colored as blue... -
-
-
- and sorted the token names alphabetically.
-
- Previous fix was 2993b361333147f6dfb86a153971c22329ffbaf4.
-
-
- 03:45 PM Revision 2a7821b2 (git): * 2019-05-27
-
- * parse.y (here_document): broke the terminator condition down
into each piece, the positional condition, resetting the
dedented here-document indentation, and matching identifier.
suppress a false warning by icc. -
-
01:31 PM Bug #15877: Incorrect constant lookup result in method on cloned class
- Running with `RubyVM::InstructionSequence.compile_option = {inline_const_cache: false}` produces the correct result.
-
- This behavior seems wrong to me:
``` ruby
class Foo
def test
TEST
end
end
Bar1 = Foo.clone
Bar2 = Foo.clone
class Bar1
TEST = 'bar-1'
end
class Bar2
TEST = 'bar-2'
end
# If these two lines are reorder... -
- It has not been stable recently. Let's stop notifying them for now.
-
- * parse.y (parser_yylex): adjust the error indicator of unexpected
fraction part.
before:
~~~
1.2.3
^~~
~~~
after:
~~~
1.2.3
^~
~~~ -
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/solaris11s-sunc/ruby-master/log/20190526T052508Z.fail.html.gz
-
- It is a wrapper for Timeout.timeout with the scale factor applied.
-
- * parse.y (parser_yyerror, parser_compile_error): revert
r67224 (e5d10cda07b23682e5e4e64d1324e4d3247d4785) "Flush erred
token". -
- for Solaris.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-master/log/20190525T211908Z.fail.html.gz -
-
- Please refer to the tests again.
-
- See tests for what kind of things are fixed.
-
- I have added a pull request for this feature (https://github.com/ruby/ruby/pull/2205), and made the necessary changes so it passes Travis and AppVeyor. This changes related to fixing encoding issues and working around issues in glibc re...
-
- Symbol color was made blue as a workaround because it was hard to
distinguish `foo`s in `:foo` and `def foo; end` (both are :on_ident).
But I wanted to make it yellow like pry.
`:Struct` had the same problem in :on_const. Because the :o... -
- @grosser said
> I ran into strange looking test output when I compared .to_s with an expected text, saying that the encoding was different
I thought that some string-comparison assertions (maybe attributed to an external testing fr... -
- @mame:
What @grosser is saying is that
```
p s1.encoding == s2.encoding #=> false
```
but he expects the result to be true. But you are right that what counts is the equality of the strings, not the encodings. -
- @grosser, could you elaborate your problem? I cannot reproduce the warning. What warning did you see? And how?
```
s1 = 1.to_s
p s1.encoding #=> #<Encoding:US-ASCII>
s2 = "1"
p s2.encoding #=> #<Encoding:UTF-8>
p s1 == s2 ... -
- for Solaris.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-master/log/20190525T131909Z.fail.html.gz
05/25/2019
-
- CI looks clean with https://github.com/ruby/ruby/pull/2200, so I'll be committing it in about a week if there are no objections.
-
- > which is confusing/annoying especially to users that don't know
> ...
I personally finally switched into UTF-8 (oddly enough, primarily due to emoji and
unicode-symbols that can be used for simple indications both on the commandline ... -
- I ran into strange looking test output when I compared .to_s with an expected text, saying that the encoding was different, which is confusing/annoying especially to users that don't know how encodings work in ruby.
1.to_s.encoding shou... -
-
- FWIW, I believe this is a bug.
> When a block is given and the argument is an IO-like object, it may not reach its end after exiting the each method
You mean if the block interrupts the processing with `break`, `return` or `raise`... -
-
-
- Heredoc, %i, :Foo, { 'a': ... }, ...
:'a' is still half-broken. - 03:00 PM Revision a4d44b08 (git): * 2019-05-26
-
-
- because otherwise prompt and other things could be polluted.
-
-
-
-
-
12:48 PM Feature #15868: Implement `File.absolute_path?`
- I added a couple more specs to check that in https://github.com/ruby/ruby/pull/2198/commits/d59a5c93dd4b20aa0898a24fab78a68a2cc84925, but I'm not sure where I can check whether they pass on Windows or not.
-
- New option to direct formats of RDoc to install.
-
- Show document format list to install, not only enabled or disable.
-
- RDoc needs to parse all files at once for the cross-reference.
-
- We might need to do the same thing in IRB::Color now, but I'm not doing
that as I assume ANSI escape sequence does not come from a user input
though Reline. -
- Closes: https://github.com/ruby/ruby/pull/2202
-
- Bisected to commit:bf8cc37b467e1d372e1b01b4d25e9ef6f8cc927f.
Backporting commit:d10451f3fd51f577e704db770de48d05044eb45c to 2.6 fixes this bug. -
-
- pp Ripper.lex('{ "a": 3 }')
=>
[[[1, 0], :on_lbrace, "{", EXPR_BEG|EXPR_LABEL],
[[1, 1], :on_sp, " ", EXPR_BEG|EXPR_LABEL],
[[1, 2], :on_tstring_beg, "\"", EXPR_BEG|EXPR_LABEL],
[[1, 3], :on_tstring_content, "a", EXPR_BEG|EXPR_LABEL]... -
- I think a pipeline operator can be helpful in a functional language, based on my experience with `$` in Haskell. However, I don't think it is a good idea to implement a replacement for the `.` operator just to avoid parentheses. If it...
-
- I did some testing of this recently. With ruby 2.6, the memory use is constant. With ruby 2.5, there is slight memory growth. However, considering the extensive thread changes between ruby 2.5 and ruby 2.6, it is unlikely the particul...
-
- I haven't seen `TestException#test_machine_stackoverflow` SIGSEGV in a long time on OpenBSD. I'm guessing the numerous improvements in the last 5 years make this is no longer an issue. Is anyone else seeing `TestException#test_machine_...
-
- Fixed by commit:832b601e49fd402ec7f30b36a95473131e93ae94. As taca explained, PTHREAD_COND_INITIALIZER should not be used for pthread_condattr_t.
-
- Applied in changeset commit:git|1ef39d8d099f145222b9352423af16a2bab6e05b.
----------
Fix process not waking up on signals on OpenBSD
When using UBF_TIMER_PTHREAD (the UBF handler on OpenBSD), the
timer_pthread_fn function will not sign... - 12:51 AM Revision 809ac9f2 (git): * expand tabs.
-
- When using UBF_TIMER_PTHREAD (the UBF handler on OpenBSD), the
timer_pthread_fn function will not signal the main thread with
SIGVTALRM in cases where timer_pthread is armed before
consume_communication_pipe is called. This is because
c... -
- * [Feature #14111] ArgumentErrorが発生した時メソッドのプロトタイプをメッセージに含む
Include the method prototype in the message when `ArgumentError` occurred
* [Feature #14145] Proposal: Better `Method#inspect`
* [Feature #15799] pipeline operator
05/24/2019
-
-
-
11:02 PM Bug #15875: const_defined? behavior inconsistency in 2.6.x series
- ### Side Note #1
`const_get()` could get this constant for all released versions, but has been intentionally changed in 2.7. Correct?
```
% ruby -e "module A; end; B = 1; p Object.const_get('A::B')"
[1.9.3...2.6.3]
1
[2.7.0... -
- `Module#const_defined?` returns true for unreachable nested fully qualified module name.
Here are the results of `const_defined?` for each ruby version on my machine.
```
% ruby -e "module A; end; B = 1; p Object.const_defined?('A::... -
09:45 PM Bug #15872: CSV.parse omits close call when block is given – intended or bug?
- `CSV.parse` expects a `String` as the input. So `close` isn't necessary.
If you have a problem case, could you report this with the problem case to https://github.com/ruby/csv/issues ? -
- When a block is given and the argument is an IO-like object, it may not reach its end after exiting the `each` method.
-
09:08 AM Bug #15872 (Rejected): CSV.parse omits close call when block is given – intended or bug?
- The current implementation of `CSV.parse` doesn't call `close` when a block is given:
```ruby
def self.parse(*args, &block)
csv = new(*args)
return csv.each(&block) if block_given?
begin
csv.read
ensure
csv.cl... -
08:39 PM Misc #15874: DevelopersMeeting20190613Japan
- - [Bug #15792] GC can leave strings used as hash keys in a corrupted state / bad fstring + shared string interaction can lead to use-after-free
- I have a PR https://github.com/ruby/ruby/pull/2183 for a case of this with `String#b` th... -
- Please comment your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of ticket comments)
*DO NOT* discuss then on this ticke... -
-
-
-
-
-
- If you're talking about commit:5da52d1210625fb00acd573b3f32281b4bde1730 and commit:a205e24747497391390ef7c004293a8a7934dd96, that's not related to this ticket. Please comment on #14632 or in a new ticket instead.
-
02:51 PM Misc #15843: Make "trunk" a symbolic-ref of "master" on git.ruby-lang.org
- Maybe the changes to RUBY_DESCRIPTION (ruby -v) and RUBY_REVISION could be noted somewhere...
-
- Sorry for your inconvenience, it was originally written in the ticket but I somehow deleted that in the later edit. I just resurrected the "Expected outcome" section in the original description.
-
- Please not only give us a schedule, but tell us exactly (in terms of git commands) what this means for people which are not *totally* familiar with git. Please do NOT assume that everybody "just knows".
-
- This reverts commit 481ccf73d88797914f700e6e27711bf1ce997eb0.
-
-
- 03:25 PM Revision b2150548 (git): * 2019-05-25
-
-
- Probably you are using `frozen-string-literal` pragma.
Since 2.6, OpenURI clears the buffer from `Net::HTTPResponse#read_body` to reduce memory usage.
See [Feature #14320].
-
12:58 PM Bug #15873: FrozenError when using OpenURI.open
- nobu (Nobuyoshi Nakada) wrote:
> Does it occur even if the body is `"Random information".dup`?
Just tried and no, when using `.dup` it worked as expected! -
- Does it occur even if the body is `"Random information".dup`?
-
- I just updated from Ruby 2.5.1 to 2.6.3 and I encountered a strange problem on a part that was working fine previously. It's on a Rails application, and on one of the tests I'm stubbing (using [webmock](https://github.com/bblimke/webmock...
-
-
- * https://rubyci.org/logs/rubyci.s3.amazonaws.com/aix71_ppc/ruby-trunk/log/20190522T103301Z.fail.html.gz
-
10:39 AM Feature #15831: Add `Array#extract`, `Hash#extract`, and `ENV.extract`
- > I also concern about the name conflict with the ActiveSupport method.
I guess this comment addressed https://bugs.ruby-lang.org/issues/15863 that adds `Hash#slice!`, right?
Active Support doesn't have any `extract` methods, only `e... -
10:03 AM Revision 706c816a (git): Escape dots in regexp
- 10:00 AM Revision a4da223c (git): * expand tabs.
-
- This reverts commit 712c027524e3a03500b3098d950fc2f0608ce897.
-
- Unicode version 12.1.0 was officially released on May 7th, 2019.
There were no changes at all from the "real" beta
published shortly after the new era name "Reiwa" was announced.
So we can switch UNICODE_BETA back to NO.
... -
- GC.verify_internal_consistency() checks health of each RVALUE with
check_rvalue_consistency(). However, this function is enabled
only on debug environment (RGENGC_CHECK_MODE>1). So introduce
new function check_rvalue_consistency_force() ... -
- is_pointer_to_heap() checks if it is in valid pointer to the
RVALUE in any heap_page_body. However, it returns true if it
points tomb pages. This patch check it points to eden pages. -
-
-
-
- * time.c (ndigits_denominator): calculate the denominator for
digits. -
- Ruby came out of Unicode 12.1 BETA with commit e713c2bde8. So this issue can be closed.
The reason it is more difficult to get out of beta than to enter beta is because the behavior in beta is to always check for new versions of files... -
- Completed with commit e713c2bde8
-
-
-
-
-
- 上に貼ったチケットを見る感じでは、mysql2 0.5.2 で修正されたのではないかと思っています。
-
05:03 AM Bug #15855: bundle exec rake db:migrateでsegmentation fault が発生する
- https://github.com/brianmario/mysql2/tree/master/ext/mysql2
これを見てUpdate encoding tables from MySQL 8.0.16のコミットが見つかったので、最新状態に更新したのですが、依然同じエラーが吐かれます。
mysql 8.0.16
mysql2 0.4.10です。
-
- Unicode version 12.1.0 was officially released on May 7th, 2019.
There were no changes at all from the "real" beta published shortly
after the new era name "Reiwa" was announced. So we can switch
UNICODE_BETA back to NO.
common.mk: swit... -
-
- This appears to still be a bug. The patch needed a little manual help to apply, and the tests needed to be updated, but after those changes, all tests passed. Attached is an updated patch. I'll try to commit it next week unless I hear...
-
- I've added a GitHub pull request to fix the `String#crypt` tests on OpenBSD (https://github.com/ruby/ruby/pull/2200). It's less invasive than the previous patch, and should result in the same behavior on !OpenBSD. I plan on merging it ...
-
- Applied in changeset commit:git|dfc21a0467d39af00666aec5098530529924cf48.
----------
Ignore generated files by in-place build [Bug #15870] -
- When I try to use git, I often get messages like the following:
```
Untracked files:
(use "git add <file>..." to include in what will be committed)
bin/cygruby270.dll
bin/goruby.exe
bin/ruby.exe
... -
- Applied in changeset commit:git|7f2f56b2f51269f42f822ecf346375b040267595.
----------
Define GITPULLOPTION to rebase [Bug #15871] -
- With svn, I have been using "make up" to get my local version up to date.
This works with git, except that it seems to just use `git pull` rather than `git pull --rebase`.
There is an environment variable `GITPULLOPTIONS`, which is... -
-
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/aix71_ppc/ruby-trunk/log/20190522T103301Z.fail.html.gz
-
- It fails on some CI environments.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian8/ruby-trunk/log/20190524T003006Z.fail.html.gz
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11s/ruby-trunk/log/20190523T002505Z.fail.html.gz -
- As delegate.rb is unmaintained, unless someone objects in the next week, I plan on committing this feature.
05/23/2019
-
- Out of interest, how does it treat relative paths like `C:foo\bar`?
(Funny observation: according to Microsoft, `\foo\bar` is an absolute path in Windows, according to their definition of "absolute path") -
- Thanks @nobu, I updated the patch! Copy-pasta... :|
-
- I have no particular pro/con opinion on the suggestion itself, but I should state that since Pathname was mentioned - I
myself use File.* related methods exclusively. I used to use pathname in the past but I sort of gave up on it eventu... -
- > ```diff
> ...
The method name is wrong, and `File.absolute_path?("/foo/bar")` should be false on Windows as it doesn't have the drive letter. -
- Ouch!
I actually read the `Pathname` docs, which state:
* "However non-Unix pathnames are supported experimentally", in the main section.
* "It returns true if the pathname begins with a slash", in the `#pathname` docs.
And ... -
- `Pathname("C:/foo/bar").absolute?` should return `true` on Windows.
I think it does already:
https://github.com/ruby/ruby/blob/fe3ff5afb07e171fd950623c69abfbabbb2762a3/test/pathname/test_pathname.rb#L278-L282
On non-Windows platform... -
- Currently there's no way to check whether a path is absolute or not in a way that works accross OSs. The pathname library has the #absolute? method, but that only checks whether the path starts with a slash, which is not appropriate for ...
-
- Interesting. Not sure if this has to do with Markov Chain per se, but for storing state
through automata (in bioinformatics), hidden markov models are also used. Perhaps
extending Matrix may be beneficial in general (for ruby as a lar... -
08:15 PM Feature #15869: Add abs to Matrix
- bonafernando (Fernando Wolf Bona) wrote:
> While I was studying Markov Chain I had to find the maximum absolute value of the Matrix to divide the matrix in numbers from 0 to 1 to be able to make further analysis. Like this:
> ...
PR: h... -
- While I was studying Markov Chain I had to find the maximum absolute value of the Matrix to divide the matrix in numbers from 0 to 1 to be able to make further analysis. Like this:
```
q = Matrix[ ... ]
max = q.to_a.flatten.map { |e... -
-
- IIRC, at the last meeting (20190522), the conclusion was that this method should select non-nil values only, like as `Array#compact`.
Am I correct?
-
05:51 AM Feature #15323 (Closed): [PATCH] Proposal: Add Enumerable#filter_map
- Applied in changeset commit:git|0acbdd1ed0d2302743525a5188cc5a0d6251680c.
----------
Adding Enumerable#filter_map
[Feature #15323]
Closes: https://github.com/ruby/ruby/pull/2017 - 03:42 PM Revision dde8ceaf (git): * 2019-05-24
-
- because too-large Wercker output is truncated.
ruby/mjit-debug is a private repository for now, because the person
fixing it is likely to be me or another committer. -
- for debugging
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2048247 -
-
-
-
-
- Closed by [f5415a95ce1d393a3fd1d7f657ba85d85171356a](https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisions/f5415a95ce1d393a3fd1d7f657ba85d85171356a)
I missed the tag to close the ticket. -
02:59 AM Feature #15772: Proposal: Add Time#ceil
- Thank you!
- 01:39 PM Revision 0b4d51b0 (git): * expand tabs.
-
- Closes: https://github.com/ruby/ruby/pull/2133
-
- Applied in changeset commit:git|fe3ff5afb07e171fd950623c69abfbabbb2762a3.
----------
Suppress paranoid warnings for external/3rd-party libraries
[Feature #15665] -
- From where `-Werror` and `-Wunused-parameter` came?
```
"clang -I../../.ext/include/x86_64-darwin18 -I../.././include -I../.././ext/socket -I../.. -I../../. -I/opt/local/include -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -D_DARWIN_UNLIMITED... -
05:11 AM Feature #15665: Cannot compile socket extension on Mojave
- nobu (Nobuyoshi Nakada) wrote:
> That check is necessary only for very old, 6 years ago, header.
> ...
Please find attached. I was trying to install 2.6.3 version. -
- [Feature #15665]
-
-
- Also requested by Ko1.
-
- requested by Ko1.
-
- Sanitizers and fortifications do not interface, and there is currently
no plan for them to work together.
See also https://github.com/google/sanitizers/issues/247 -
- Caller of gc_pin() should check it is a mark-able object.
So gc_pin() doesn't need to check it. With this fix,
we can refactoring around it. -
- 06:33 AM Revision c5cbabf8 (git): Use colorized IRB on Windows without checking `TERM`
-
- [Feature #15323]
Closes: https://github.com/ruby/ruby/pull/2017 -
-
- OpenBSD deprecated `crypt(3)` in November 2014 (https://github.com/openbsd/src/commit/608633c1c51b59b1f0d77d3d5b646ff8d27407aa). However, I doubt that `crypt(3)` will be removed in the near future, if ever. OpenBSD didn't remove `gets(3...
-
- Applied in changeset commit:git|c05eaa93258ddc01e685b6cc3a0da82998a2af48.
----------
Fix mixed encoding in heredoc
Heredocs are parsed line-by-line, so we need to keep track of the
temporary encoding of the string. Previously, a hered... -
- Heredocs are parsed line-by-line, so we need to keep track of the
temporary encoding of the string. Previously, a heredoc would
only detect mixed encoding errors if they were on the same line,
this changes things so they will be caught ... -
- Applied in changeset commit:git|f91b1ab33d397fdcdf452d563d7f59469a078d88.
----------
Skip assertion in readline test if Readline version is 4.3
Previously, the entire method was not run for Readline 4.3, probably
because it was known t... -
- Previously, the entire method was not run for Readline 4.3, probably
because it was known to fail. Commit
c754e979d3eeca51f1b13778f19f347df3da656e removed the check for
Readline 4.3. Other than this one assertion, which also doesn't
wor... -
- rb_gc() no longer invokes finalizers, so there are T_ZOMBE objects.
-
- Objects pointed by "maybe" pointers because of conservative marking
should be pinned down. -
- Applied in changeset commit:git|136ae55892ae120bb94e4ff2d025c745fdaa1091.
----------
Do not kick finalizers on rb_gc().
rb_gc() kicks gc_finalize_deferred(), which invokes finalizers.
This means that any Ruby program can be run this po... -
- rb_gc() kicks gc_finalize_deferred(), which invokes finalizers.
This means that any Ruby program can be run this point and
it may be thread switching points and so on.
However, it is difficult to think it invokes any Ruby programs.
For ... -
- ARRAY_ASET() does not change the length of array, so
use rb_ary_push() instead of ARRAY_ASET(). It prevents
updating reference on GC.compact.
05/22/2019
-
-
- Always checks termination if you press Enter at last line.
-
09:52 PM Bug #15867 (Closed): Enumerable#minmax inconsistent behavior with Time ranges
- With `Date` the behavior is consistent for inclusive and exclusive ranges:
```
>> (Date.new(2019, 7, 1)..Date.new(2019, 7, 3)).min
=> #<Date: 2019-07-01 ((2458666j,0s,0n),+0s,2299161j)>
> ...
=> #<Date: 2019-07-03 ((2458668j,0s,0n)... -
- > Let me see the real-world use-case, please.
Since proposed `Hash#slice!` method is the same as `Hash#extract!` from the Active Support, there is one use-case where we have some `options` then we extract some known by keys options an... -
07:44 AM Feature #15863 (Rejected): Add `Hash#slice!` and `ENV.slice!`
- I don't think we have seen the use-case that this method is absolutely necessary.
Let me see the real-world use-case, please.
Matz. -
- This reverts commit 1ebe9a2f82fef5190454e68d430004282f5da172.
because it did not help. -
- CI seems to have a weired behavior now. Debugging.
Revert "azure-pipelines.yml: Fix typo"
This reverts commit f69d28fbca1eec8b9722cea1f989ee9554e8dad5.
Revert "azure-pipelines.yml: Use simpler trigger syntax"
This reverts commit 7097... -
- follow up for d3f1c615c5
-
-
-
-
-
-
- Applied in changeset commit:git|9d39eb6b40966deeeaa23c28f0be640c56545644.
----------
range.c (inspect_range): omit beginless "nil"
except the special case `(nil..nil)`.
```
(1..).inspect #=> "1.."
(..5).inspect #=> "..5"
(ni... -
- I'd pick the following representation:
```
(1..).inspect #=> "1.."
(..5).inspect #=> "..5"
(nil..nil).inspect #=> "nil..nil"
```
Matz. -
- except the special case `(nil..nil)`.
```
(1..).inspect #=> "1.."
(..5).inspect #=> "..5"
(nil..nil).inspect #=> "nil..nil"
```
[Bug #15745] -
-
-
- Applied in changeset commit:git|d3f1c615c5b81319e422e9c92e1cb8ba82209fba.
----------
hash.c (rb_hash_s_create): Reject `Hash[[nil]]`
The behavior of `Hash[[nil]] #=> {}` was a bug until 1.9.3, but had been
remained with a warning becau... -
- The behavior of `Hash[[nil]] #=> {}` was a bug until 1.9.3, but had been
remained with a warning because some programs depended upon it.
Now, six years passed. We can remove the compatibility behavior.
[Bug #7300] - 03:15 PM Revision 4d622969 (git): * 2019-05-23
-
-
- * tool/make-snapshot: default to the current branch if no branch
but srcdir is given. -
- * tool/make-snapshot (package): dump to stringize GIT revisions
properly. -
- @jeremyevans0
Thanks a lot! I think that your v3 patch is correct...so please commit it yourself. Welcome. -
- @jeremyevans0 Congrats! Please wait for @hsbt's guidance. (He will ask you to send your ssh key.)
-
- @jeremyevans0 Welcome to the committers.
Matz. -
- * tool/make-snapshot (package): use the last revision of the whole
tree as the revision name, not a single file.
* tool/file2lastrev.rb: ditto. dump without unnecessary subrange
and literal quotes, to stringize SVN revisions properly. -
- * tool/vcs.rb (VCS::GITSVN.revision_name): should delegate to the
same method of SVN, not an undefined method. -
- > If you change something, pls tell your schedule and we can check the CI system.
Sure. I updated the description.
Once I make a symbolic-ref tomorrow, I'll post an email to ruby-core to share the schedule and ask for updating CI sys... -
- I'm negative against the Main part (moving the branch) immediately, which seems a too big change.
Why not making "master" as a symbolic-ref at first? -
- If you change something, pls tell your schedule and we can check the CI system.
-
06:30 AM Misc #15843: Make "trunk" a symbolic-ref of "master" on git.ruby-lang.org
- I don't disagree this proposal.
But, I want to know what do you mean in the term "Out of scope (for a short term)".
What is "short" ? -
- akr (Akira Tanaka) wrote:
> We are not sure the stability of RubyVM::AbstractSyntaxTree.
> ...
Right, so I think we need to document it's not stable yet as clearly as possible.
> We want to know such unstability has big impact for
... -
07:41 AM Feature #14844: Future of RubyVM::AST?
- We are not sure the stability of RubyVM::AbstractSyntaxTree.
For example, Ruby 2.7 will add new node for pattern match.
We want to know such unstability has big impact for
practical applications or not.
I feel it is difficult to ... -
- @matz Do you mean `in` rather than `if` for the keyword?
-
- I am pretty positive about adding single line pattern matching in Ruby. I am still wondering whether `if` is a right keyword for it. Let me think about it for a while.
Matz.
-
- ko1 (Koichi Sasada) wrote:
> We can't introduce guard pattern (`pat if expr`) because it will conflict with `expr if cond`.
You have to write as `val in expr and cond`. -
- Trivial comment.
We can't introduce guard pattern (`pat if expr`) because it will conflict with `expr if cond`. -
- matz (Yukihiro Matsumoto) wrote:
> I don't think we have seen the use-case that this method is absolutely necessary. I also concern about the name conflict with the ActiveSupport method.
> ...
There are use-cases of `Array#extract` in ... -
- I don't think we have seen the use-case that this method is absolutely necessary. I also concern about the name conflict with the ActiveSupport method.
Let me see the real-world use-case, please.
Matz. -
- This was fixed in https://bugs.ruby-lang.org/issues/15765
-
- This was fixed in https://bugs.ruby-lang.org/issues/15765
-
- Interesting idea. We need to investigate the idea further.
Matz.
-
- I am against having `finite?` or `infinite?` methods. I don't think there's use-case for those methods.
Meanwhile, I see the small possibility for the usage of `beginless?` and `endless?` methods. But I don't like the names.
Matz.
-
- Do you mean that `Range#infinite?` is no longer needed if the behavior of `("a"..).size` is changed? If not, I think it is a different topic from this ticket.
-
- How about doing this?
```ruby
("a".."z").size # => nil
(.."z").size # => Infinity
("a"..).size # => Infinity
```
-
- Thanks comments!
> I think infinite? is a different concept, which already exists as Numeric#infinite?, and should definitely handle the Float::INFINITY case if introduced
I also considered the following implementation.
```ruby
... -
- Note of this issue:
We assume that `ary` in `RARRAY_ASET(ary, ...)` is not FROZEN and SHARED. This code violate this assumption.
Nobu's fix solved this issue by using `rb_ary_push()` which works with a SHARED array (and added a trick... - 07:54 AM Revision 2fb69b32 (git): * expand tabs.
-
- * gc.c (rb_raw_obj_info): new string objects cannot allocate to
create new class path name during GC. -
-
- Closed by [b00f280d4b](https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisions/b00f280d4b9569e7153365d7e1c522b3d6b3c6cf)
-
- * variable.c (set_namespace_path): set path to the whole namespace
tree. [Feature #15765] -
- * variable.c (build_const_pathname): build constant path from
name as a string. [Feature #15765] -
- * variable.c: make the hidden ivars `classpath` and `tmp_classpath` the source
of truth for module and constant names. Assign to them when modules are bind
to constants.
* variable.c: remove references to module name cache, as what ... -
- I accepted the proposal at the last developer meeting but forgot to post here.
I do reject having both block and block argument at the same time. [[ruby-core:92505]](https://bugs.ruby-lang.org/issues/15323#change-77866)
Regarding `filt... -
- Could you give me speed benchmark results, for example with discourse (any rails benchmark is okay)?
If it is difficult, I'll check it.
> Same sequence of redmine requests - 6 for this branch and trunk respectively using this as a si... -
05:57 AM Bug #15866: [BUG] Segmentation fault at 0x0000000000000020
NOTE: does not happen if i remove following line from code:
request.body = "{"data":{"post ID 1":{"se_name":"google.co.uk","se_language":"English","loc_name_canonical":"London,England,United Kingdom","key":"rank checker"}}}"
-
- /bin/bash -c "/home/test/.rvm/bin/rvm ruby-2.5.0 do /home/test/.rvm/rubies/ruby-2.5.0/bin/ruby /opt/rails/test/bin/rails server -b 0.0.0.0 -p 3001 -e production"
=> Booting WEBrick
=> Rails 5.0.2 application starting in production on h... -
05:47 AM Feature #14915: Deprecate String#crypt
- Just removing deprecated feature doesn't provide additional value.
In this case UNIX crypt(3) is sometimes used as a basic building block.
Removing a wrapper of such block may cause a compatibility issue.
As usa says why OpenBSD s... -
- I feel warning is too strong.
crypt function is required to implement password checking for /etc/passwd.
-
- As a matter of practice, OpenBSD still has `crypt`.
It means that it's too difficult to remove this function at this timing, IMO.
We'll remove it in the future, I guess, but not now. -
- Accepted.
Matz.
-
02:41 AM Misc #15782: DevelopersMeeting20190522Japan
- Today's venue has been changed to Speee Inc. at Roppongi.
Do not go pixiv.