Project

General

Profile

Activity

From 05/15/2019 to 05/21/2019

05/21/2019

11:57 PM Revision a829be20 (git): Ripper: no documents of fallback methods
nobu (Nobuyoshi Nakada)
11:13 PM Feature #15864: Proposal: Add methods to determine if it is an infinite range
I have no strong opinion to the proposal itself, but I'm also skeptical to the motivating example. I'd like to write:
```ruby
def search_in(range)
path = "/search"
query = []
query << "from=#{ range.begin }" if range.begin
...
mame (Yusuke Endoh)
06:58 PM Feature #15864: Proposal: Add methods to determine if it is an infinite range
Why is `range.begin.nil? || range.end.nil?` not enough to check if beginless or endless Range?
Maybe we should integrate beginless/endless in pattern matching?
The use-case can be simplified quite a bit if we can assume `false` is ...
Eregon (Benoit Daloze)
08:16 AM Feature #15864: Proposal: Add methods to determine if it is an infinite range
I think the proposal makes sense. The method names are a bit odd though.
I have no huge qualms with the inf* related methods, such as infinite? or
finite? although it reads a bit odd; but I think that .beginless? and
.endless? are v...
shevegen (Robert A. Heiler)
01:46 AM Feature #15864 (Open): Proposal: Add methods to determine if it is an infinite range

## Summary
Proposal to add methods to determine if it is an infinite range.
## Current status
```ruby
# begin / end return nil
p (..10).begin # => nil
p (1..).end # => nil
# But, first / last raise an exception
p...
osyo (manga osyo)
10:03 PM Revision c48d9139 (git): Remove unnecessary variable in LineEditor
aycabta (aycabta .)
09:52 PM Bug #15856: Performance of redundant `Kernel.require` is slow when many gems are activated
Okay that explains what I was seeing, I just didn't realize that it was that subtle around .so loading, but I think I've verified that this is for those native libraries only.
I'd argue that your patch results in more correct and less...
lamont (Lamont Granquist)
09:48 PM Revision c00d8056 (git): Support CSI sequences in prompt
aycabta (aycabta .)
06:48 PM Feature #15865: `<expr> in <pattern>` expression
RHS assignment looks a bit weird to me.
I guess most languages have `<pattern>` SIGIL/KEYWORD `<expr>`, which seems more natural like:
```ruby
x, y, z = [1, 2, 3]
{ name:, age: } = json
if { name:, age: (20..), address: { city...
Eregon (Benoit Daloze)
04:22 PM Feature #15865: `<expr> in <pattern>` expression
Oops, the first example was wrong. Fixed.
```
-[1, 2, 3] in 1, 2, 3 #=> false
+[1, 2, 3] in 1, 2, 4 #=> false
```
mame (Yusuke Endoh)
08:21 AM Feature #15865: `<expr> in <pattern>` expression
I don't have a big pro/contra opinion per se on the whole topic of pattern matching,
but I would wait a bit before finalizing more and more additions on top of it. Now pattern
matching is probably there to say, I understand that, but i...
shevegen (Robert A. Heiler)
01:58 AM Feature #15865 (Closed): `<expr> in <pattern>` expression
How about adding a syntax for one-line pattern matching: `<expr> in <pattern>` ?
```
[1, 2, 3] in x, y, z #=> true (with assigning 1 to x, 2 to y, and 3 to z)
[1, 2, 3] in 1, 2, 4 #=> false
```
More realistic example:
```
js...
mame (Yusuke Endoh)
06:12 PM Revision ca435ed0 (git): Use Reline.test_mode in Reline's test too
aycabta (aycabta .)
05:52 PM Revision f8732bd4 (git): Reline#reset should initalize @rest_height and @screen_size eveytime
aycabta (aycabta .)
05:14 PM Revision 232f1117 (git): * 2019-05-22
git[bot]
05:13 PM Revision be86e71c (git): Reopen $stderr with specified fd by RELINE_STDERR_TTY
aycabta (aycabta .)
04:16 PM Feature #15665: Cannot compile socket extension on Mojave
hsbt (Hiroshi SHIBATA) wrote:
> Do not change status field.
> ...
That is a *workaround*. It will break in the future. Please read the bold text in the quote. If by your definition my environment is broken, then maybe next year *all* m...
franklinyu (Franklin Yu)
01:56 PM Bug #15821 (Closed): ruby_process_options() may cause "WB miss (O->Y)"
Closed by ac00bdc8a8ac2c62a94dd36a7784d15bbcb7df19 nobu (Nobuyoshi Nakada)
01:09 PM Feature #15281: Speed up Set#intersect with size check.
Just a note, for compatibility there is often a gap between what the documentation states and what Ruby programs assume.
So even though the documentation says it's unordered, I would guess there are programs relying on Sets being ordere...
Eregon (Benoit Daloze)
09:42 AM Feature #15281: Speed up Set#intersect with size check.
I'm not sure it should be called `Tuple` - to me that implies that elements can appear more than once - that it's a multi-set - and this isn't the case. chrisseaton (Chris Seaton)
08:25 AM Feature #15281: Speed up Set#intersect with size check.
There is a mathematical term "ordered set", which means a different thing: an algebra in which the elements are given intrinsic order.
The concept in question should be named `Tuple` or `UniqueTuple`.
sawa (Tsuyoshi Sawada)
02:52 AM Feature #15281: Speed up Set#intersect with size check.
It is clearly stated that Set is an unordered collection and it doesn't even guarantee any determinacy about the order of elements, and as you know, it's just it happened to become ordered and deterministic when the underlying data struc... knu (Akinori MUSHA)
12:01 PM Revision b508b623 (git): Use conssitent documentation about repository [ci skip]
This unifies our explanation with
https://github.com/ruby/www.ruby-lang.org/pull/2069
Co-authored-by: OKURA Masafumi <masafumi.o1988@gmail.com>
k0kubun (Takashi Kokubun)
11:52 AM Revision 2ecee730 (git): Remove ~/.inputrc not found error message
aycabta (aycabta .)
11:32 AM Revision 32ed85f6 (git): Copy config to make IRB::Context#use_colorize? functional
on initialize
This fixes https://github.com/ruby/ruby/pull/2188
k0kubun (Takashi Kokubun)
09:55 AM Revision 4613c4bd (git): Symbol beginning token may take a constant token
aycabta (aycabta .)
09:45 AM Revision bb5b4f90 (git): Cursor should be at line head after line breaking
aycabta (aycabta .)
09:37 AM Revision fd95ab44 (git): IRB should eval and show an error when only `.` is inputted
aycabta (aycabta .)
09:35 AM Revision 3f6b5f44 (git): re-skip tests of GC.compact.
ko1 (Koichi Sasada)
08:46 AM Revision 6d93baae (git): Support DEL key
aycabta (aycabta .)
08:45 AM Revision 8c004c71 (git): enable test for GC.compact to reproduce an issue on CI
ko1 (Koichi Sasada)
08:38 AM Feature #15854: Tracing instance variable assignment
Thanks to comments.
> :ivar_assign (close to original proposal)
> ...
Looks good. I feel they are good to read, so better than my suggested :iasgn.
> Cloud you describe a use case? ... but I don't think it applies to :casgn.
I'...
igaiga (Kuniaki Igarashi)
06:45 AM Revision 7ff4abe6 (git): unify normal and verify ver.
ko1 (Koichi Sasada)
06:02 AM Revision 0b9a7b35 (git): do not use RARRAY_SET() directly in array.c.
ko1 (Koichi Sasada)
05:23 AM Revision 44e9b1e3 (git): Fix typo
nobu (Nobuyoshi Nakada)
05:17 AM Revision ac00bdc8 (git): Do not modify shared array
[Bug #15821] nobu (Nobuyoshi Nakada)
04:49 AM Revision f9696ca6 (git): Simplified the guard against old versions
nobu (Nobuyoshi Nakada)
04:02 AM Feature #15863: Add `Hash#slice!` and `ENV.slice!`
> It should behave in the way Hash#slice does, except one thing Hash#slice! modifies the object. (See, for instance, how Array#slice and Array#slice! work, they return the same value)
I agree that it is ideal. However, in practical, ...
mame (Yusuke Endoh)
02:21 AM Misc #15782: DevelopersMeeting20190522Japan
* [Feature #15865] `<expr> in <pattern>` expression
* One-line pattern matching. ktsj, ko1, nobu, and me like it. WDYT?
mame (Yusuke Endoh)
02:15 AM Misc #15782: DevelopersMeeting20190522Japan
* [Feature #15864] Proposal: Add methods to determine if it is an infinite range
* I want to hear the opinions of developers.
osyo (manga osyo)
12:24 AM Revision be0d9c0d (git): Add "require 'irb'" to use IRB.conf
aycabta (aycabta .)
12:14 AM Revision 29c81265 (git): Check whether IRB.conf is nil in IRB::WorkSpace#code_around_binding
aycabta (aycabta .)

05/20/2019

11:57 PM Revision 3a9008b9 (git): Add --colorize and --nocolorize options to IRB
aycabta (aycabta .)
11:10 PM Revision df6a673c (git): Fix vertical cursor moving when splitting line
aycabta (aycabta .)
10:17 PM Feature #14915: Deprecate String#crypt
I have not read all comments (sorry) and it is way outside of my league to come to any meaningful
conclusion; I only skimmed through it and since it may be mentioned at the next developer meeting
I may comment (I only saw it because it...
shevegen (Robert A. Heiler)
04:50 PM Revision 34d7ec4e (git): Finish only when buffer contains non-blank line
aycabta (aycabta .)
04:49 PM Revision b69dfdb4 (git): Cursor up should reduce 1 than editing height
aycabta (aycabta .)
04:10 PM Revision 8023b3ce (git): * 2019-05-21
git[bot]
04:10 PM Revision 6592f5fc (git): Check bytesize in vi command mode last char back
aycabta (aycabta .)
03:43 PM Bug #15856: Performance of redundant `Kernel.require` is slow when many gems are activated
I had a look at this. I manage to reproduce the issue only when requiring `openssl`. In general, I think it can be reproduced when a ruby feature requires an dynamic library of the same name. In this case, `require "openssl"` resolves to... deivid (David Rodríguez)
01:08 PM Revision 583ecd5f (git): * expand tabs.
git[bot]
12:58 PM Revision e83f10b3 (git): Get rid of undefined behavior that source and destination buffers overlap
nobu (Nobuyoshi Nakada)
08:41 AM Revision 8c8f2d97 (git): Remove redundant ignore rule for Process#clock_getres specs
Eregon (Benoit Daloze)
08:41 AM Revision 2a34543e (git): Move exclusion for Hyper-V next to other skipped constants
Eregon (Benoit Daloze)
07:28 AM Feature #1153 (Closed): Enumerable#uniq
This is accepted & implemented as per #11090. shyouhei (Shyouhei Urabe)
07:23 AM Feature #15123: Enumerable#compact proposal
Just leaving a comment that I wanted this method in my pet project just now. So +1. shyouhei (Shyouhei Urabe)
05:43 AM Revision ab0f2dea (git): skip a test for CLOCK_MONOTONIC_RAW.
On my Linux guest machine on Hyper-V, I got an error.
Process.clock_gettime(CLOCK_MONOTONIC_RAW, :nanosecond) returns like:
...
875573945119100
875573945119600
...
even if `Process.clock_getres(value, :nanosecond)` returns 1.
S...
ko1 (Koichi Sasada)
03:59 AM Bug #15839: mixed encoding heredoc should be a syntax error regardless the order
nobu (Nobuyoshi Nakada) wrote:
> Would you commit that patch by yourself?
Assuming matz approves a commit bit for me at the next developer meeting, I would be happy to.
jeremyevans0 (Jeremy Evans)
03:00 AM Bug #15839: mixed encoding heredoc should be a syntax error regardless the order
Would you commit that patch by yourself? nobu (Nobuyoshi Nakada)
03:43 AM Revision 7ef548c0 (git): Mixed encoding error can continue to parse
nobu (Nobuyoshi Nakada)
12:14 AM Misc #15782: DevelopersMeeting20190522Japan
* [Feature #14915] Deprecate String#crypt
- Is anybody against adding warning?
shyouhei (Shyouhei Urabe)

05/19/2019

10:50 PM Revision 9f49ff49 (git): Cursor can't move to eol when vi command mode
aycabta (aycabta .)
10:05 PM Feature #15799: pipeline operator
Eregon (Benoit Daloze) wrote:
> Also, if we actually introduce a pipeline operator, I think it's much more useful to have Elixir semantics of passing the result as the first argument of the RHS, than just a different syntax for `.`.
...
jonathanhefner (Jonathan Hefner)
09:54 PM Misc #15782: DevelopersMeeting20190522Japan
* [Feature #15863] Add `Hash#slice!` and `ENV.slice!`(bogdanvlviv)
* I would like to discuss these methods(name, behavior, implementation), and whether we want to add them to Ruby.
* [Feature #15831] Add `Array#extract`, `Hash#extrac...
bogdanvlviv (Bogdan Denkovych)
07:52 PM Revision f659e2f9 (git): * 2019-05-20
git[bot]
07:47 PM Revision 075e1acb (git): Readline.completion_proc accepts US-ASCII
aycabta (aycabta .)
07:42 PM Feature #15863: Add `Hash#slice!` and `ENV.slice!`
I do not know how Hash#extract from Active* works but the name does not make to me
a whole lot of sense to me; however had, we have Hash#slice already so I guess it may
make sense to add .slice!; and if so, it may make sense to add it ...
shevegen (Robert A. Heiler)
06:54 PM Feature #15863 (Rejected): Add `Hash#slice!` and `ENV.slice!`
## Add `Hash#slice!`
In https://bugs.ruby-lang.org/issues/8499 we added `Hash#slice`.
`Hash#slice!` removes and returns the key/value pairs matching the given keys:
```ruby
h = {a: 100, b: 200, c: 300}
h.slice!(:a) # => {:a=>1...
bogdanvlviv (Bogdan Denkovych)
08:21 AM Bug #15791: Clarify reason for RbConfig's ruby_version not reflecting "teeny" value
ruby_version is user configurable variable:
https://github.com/ruby/ruby/blob/trunk/configure.ac#L3663
It was introduced to make possible parallel install e.g. two Ruby 2.6.0 side by side. Later somebody start to interpret it and a...
vo.x (Vit Ondruch)
07:47 AM Revision 4d7ada10 (git): Update test-unit
nobu (Nobuyoshi Nakada)
07:38 AM Feature #15665 (Feedback): Cannot compile socket extension on Mojave
That check is necessary only for very old, 6 years ago, header.
It is strange that `IN6_IS_ADDR_UNSPECIFIED` code cannot compile.
Could you show how it failed in mkmf.log?
nobu (Nobuyoshi Nakada)
12:12 AM Bug #15862 (Third Party's Issue): Segmentation fault when running Rails commands
I think this issue is a bug or spec of rb-inotify. If it is a bug, it should be fixed. If it is a spec, rails should not use rb-inotify in such an environment. Anyway, you have already filed a ticket in that bug tracker: https://githu... mame (Yusuke Endoh)

05/18/2019

10:58 PM Feature #15861: Correctly parse `file:c:/path/to/file` URIs
jeremyevans0 (Jeremy Evans) wrote:
> Looking at RFC 8089, Appendix E (`Nonstandard Syntax Variations`) states:
> ...
"may be encountered" here is meant to mean that old "poorly formed" URIs exist in the wild, and occasionally we encou...
phluid61 (Matthew Kerwin)
04:05 PM Feature #15861: Correctly parse `file:c:/path/to/file` URIs
This is definitely intentional behavior, by the way. This is how the current tests look:
```
u = URI("file:///c:/path/to/file")
assert_equal "/c:/path/to/file", u.path
# this form is not supported
u = URI("file:c:/path/t...
deivid (David Rodríguez)
04:02 PM Feature #15861: Correctly parse `file:c:/path/to/file` URIs
Yep, that's correct.
The alternative is to use the alternative form, but as you point out, the preceding slash is certainly inconvenient.
Anyways, thanks for considering this.
deivid (David Rodríguez)
03:37 PM Feature #15861: Correctly parse `file:c:/path/to/file` URIs
Looking at RFC 8089, Appendix E (`Nonstandard Syntax Variations`) states:
```
These variations may be encountered by existing usages of the file
URI scheme but are not supported by the normative syntax of
Section 2.
...
jeremyevans0 (Jeremy Evans)
03:21 PM Feature #15861 (Open): Correctly parse `file:c:/path/to/file` URIs
Recently ruby has getting better at parsing URIs using the "file" scheme, with the addition of "URI::File". Still, some Windows edge cases are not implemented, and it would be nice to have them. For example, while the [addressable gem](h... deivid (David Rodríguez)
10:31 PM Feature #15665 (Rejected): Cannot compile socket extension on Mojave
Do not change status field.
Maybe you can resolve this with `sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target /`
hsbt (Hiroshi SHIBATA)
10:29 PM Feature #15665 (Open): Cannot compile socket extension on Mojave
@hsbt That location has been [deprecated](https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes#3035624):
> The command line tools will search the SDK for system headers by default. However, some softwar...
franklinyu (Franklin Yu)
08:45 PM Revision cc764e5d (git): * 2019-05-19
git[bot]
08:45 PM Revision af150217 (git): Touch the timestamp file for Unicode files
nobu (Nobuyoshi Nakada)
04:19 PM Bug #15862 (Third Party's Issue): Segmentation fault when running Rails commands
I´ve been trying to install rbenv, ruby and rails in my Raspberry Pi 3 B+ in the past couple of days and after some issues here and there, I've managed to get everything installed with no errors
With rbenv I installed both Ruby 2.6.3 ...
destrozates (Socrates Medina)
03:20 PM Feature #14915: Deprecate String#crypt
Attached is an updated patch against trunk for deprecating `String#crypt`. This patch always warns when `String#crypt` is called, instead of just warning in verbose mode, since I would like the deprecation to be obvious in 2.7 for any r... jeremyevans0 (Jeremy Evans)
02:45 PM Feature #15831: Add `Array#extract`, `Hash#extract`, and `ENV.extract`
I just changed the implementation of `Hash#extract` and `ENV::extract` as it's described in the previous note https://bugs.ruby-lang.org/issues/15831#note-4 bogdanvlviv (Bogdan Denkovych)
02:44 PM Bug #14595 (Closed): Set filename when initializing a logger with a File object to make reopen work
jeremyevans0 (Jeremy Evans) wrote:
> I have added a pull request to logger upstream for this: https://github.com/ruby/logger/pull/30
Pull request was merged, so this can be closed.
jeremyevans0 (Jeremy Evans)
11:06 AM Revision 60de1725 (git): [DOC] Shorten examples for Time#{round,floor}
stomar (Marcus Stollsteimer)
11:06 AM Revision cc0e460b (git): [DOC] Improve documentation for Time#floor
Use numbers that are more illustrative for #floor. stomar (Marcus Stollsteimer)
11:05 AM Revision f782e5bd (git): [DOC] Use '&&' instead of 'and' in boolean expression
stomar (Marcus Stollsteimer)
11:04 AM Revision acf6689a (git): [DOC] Improve documentation for Enumerator::Lazy
stomar (Marcus Stollsteimer)
09:24 AM Revision 154a67f1 (git): Rename rb_gc_new_location to rb_gc_location
The function will return new or existing locations depending on whether
or not the object actually moved, so give it a more appropriate name.
tenderlovemaking (Aaron Patterson)
07:06 AM Misc #15860 (Rejected): Please ignore this ticket; a test for redmine(2nd)
hsbt (Hiroshi SHIBATA)
07:04 AM Misc #15860 (Rejected): Please ignore this ticket; a test for redmine(2nd)
Second try with https://bugs.ruby-lang.org/issues/15858 hsbt (Hiroshi SHIBATA)
06:22 AM Misc #15859: Is Unicode in beta?
The `UNICODE_BETA = yes` flag is causing a full download of the relevant `index.html` files to get the actual filenames of the files we need (because in beta, these do change). But we use `If-Modified-Since` even in BETA, so there are no... duerst (Martin Dürst)
05:20 AM Revision bbb84a16 (git): Add fall through comment for Coverity Scan
znz (Kazuhiro NISHIYAMA)
03:48 AM Revision 16917cc3 (git): Add Reline.test_mode to use with special I/O
aycabta (aycabta .)
03:17 AM Revision b165bedc (git): skip a test to pass CIs.
I'm debugging [Bug #15821] but my patch introduces another issue.
So I simply skip this test and re-enable it later.
ko1 (Koichi Sasada)
01:04 AM Bug #15763: Segmentation fault in timeout.rb / sleep
Nix that: single Puma worker makes no difference. Back to segfault in timeout.rb. alexagranov (Alex Agranov)
12:17 AM Bug #15763: Segmentation fault in timeout.rb / sleep
I came here after seeing the same segfault in timeout.rb / CFUNC :sleep on ruby 2.6.2 on MacOS with a Rails project running with Puma and 2 worker threads.
Installed 2.6.3 and now seeing the segfault coming from pg - but interestingly...
alexagranov (Alex Agranov)
12:41 AM Revision 6ae1c596 (git): Add test for UNTIL
nobu (Nobuyoshi Nakada)
12:40 AM Revision 4d9c3a8c (git): Update include files on msys2 too
nobu (Nobuyoshi Nakada)
12:39 AM Revision 719ebbec (git): Get rid of always updating Unicode files
[Misc #15859] nobu (Nobuyoshi Nakada)
12:35 AM Revision c4bad9f7 (git): Distinguish pre-condition and post-condition loops
nobu (Nobuyoshi Nakada)

05/17/2019

08:20 PM Misc #15859: Is Unicode in beta?
See https://github.com/ruby/ruby/pull/2193 MSP-Greg (Greg L)
01:58 PM Misc #15859: Is Unicode in beta?
@duerst
Sorry for the ping, I noticed the commit where the flag was flipped. Appveyor (and maybe other CI) is having issues with reliable connections to Unicode.org. I think if this is reset, the Unicode files will be cached?
MSP-Greg (Greg L)
01:41 PM Misc #15859 (Closed): Is Unicode in beta?
I'm not totally sure, but is this flag causing Unicode files to not be cached?
```
UNICODE_BETA = YES
```
https://github.com/ruby/ruby/blob/0723c107f4fb39f60113b44dd21d875c90da5456/common.mk#L22
MSP-Greg (Greg L)
07:53 PM Feature #14844: Future of RubyVM::AST?
mame (Yusuke Endoh) wrote:
> Eregon (Benoit Daloze) wrote:
> ...
I think that is not enough, because when people look at the documentation of RubyVM::AbstractSyntaxTree,
they don't necessarily look at the documentation of every parent...
Eregon (Benoit Daloze)
04:22 PM Feature #14844: Future of RubyVM::AST?
Eregon (Benoit Daloze) wrote:
> Could you or @yui-knk propose a description to include in the documentation, summarizing what was said?
I think that it is stated very clearly in the doc of RubyVM module.
```
/*
* Docume...
mame (Yusuke Endoh)
12:56 PM Feature #14844: Future of RubyVM::AST?
@mame Thank you for the reply.
Could you or @yui-knk propose a description to include in the documentation, summarizing what was said?
Could you also give your opinion on accessing Node members by name (https://bugs.ruby-lang.org/i...
Eregon (Benoit Daloze)
01:05 AM Feature #14844: Future of RubyVM::AST?
Eregon (Benoit Daloze) wrote:
> There was some discussion on Twitter about RubyVM::AbstractSyntaxTree, however so far no answer from its maintainers:
> ...
Sorry for not replying.
> It seems clear RubyVM::AbstractSyntaxTree is not...
mame (Yusuke Endoh)
05:41 PM Revision 39336a42 (git): * 2019-05-18
git[bot]
05:32 PM Revision 9858d74a (git): Remove parent namespace from Readline test classes
The namespace "Readline" doesn't exist when running tests if readline.so
doesn't exist and Reline exists. So test classes shouldn't be at nested
namespaces under "Readline".
aycabta (aycabta .)
04:23 PM Bug #15853: Fix readline test regression when using Readline 4.3
mame (Yusuke Endoh) wrote:
> @jeremyevans0 I think you should have a commit bit. If you don't mind, I'll commend you to a committer and ask matz at the next developers' meeting. What do you think?
I would be very honored to be a ru...
jeremyevans0 (Jeremy Evans)
03:23 PM Bug #15853: Fix readline test regression when using Readline 4.3
@jeremyevans0 I think you should have a commit bit. If you don't mind, I'll commend you to a committer and ask matz at the next developers' meeting. What do you think? mame (Yusuke Endoh)
03:00 PM Bug #15853: Fix readline test regression when using Readline 4.3
aycabta (aycabta .) wrote:
> The condition was for GNU Readline 4.3's bug but the deletion is my mistake. I agreed with your first proposal. But the first patch is not correct. The `defined?(Reline)` doesn't mean that Reline is as Readl...
jeremyevans0 (Jeremy Evans)
09:39 AM Bug #15853: Fix readline test regression when using Readline 4.3
The condition was for GNU Readline 4.3's bug but the deletion is my mistake. I agreed with your first proposal. But the first patch is not correct. The `defined?(Reline)` doesn't mean that Reline is as Readline so I added a condition tha... aycabta (aycabta .)
02:08 PM Revision ea3e7e26 (git): Prevent Dynamic -> Static symbols from moving
If a dynamic symbol has been converted to a static symbol, it gets added
to the global ID list and should no longer move. C extensions can pass
symbols to rb_sym2id and those symbols should no longer be movable.
When the symbol is passe...
tenderlovemaking (Aaron Patterson)
11:37 AM Misc #15858 (Rejected): Please ignore this ticket; a test for redmine
mame (Yusuke Endoh)
11:36 AM Misc #15858 (Rejected): Please ignore this ticket; a test for redmine
Can we select "ruby-dev in Japanese" as a preferred language? mame (Yusuke Endoh)
10:40 AM Bug #15857 (Closed): <=> の右辺が <=> を実装していない場合の振る舞い
`<=>` の右辺が `<=>` を実装していないとき、`nil` が返却される場合と例外が発生する場合があり一貫性がないように思えるのですが、意図的でしょうか。
```ruby
0 <=> 0i #=> NoMethodError (undefined method `<=>' for (0+0i):Complex)
0 <=> BasicObject.new #=> nil
:a <=> 0i ...
shuujii (Shuji KOBAYASHI)
04:55 AM Revision 0723c107 (git): Do not export InitVM functions
nobu (Nobuyoshi Nakada)
04:16 AM Revision e29a85a9 (git): Make COROUTINE_XMM_REGISTERS compile-time only too
nobu (Nobuyoshi Nakada)
04:16 AM Revision b1b38546 (git): Do not call memcpy if copying nothing
c.f.
* e7b18ca6d9b45b7e71694557b9fab8152c62c1ed
* 34e1079aef81d108890fb167d7df69960e994ff5
nobu (Nobuyoshi Nakada)
03:59 AM Revision 32e8b428 (git): skip tests for GC.compact to pass CI.
Now, GC.compact has issues which makes rubyci RED, so I skip this test
and debug soon.
ko1 (Koichi Sasada)
01:10 AM Revision f1f40294 (git): * 2019-05-17
git[bot]
01:05 AM Revision 0971cab4 (git): Test to disable ASCII-only optimization
Examples why ASCII-only optimization cannot apply multi-byte
encodings which have 7-bit trailing bytes.
Suggested by @duerst at https://github.com/ruby/ruby/pull/2187#issuecomment-492949218
nobu (Nobuyoshi Nakada)
12:38 AM Bug #14595: Set filename when initializing a logger with a File object to make reopen work
I have added a pull request to logger upstream for this: https://github.com/ruby/logger/pull/30 jeremyevans0 (Jeremy Evans)

05/16/2019

11:23 PM Bug #15856 (Assigned): Performance of redundant `Kernel.require` is slow when many gems are activated
ref. https://github.com/rubygems/rubygems/issues/2762 hsbt (Hiroshi SHIBATA)
05:16 PM Bug #15856 (Closed): Performance of redundant `Kernel.require` is slow when many gems are activated
With many gems activated, performance of `Kernel.require` (renamed `Kernel.gem_original_require` after rubygems is loaded) is slow even when `require` has already been called (the redundant case).
This is likely because its string arg...
lamont (Lamont Granquist)
09:54 PM Bug #15809: GC.verify_compaction_references - intermittent SEGV's on multiple platforms
I added a patch to (hopefully) allow `ruby/test_gc_compact.rb` to run with the rest of tests, which may help in determining if more tests are incompatible with it.
Decreased the 'time-to-live' of `DRb::TimerIdConv` objects from the de...
MSP-Greg (Greg L)
08:03 PM Bug #15809: GC.verify_compaction_references - intermittent SEGV's on multiple platforms
@wanabe
Thank you for your work on this. Today, I had the SEGV fault again during a ruby-loco build, and have found that running the two following test files will cause a SEGV:
```
drb/test_drbobject.rb ruby/test_gc_compact.rb
...
MSP-Greg (Greg L)
09:06 PM Misc #11783: Do you have any idea if you have a budgets?
Guido (the creator of python) linked in this at twitter recently, for python:
https://www.python.org/psf/donations/2019-q2-drive/
Perhaps something similar could be done for ruby, in particular right at
the starting homepage at:
...
shevegen (Robert A. Heiler)
05:07 PM Bug #15779: After NoMemoryError, ruby freezes and takes 100% CPU
Thank you for your reply!
In my environment, this patch with ruby 2.6.3 has been fixed this issue (ruby was not frozen)!!
```
~/opt/ruby/bug15779_v2_6_3_fix/bin/ruby ~/tmp/a.rb
#<StringIO:0x000055914e06fda8 @base_uri=#<URI::HTTPS h...
buzztaiki (Taiki Sugawara)
03:54 PM Bug #15798: Fix threads not waking up on SIGINT when using UBF_TIMER_PTHREAD
I've tested on Linux when forcing UBF_TIMER_PTHREAD. While the patch does not appear to be necessary on Linux, there are no regressions in the tests when using it, so it should be safe. It does fix the annoying current behavior on Open... jeremyevans0 (Jeremy Evans)
02:35 PM Bug #15855 (Third Party's Issue): bundle exec rake db:migrateでsegmentation fault が発生する
おそらくこれだと思います。→ https://github.com/brianmario/mysql2/issues/975 mame (Yusuke Endoh)
12:43 PM Bug #15855 (Third Party's Issue): bundle exec rake db:migrateでsegmentation fault が発生する
OS: MacOS Mojave 10.14.4
rails: 4.2.10
rbenv 1.1.2
rails s は正常に起動しますが、マイグレートができません。
OSがLinuxであること以外は全く同じの環境では問題なくマイグレートできるのでOSに対応していないことが原因と思われます。
実行時のエラーとDiagnosticReportsの2ファイルを添付しておくので確認をよろしくお願いします。
rennaka (Ren Nakamura)
02:34 PM Revision 23751a26 (git): leaked-globals: check if un-prefixed symbols leak externally
nobu (Nobuyoshi Nakada)
12:58 PM Revision e0f0ab95 (git): Remove unused symbols
nobu (Nobuyoshi Nakada)
09:25 AM Revision 0ed9bdfc (git): Pack struct rb_strterm_heredoc_struct on 32-bit platforms
nobu (Nobuyoshi Nakada)
08:37 AM Feature #15854: Tracing instance variable assignment
> I suggest a feature "tracing instance variable assignment"
I love introspection. The old pickaxe had an example tracing global variables, and
it would seem nice if we could extend this to other/more variables, so I am +1 for
the s...
shevegen (Robert A. Heiler)
07:00 AM Feature #15854: Tracing instance variable assignment
This feature would be helpful if it were integrated with byebug's tracevar, which currently supports only global variable tracing.
> :iasgn (IASGN name from RubyVM::AbstractSyntaxTree::Node)
> ...
For me it's hard to understand what'...
k0kubun (Takashi Kokubun)
06:34 AM Feature #15854 (Assigned): Tracing instance variable assignment
I suggest a feature "tracing instance variable assignment". It's useful for debugging.
Use case:
In Rails, we use instance variables in views and controllers. When we got a bug caused by instance variable unintentional values, if w...
igaiga (Kuniaki Igarashi)
08:18 AM Revision 88449100 (git): don't need to sweep rest.
`transient_heap_evacuate()` disables GC using `rb_gc_disable()`
to prohibt GC invocation because of new allocation for evacuated
memory. However, `rb_gc_disable()` sweep all rest of unswept pages.
We don't need to cancel lazy sweep so th...
Koichi Sasada
06:52 AM Revision a160b2f5 (git): Make COROUTINE_REGISTERS compile-time only not to be a global symbol
nobu (Nobuyoshi Nakada)
06:43 AM Revision 7069f64c (git): Prefix global_symbols with `ruby_`
nobu (Nobuyoshi Nakada)
06:41 AM Revision 973431c0 (git): Make internal functions static
nobu (Nobuyoshi Nakada)
06:14 AM Revision 82332c7d (git): Rename mjit_gc_finish_hook to mjit_gc_exit_hook
because @ko1 said "gc_finish" is confusing like a finish of entire GC
process
k0kubun (Takashi Kokubun)
05:58 AM Revision 18e43e82 (git): Fix fd leak
merged https://github.com/rubygems/rubygems/pull/2765 nobu (Nobuyoshi Nakada)
05:43 AM Revision fadab0f9 (git): * 2019-05-16
git[bot]
04:57 AM Bug #15853: Fix readline test regression when using Readline 4.3
mame (Yusuke Endoh) wrote:
> ```
> ...
Correct, sorry about that. How about just eliminating the assertion, since it is readline implementation and version dependent, and of questionable use (who calls `Readline.output.read` after `Re...
jeremyevans0 (Jeremy Evans)
04:39 AM Bug #15853: Fix readline test regression when using Readline 4.3
```
- if !defined?(Reline) or Readline != Reline # Reline's rendering logic is tricky
+ unless defined?(Reline) or Readline == Reline or /\A4\.3\z/n.match(Readline::VERSION) # Reline's rendering logic is tricky
```
Th...
mame (Yusuke Endoh)
04:20 AM Bug #15853 (Closed): Fix readline test regression when using Readline 4.3
commit:c754e979d3eeca51f1b13778f19f347df3da656e removed the check for Readline 4.3 in a test. Previously, the whole test was skipped on Readline 4.3. However, it turns out that Readline 4.3 runs the test correctly if you skip the same ... jeremyevans0 (Jeremy Evans)
02:46 AM Feature #15797: Use realpath(3) instead of custom realpath implementation if available
Attached is the latest version of this patch, with the following improvements:
* Add configure check for realpath(3), to enable this code path automatically.
* Even if realpath(3) is supported, use current code if RB_REALPATH_DIR is ...
jeremyevans0 (Jeremy Evans)

05/15/2019

11:41 PM Bug #15809: GC.verify_compaction_references - intermittent SEGV's on multiple platforms
gc_update_references() updates finalizer_table after https://git.ruby-lang.org/ruby.git/commit/?id=3cf767ee.
Therefore, "[BUG] ROOT finalizers points to MOVED" error seems to be suppressed.
I guess the [BUG] of [ruby-core:92665] is ...
wanabe (_ wanabe)
06:26 PM Bug #15809: GC.verify_compaction_references - intermittent SEGV's on multiple platforms
Still having intermittent SEGV, today:
```
/ruby/test/ruby/test_gc_compact.rb:129: [BUG] Object 0x000000000e2c9a80 [0 ] proc (Proc) block in on_gc@/install/lib/ruby/2.7.0/drb/timeridconv.rb:65 points to MOVED: 0x0000000001daec28 ...
MSP-Greg (Greg L)
11:24 PM Bug #15839: mixed encoding heredoc should be a syntax error regardless the order
After additional analysis, I found that I only needed to add one line to my initial patch to fix it to work with both `\u` before `\x` and `\u` after `\x`. With the attached patch (which supersedes the previous patches):
```
$ ruby ...
jeremyevans0 (Jeremy Evans)
03:24 PM Bug #15839: mixed encoding heredoc should be a syntax error regardless the order
nobu (Nobuyoshi Nakada) wrote:
> Thank you, but it doesn't work for the reverse order, `\u` followed by `\x`.
That is because the `\x` escape does not do the same type of encoding voodoo that the `\u` escape does. Not sure if we wan...
jeremyevans0 (Jeremy Evans)
09:31 AM Bug #15839: mixed encoding heredoc should be a syntax error regardless the order
Thank you, but it doesn't work for the reverse order, `\u` followed by `\x`.
nobu (Nobuyoshi Nakada)
05:13 AM Bug #15839: mixed encoding heredoc should be a syntax error regardless the order
Heredocs are parsed line-by-line, and mixed encoding is
already detected if it is on the same line:
```ruby
#encoding: cp932
p <<-STR
\xe9\x9d\u1234
STR
# UTF-8 mixed within Windows-31J source
# \xe9\x9d\u1234
# syntax error...
jeremyevans0 (Jeremy Evans)
09:52 PM Bug #15852: APPLICATION_VERIFIER_LOCKS_LOCK_IN_FREED_HEAP on exiting ruby
Uhh, I don't know how to add maintainers, sorry! test35965@gmail.com (Alexander Riccio)
09:05 PM Bug #15852 (Closed): APPLICATION_VERIFIER_LOCKS_LOCK_IN_FREED_HEAP on exiting ruby
Ruby appears to be freeing some critical section in ruby_vm_destruct before deleting the critical section. Critical Section objects must be deleted with DeleteCriticalSection (https://docs.microsoft.com/en-us/windows/desktop/api/synchapi... test35965@gmail.com (Alexander Riccio)
09:46 PM Misc #15782: DevelopersMeeting20190522Japan
* [Feature #14844] Future of RubyVM::AST?
* What can we do about this? The current situation is confusing for everyone, the API sounds "blessed" by being in core but it's actually experimental and unstable.
Can we document it as ...
Eregon (Benoit Daloze)
12:45 PM Misc #15782: DevelopersMeeting20190522Japan
* [Bug #7300] Hash#[] の挙動が 1.9.3 と異なっている
* Can we merge this?
hsbt (Hiroshi SHIBATA)
09:13 AM Misc #15782: DevelopersMeeting20190522Japan
* [Feature #15778] Expose an API to pry-open the stack frames in Ruby
* Several points were made in favor of Ruby API. Can we make it so this API is clearly marked as "should only be used for debugging"? Are there other concerns?
Eregon (Benoit Daloze)
09:37 PM Feature #14844: Future of RubyVM::AST?
There was some discussion on Twitter about RubyVM::AbstractSyntaxTree, however so far no answer from its maintainers:
https://twitter.com/eregontp/status/1125314952368218112
It seems clear RubyVM::AbstractSyntaxTree is not for seriou...
Eregon (Benoit Daloze)
09:05 PM Feature #15833: Some refactors for shared-root array
I think RARRAY_SHARED_ROOT_FLAG could be in internal.h, if you want to expose it outside of array.c but not as public C API.
Longer-term I think we should move struct RArray to internal.h, but that's a much bigger/riskier change so no...
Eregon (Benoit Daloze)
08:58 PM Bug #15542 (Third Party's Issue): Segmentation fault when Interrupted on rabbit.gem for ruby 2.7.0dev
Sorry. I missed this.
This is a problem of Ruby-GNOME2 or Rabbit. So we can close this.
kou (Kouhei Sutou)
12:56 PM Bug #15542 (Assigned): Segmentation fault when Interrupted on rabbit.gem for ruby 2.7.0dev
I'm not sure this is caused by ruby core changes.
@kou Can you confirm this?
hsbt (Hiroshi SHIBATA)
08:33 PM Feature #6590: Dealing with bigdecimal, etc gems in JRuby
@hsbt I wonder, is there a plan for addressing this?
There are now many default gems as shown by https://stdgems.org/, a fair amount of them being C extensions and not pure-Ruby.
Basically, there will be similar situations with Truff...
Eregon (Benoit Daloze)
03:06 PM Misc #15851 (Closed): stdlib extension gems - building/testing on Windows
Along with maintaining ruby-loco, I've encouraged and helped a few popular extension gems with building/testing on Windows/Appveyor.
I decided that a PowerShell based system to compile, build the gem, followed by gem install & test wa...
MSP-Greg (Greg L)
02:17 PM Revision e970ab33 (git): Suppress unused-but-set-variable warning
nobu (Nobuyoshi Nakada)
12:53 PM Bug #11031 (Rejected): Segmentation Fault on Gem Uninstall
Ruby 2.1 was EOL today. hsbt (Hiroshi SHIBATA)
12:51 PM Bug #8836 (Assigned): [BUG] Bus Error with bundler on large Gemfile when resolving dependencies
hsbt (Hiroshi SHIBATA)
12:45 PM Feature #14385 (Assigned): Deprecate back-tick for Ruby 3.
hsbt (Hiroshi SHIBATA)
12:43 PM Feature #9456: Include bin/racc with ruby
We resolved the issue of license on upstream. I'm going to merge bin/racc after it was fixed some of build failures: https://github.com/ruby/ruby/pull/2186 hsbt (Hiroshi SHIBATA)
09:19 AM Revision 214e2f93 (git): Fix the warning in 456586bb234915107da255d2944f620a7dd7048b
nobu (Nobuyoshi Nakada)
09:10 AM Feature #15778: Expose an API to pry-open the stack frames in Ruby
One thing we can do in any case for TruffleRuby is implementing the `debug_inspector` C API.
However, that doesn't let JRuby implement it, and hiding APIs in C doesn't seem a good way to communicate "should only be used for debugging"...
Eregon (Benoit Daloze)
08:56 AM Revision 3cf767ee (git): unpin finalizers and update references
tenderlovemaking (Aaron Patterson)
08:31 AM Revision c9b28fd7 (git): Allow --enable/--disable options to take an argument
[Bug #15850] nobu (Nobuyoshi Nakada)
08:26 AM Feature #15848: Silence warning when conditional assignments are wrapped in parentheses
nobu (Nobuyoshi Nakada) wrote:
> No, it doesn't.
> ...
It didn't occur to me the warning is aware of that. I should have tested with the actual example code. Thanks for the clarification nobu!
And thanks for closing it as a duplicat...
sos4nt (Stefan Schüßler)
06:49 AM Feature #15848 (Rejected): Silence warning when conditional assignments are wrapped in parentheses
sos4nt (Stefan Schüßler) wrote:
> ```ruby
> ...
No, it doesn't.
That warning is only when the RHS is a literal, but a method call doesn't cause the warning.
nobu (Nobuyoshi Nakada)
06:52 AM Revision f54aa6c5 (git): Rename confuzed name Reline::IO with Reline::IOGate
aycabta (aycabta .)
05:19 AM Bug #15850 (Closed): Deprecate and remove optparse/ac
- It seems not maintained since forever.
- Not documented in any form.
- I have never seen someone actually using it.
- It does not actually emulate autoconf; for instance it cannot parse `--enable-fiber-coroutine=amd64` (this is a va...
shyouhei (Shyouhei Urabe)
03:41 AM Revision 0cc893d0 (git): Static symbols can't be moved (they are not RValue)
This is my mistake, I thought they were regular objects, but apparently
they are not. We don't need to pin them.
Revert "Symbols can move so only cache IDs"
This reverts commit 672ee5f6ed5a6840a3be9150b6721a5ee8f8766b.
tenderlovemaking (Aaron Patterson)
03:30 AM Revision 672ee5f6 (git): Symbols can move so only cache IDs
IDs can't move, we need to use them to look up the symbol objects later. tenderlovemaking (Aaron Patterson)
03:21 AM Revision e8b929b9 (git): * expand tabs.
git[bot]
03:21 AM Revision c70ceb59 (git): Add object packing strategies for compaction
This commit adds an alternative packing strategy for compaction.
Instead of packing towards "most pinned" pages, we can pack towards
"most empty" pages. The idea is that we can double the heap size, then
pack all objects towards the emp...
tenderlovemaking (Aaron Patterson)
 

Also available in: Atom