Ruby

The behaviors in 2.0 are incorrect both.

Hi,

Before r45272 this code worked:

require 'minitest/autorun' class DefaultArg < MiniTest::Unit::TestCase class Default def foo; 'foo'; end def bar foo = foo foo end end def test_default assert_equal 'foo', Default.new.bar end end 

Was this expected to break? Unfortunately we have real code that depends on the behavior:

https://github.com/rails/rails/blob/81d08abcccf2ef1b0ea6e98daf00f6ca375f3d8a/activerecord/lib/active_record/associations/has_many_association.rb#L74

but we can change it

Aaron Patterson wrote:

Was this expected to break?

Yes. It was a bug.
An assignment creates a variable and it hides same name method in its RHS, as you can't call foo method inside bar method:

 def foo; 'foo'; end def bar foo = foo # nil end 

Unfortunately we have real code that depends on the behavior:

https://github.com/rails/rails/blob/81d08abcccf2ef1b0ea6e98daf00f6ca375f3d8a/activerecord/lib/active_record/associations/has_many_association.rb#L74

Sorry for the bug.

but we can change it

Always you can call the method explicitly with ().

Ok! I will fix the code in Rails. Thank you!

Nobu, are you sure this is a bug? This test has worked since 1.9.3, and this code was committed in 2008:

https://github.com/rails/rails/blob/master/activesupport/lib/active_support/values/time_zone.rb#L285

It's been the behavior for at least 6 years. I don't mind changing Rails to work with this, but people who don't test with trunk may get a nasty surprise when Ruby 2.2 is released.

Edit: here's a better link: https://github.com/rails/rails/blob/15720df1808b249bae91e5600d6f0676990a7de0/activesupport/lib/active_support/values/time_zone.rb#L285

Yes, it's a very old bug.
Optional arguments have same semantics as assignments.

Hi,

I think this change should not be backported to stable branch.
I agree about that it is a long standing bug. But it lives too long to change a behavior during stable releases.
I'm going to fill 'DONTNEED' in 'Backport' field if there's no objection.