➜ 
This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-04-05 04:29 by methane, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 25273 | merged | methane, 2021-04-08 06:20 | |
| Messages (7) | |||
|---|---|---|---|
| msg390223 - (view) | Author: Inada Naoki (methane) *  | Date: 2021-04-05 04:29 | |
logging.basicConfig() uses locale encoding when reading config file. We need to add `encoding=None` parameter and `encoding=io.text_encoding(encoding)` in it. | |||
| msg390502 - (view) | Author: Inada Naoki (methane) * | Date: 2021-04-08 06:13 | |
s/basicConfig/fileConfig/ basicConfig() is fixed by fb7869. | |||
| msg390941 - (view) | Author: Inada Naoki (methane) * | Date: 2021-04-13 09:17 | |
New changeset c2b7a66b91cdb96fbfdb160f96797208ddc5e436 by Inada Naoki in branch 'master': bpo-43731: Add an `encoding` parameter to logging.fileConfig() (GH-25273) https://github.com/python/cpython/commit/c2b7a66b91cdb96fbfdb160f96797208ddc5e436 | |||
| msg390944 - (view) | Author: STINNER Victor (vstinner) * | Date: 2021-04-13 09:48 | |
> fileConfig(fname, defaults=None, disable_existing_loggers=True, encoding=None) If "locale" is the intended default, why not being more explicit and use encoding="locale"? | |||
| msg390952 - (view) | Author: Inada Naoki (methane) * | Date: 2021-04-13 10:11 | |
If we use `encoding="locale"` by default, EncodingWarning will be not be emitted even when user omit `encoding` option. | |||
| msg390967 - (view) | Author: STINNER Victor (vstinner) * | Date: 2021-04-13 14:11 | |
Ah, so you want to emit an EncodingWarning when fileConfig(filename) is called without specifying an encoding, right? | |||
| msg391016 - (view) | Author: Inada Naoki (methane) * | Date: 2021-04-13 23:33 | |
> Ah, so you want to emit an EncodingWarning when fileConfig(filename) is called without specifying an encoding, right? Yes, but only when the user uses `PYTHONWARNDEFAULTENCODING`. I already added `export PYTHONWARNDEFAULTENCODING=1` in `.bashrc` in my mac and Linux machine. In the future, config file should be read with UTF-8 by default. | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:43 | admin | set | github: 87897 |
| 2021-04-13 23:33:39 | methane | set | messages: + msg391016 |
| 2021-04-13 14:11:51 | vstinner | set | messages: + msg390967 |
| 2021-04-13 10:11:14 | methane | set | messages: + msg390952 |
| 2021-04-13 09:48:02 | vstinner | set | nosy: + vstinner messages: + msg390944 |
| 2021-04-13 09:17:32 | methane | set | messages: + msg390941 |
| 2021-04-13 09:17:22 | methane | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021-04-08 06:20:02 | methane | set | keywords: + patch stage: patch review pull_requests: + pull_request24009 |
| 2021-04-08 06:13:24 | methane | set | messages: + msg390502 title: PEP 597: logging.basicConfig() uses locale encoding. -> PEP 597: logging.fileConfig() uses locale encoding. |
| 2021-04-05 07:46:45 | xtreak | set | nosy: + vinay.sajip |
| 2021-04-05 04:29:28 | methane | create | |