Dataclasses derived from empty frozen bases skip immutability checks. Repro snippet: ``` import dataclasses @dataclasses.dataclass(frozen=True) class Base: pass @dataclasses.dataclass class Derived(Base): a: int d = Derived(2) # OK ``` Usecase: sometimes developers define an empty frozen base dataclass with detailed docs and require other dataclasses to inherit from it as a code contract to avoid accidental in-place modifications. This bug makes this strategy ineffective. Affects all versions of Python that support dataclasses (including the backport for py3.6).

 New changeset 376ffc6ac491da74920aed1b8e35bc371cb766ac by Iurii Kemaev in branch 'master': bpo-43176: Fix processing of empty dataclasses (GH-24484) https://github.com/python/cpython/commit/376ffc6ac491da74920aed1b8e35bc371cb766ac 

 New changeset b132be8b43afa739b7eda271b82711d64a83da4f by Miss Islington (bot) in branch '3.8': bpo-43176: Fix processing of empty dataclasses (GH-24484) https://github.com/python/cpython/commit/b132be8b43afa739b7eda271b82711d64a83da4f 

Thanks!

 New changeset 8a34a0793bcb830350dac675524310bb285e5e4f by Miss Islington (bot) in branch '3.9': bpo-43176: Fix processing of empty dataclasses (GH-24484) (GH-25205) https://github.com/python/cpython/commit/8a34a0793bcb830350dac675524310bb285e5e4f 

 New changeset 1744c96ebc98b240f2564f75191097704b37244f by Eric V. Smith in branch 'master': Fix blurb for bpo-43176. (GH-25215) https://github.com/python/cpython/commit/1744c96ebc98b240f2564f75191097704b37244f 

 New changeset 76c4a9fb8ae370901b387a4edb609295bcc159e7 by Miss Islington (bot) in branch '3.8': [3.8] Fix blurb for bpo-43176. (GH-25215) (GH-25218) https://github.com/python/cpython/commit/76c4a9fb8ae370901b387a4edb609295bcc159e7 

 New changeset 2df971afd5f29574be3bb44f2d8569cc240b800d by Miss Islington (bot) in branch '3.9': Fix blurb for bpo-43176. (GH-25215) (GH-25217) https://github.com/python/cpython/commit/2df971afd5f29574be3bb44f2d8569cc240b800d 

Wether the original behaviour was intentional or not this change introduces backwards incompatibility (and in our case, breakage) between 3.8.10 and previous releases (I expect the same to be true for the equivalent 3.9 releases).

Can you provide a small snippet of code showing the kind of thing that broke?

@eric.smith Sure, here you go: dataclass_empty.py: ``` from dataclasses import dataclass @dataclass class A: pass @dataclass(frozen=True) class B(A): x: int print("42") ``` Running this on < 3.8.10: ``` $ ~/.pythonz/pythons/CPython-3.8.1/bin/python3.8 --version Python 3.8.1 $ ~/.pythonz/pythons/CPython-3.8.1/bin/python3.8 dataclass_empty.py 42 ``` And on 3.8.10: ``` $ /usr/local/opt/python@3.8/bin/python3 --version Python 3.8.10 $ /usr/local/opt/python@3.8/bin/python3 dataclass_empty.py Traceback (most recent call last): File "dataclass_empty.py", line 10, in <module> class B(A): File "/usr/local/Cellar/python@3.8/3.8.10/Frameworks/Python.framework/Versions/3.8/lib/python3.8/dataclasses.py", line 1011, in wrap return _process_class(cls, init, repr, eq, order, unsafe_hash, frozen) File "/usr/local/Cellar/python@3.8/3.8.10/Frameworks/Python.framework/Versions/3.8/lib/python3.8/dataclasses.py", line 896, in _process_class raise TypeError('cannot inherit frozen dataclass from a ' TypeError: cannot inherit frozen dataclass from a non-frozen one ```

Hmm. I think maybe the intent was that if you're frozen, treat all the fields as frozen, including ones you inherit, regardless if the base classes are frozen or not.