➜ 
This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-01-28 08:41 by BTaskaya, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 18477 | merged | serhiy.storchaka, 2020-02-12 10:03 | |
| PR 18491 | merged | miss-islington, 2020-02-12 20:38 | |
| Messages (7) | |||
|---|---|---|---|
| msg360844 - (view) | Author: Batuhan Taskaya (BTaskaya) *  | Date: 2020-01-28 08:41 | |
Python 3.9.0a2+ (heads/master:65ecc390c1, Jan 26 2020, 15:39:11) [GCC 9.2.1 20191008] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import ast >>> source = "(2+2).source" >>> ast.get_source_segment(source, ast.parse(source).body[0].value) '2+2).source' >>> source = "(2+2)[1]" >>> ast.get_source_segment(source, ast.parse(source).body[0].value) '2+2)[1]' I can prepare a patch to extend attribute's col_offset into parens if it is any if approved. | |||
| msg361842 - (view) | Author: Guido van Rossum (gvanrossum) * | Date: 2020-02-12 00:39 | |
This is also a 3.8 issue. We discovered this with pegen, and would love to see it fixed. | |||
| msg361845 - (view) | Author: Lysandros Nikolaou (lys.nikolaou) * | Date: 2020-02-12 00:56 | |
Are you going to work on a patch then, Batuhan? | |||
| msg361898 - (view) | Author: Batuhan Taskaya (BTaskaya) * | Date: 2020-02-12 14:54 | |
> Are you going to work on a patch then, Batuhan? Serhiy already submitted a PR, which looks great. | |||
| msg361913 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * | Date: 2020-02-12 20:37 | |
New changeset 6e619c48b8e804ece9521453fc8da0640a04d5b1 by Serhiy Storchaka in branch 'master': bpo-39474: Fix AST pos for expressions like (a)(b), (a)[b] and (a).b. (GH-18477) https://github.com/python/cpython/commit/6e619c48b8e804ece9521453fc8da0640a04d5b1 | |||
| msg361916 - (view) | Author: miss-islington (miss-islington) | Date: 2020-02-12 20:56 | |
New changeset 2076d4f97ef514bb4dc4ca768fbaa3f538ce7f1f by Miss Islington (bot) in branch '3.8': bpo-39474: Fix AST pos for expressions like (a)(b), (a)[b] and (a).b. (GH-18477) https://github.com/python/cpython/commit/2076d4f97ef514bb4dc4ca768fbaa3f538ce7f1f | |||
| msg361919 - (view) | Author: Guido van Rossum (gvanrossum) * | Date: 2020-02-12 21:54 | |
Thanks! | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:25 | admin | set | github: 83655 |
| 2020-02-12 21:54:32 | gvanrossum | set | status: open -> closed resolution: fixed messages: + msg361919 stage: patch review -> resolved |
| 2020-02-12 20:56:50 | miss-islington | set | nosy: + miss-islington messages: + msg361916 |
| 2020-02-12 20:38:18 | miss-islington | set | pull_requests: + pull_request17864 |
| 2020-02-12 20:37:53 | serhiy.storchaka | set | messages: + msg361913 |
| 2020-02-12 14:54:38 | BTaskaya | set | messages: + msg361898 |
| 2020-02-12 10:03:55 | serhiy.storchaka | set | keywords: + patch stage: patch review pull_requests: + pull_request17847 |
| 2020-02-12 08:11:22 | serhiy.storchaka | set | assignee: serhiy.storchaka |
| 2020-02-12 07:41:40 | serhiy.storchaka | set | nosy: + serhiy.storchaka |
| 2020-02-12 00:56:31 | lys.nikolaou | set | messages: + msg361845 |
| 2020-02-12 00:39:58 | gvanrossum | set | nosy: + gvanrossum messages: + msg361842 versions: + Python 3.8 |
| 2020-02-12 00:09:13 | lys.nikolaou | set | nosy: + lys.nikolaou |
| 2020-01-28 08:43:18 | BTaskaya | set | type: behavior title: col_offset for parenthesized expressions looks weird on attribute access -> col_offset for parenthesized expressions looks weird |
| 2020-01-28 08:41:48 | BTaskaya | create | |