The build only contains one change: commit f776eb0f0e046f2fa3a96540bb42d8cf970f6c55 bpo-30917: IDLE: Add config.IdleConf unittests (#2691) Patch by Louie Lu. http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/893/steps/test/logs/stdio ====================================================================== FAIL: test_get_font (idlelib.idle_test.test_config.IdleConfTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\idlelib\idle_test\test_config.py", line 605, in test_get_font (f['family'], 10 if f['size'] < 10 else f['size'], f['weight'])) AssertionError: Tuples differ: ('Courier New', 9, 'normal') != ('Courier New', 10, 'normal') First differing element 1: 9 10 - ('Courier New', 9, 'normal') ? ^ + ('Courier New', 10, 'normal') ? ^^

After checking source code, I found that is my fault on the test code. After the blocker PR 2754 been merged, I'll fix this issue.

I merged pr2754 in pr2753, the 3.6 backport of pr2691. To avoid breaking 3.6 buildbots more than one test, I will hold off merging pr2753 until a fix is available.

Louie, I am fixing this (I believe).

 New changeset 9f9192afbb4e45d09f0d3d717b457d157dc46398 by terryjreedy in branch 'master': bpo-30968: Fix test_get_font in IDLE's test_config. (#2769) https://github.com/python/cpython/commit/9f9192afbb4e45d09f0d3d717b457d157dc46398 

Yes, Terry's patch fixed this.

Fix worked: test_idle passed in build 897. http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/897/steps/test/logs/stdio I also included the fix of PR2769 in PR2753 (3.6 backport).

Terry: FYI your commit message starts with multiple spaces. I would also suggest you to format your name as you did previously: "Terry Jan Reedy". commit 9f9192afbb4e45d09f0d3d717b457d157dc46398 Author: terryjreedy <tjreedy@udel.edu> Date: Wed Jul 19 20:45:36 2017 -0400 bpo-30968: Fix test_get_font in IDLE's test_config. (#2769)

I don't understand 'format your name' as there is no formatting that I did. Github copies account name and email as they are. I have no idea about commit message. The PR title has no extra spaces. But github does not always copy correctly.

I will try to look at the first line more carefully before hitting the 2nd green button.

Terry J. Reedy: I don't understand 'format your name' as there is no formatting that I did. GitHub picks your commits unchanged. Git picks your name from your .gitconfig configuration file, global $HOME/.gitconfig or local <cpython>/.gitconfig. It's just that I saw "terryjreedy" in your last commit, instead of the usual "Terry Jan Reedy". It's up to you to pick whatever name you want, I was just surprised to see the name formatted differently. > I have no idea about commit message. The PR title has no extra spaces. But github does not always copy correctly. It doesn't matter at all. It's just that I was surprised ;-)

For the problem about the small name in git log Author, if you want to changed it, it will need to setup at https://github.com/settings/profile and update the first column "Name". I think this is because we merged on GitHub, and GitHub ignores the git author but use GitHub account's name (if this didn't setup, it will fallback to GitHub account). I have some small name with "mlouielu" when I changed to this new account.

Thanks. I will see what that does.