On a platform with a broken poll() function (as detected during configure), Modules/selectmodule.c fails to compile. The error occurs at two points: ./Modules/selectmodule.c:2100: `select_poll' undeclared here (not in a function) ./Modules/selectmodule.c:2100: initializer element is not constant ./Modules/selectmodule.c:2100: (near initialization for `select_methods[1].ml_meth') ./Modules/selectmodule.c:2100: `poll_doc' undeclared here (not in a function) ./Modules/selectmodule.c:2100: initializer element is not constant ./Modules/selectmodule.c:2100: (near initialization for `select_methods[1].ml_doc') ./Modules/selectmodule.c: In function `PyInit_select': ./Modules/selectmodule.c:2159: `poll_Type' undeclared (first use in this function) ./Modules/selectmodule.c:2159: (Each undeclared identifier is reported only once ./Modules/selectmodule.c:2159: for each function it appears in.) The problem is occurring because both "select_poll" and "poll_Type" are undeclared if HAVE_BROKEN_POLL is declared. The fix would be on two lines: selectmodule.c:2099 #ifdef(HAVE_POLL) should be: #if defined(HAVE_POLL) && !defined(HAVE_BROKEN_POLL) selectmodule.c:2149 #if defined(HAVE_POLL) should be: #if defined(HAVE_POLL) && !defined(HAVE_BROKEN_POLL) Making these two minor changes allows selectmodule.c to compile fine in the case where the platform has a "broken" poll(). This bug was found on m68k-atari-mint compiling using gcc 2.95.3

Could you provide the patch? It's trivial, but at least we'll make sure the patch fixes the problem on your platform.

I've attached the patch, and I probably should have done so in the first place. It applies to Python 3.3.0. The resulting code compiles fine on m68k-atari-mint. It shouldn't affect any of the major platforms.

New changeset 1d33c79d2f6b by Charles-François Natali in branch '2.7': Issue #16953: Fix socket module compilation on platforms with HAVE_BROKEN_POLL. http://hg.python.org/cpython/rev/1d33c79d2f6b New changeset 101e821e5e70 by Charles-François Natali in branch '3.2': Issue #16953: Fix socket module compilation on platforms with HAVE_BROKEN_POLL. http://hg.python.org/cpython/rev/101e821e5e70 New changeset f04c97bbb241 by Charles-François Natali in branch '3.3': Issue #16953: Fix socket module compilation on platforms with HAVE_BROKEN_POLL. http://hg.python.org/cpython/rev/f04c97bbb241 New changeset 79912bb1a884 by Charles-François Natali in branch 'default': Issue #16953: Fix socket module compilation on platforms with HAVE_BROKEN_POLL. http://hg.python.org/cpython/rev/79912bb1a884

Committed, thanks for the patch!