Skip to content

Conversation

@laxman-goud
Copy link
Contributor

πŸ“ Issue Reference

Fixes: #3

βœ… What Changed

Added validation to prevent adding empty todo tasks.

Now, clicking the Add button with an empty input gives an alert.

πŸ“Έ Screenshots

Before:
Empty todo item gets added when clicking Add.

After (Fix):
image

πŸ” Testing Done

Tried adding empty tasks β†’ Not added βœ…

Added valid tasks β†’ Works as expected βœ…

Copy link
Owner

@zpratikpathak zpratikpathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current alert messgae: "Please enter a task before adding!"

Alert message seems to lack clarity

The message should be like "Task field is empty"

@laxman-goud
Copy link
Contributor Author

Thanks for the suggestion πŸ™Œ
Instead of using an alert(), I updated the implementation to display the message inside a para element above the input.

New message shown:
Task field is empty βœ…

Here’s the updated screenshot after the fix:

image
@zpratikpathak zpratikpathak merged commit fa5abfb into zpratikpathak:master Aug 18, 2025
1 check passed
@zpratikpathak
Copy link
Owner

Tested OK βœ…

UI Status: Good 🟒
UX Status: Good 🟒
Code Quality: Good 🟒

Additional Notes:
Thanks for the PR, I really like this UI.

APPROVED! 🌿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants