samples: ocpp: add native_sim config #99455
Conversation
walidbadar force-pushed the ocpp_sample branch from e87d046 to a31c2de Compare walidbadar changed the title walidbadar force-pushed the ocpp_sample branch from a31c2de to aa87e93 Compare 
| CONFIG_NET_DHCPV4=n | ||
| CONFIG_NET_CONFIG_SETTINGS=y | ||
| CONFIG_NET_CONFIG_NEED_IPV4=y | ||
| CONFIG_NET_CONFIG_MY_IPV4_ADDR="192.0.2.1" |
There was a problem hiding this comment.
no hard coded value please
There was a problem hiding this comment.
This IP address space is reserved for documentation and we are using it in all the network samples, so these are OK to be used here.
samples/net/ocpp/src/main.c Outdated
| struct timespec tv; | ||
| int ret; | ||
| | ||
| if (strlen(CONFIG_NET_SAMPLE_SNTP_SERVER) < 1) { |
There was a problem hiding this comment.
run time error will be get down in sntp_init.
There was a problem hiding this comment.
No, ocpp_get_time_from_sntp would return -EINVAL before getting to sntp_init.
There was a problem hiding this comment.
the change is not needed, if CONFIG_NET_SAMPLE_SNTP_SERVER not configured which will endup with run time error in sntp_init.
walidbadar force-pushed the ocpp_sample branch from aa87e93 to 2729817 Compare samples/net/ocpp/src/main.c Outdated
| struct timespec tv; | ||
| int ret; | ||
| | ||
| if (strlen(CONFIG_NET_SAMPLE_SNTP_SERVER) < 1) { |
There was a problem hiding this comment.
the change is not needed, if CONFIG_NET_SAMPLE_SNTP_SERVER not configured which will endup with run time error in sntp_init.
samples/net/ocpp/src/main.c Outdated
| | ||
| ocpp_get_time_from_sntp(); | ||
| ret = ocpp_get_time_from_sntp(); | ||
| if (ret < 0) { |
There was a problem hiding this comment.
should not return even sntp unreachable.. e.g system time is maintained in RTC or some other source.
samples/net/ocpp/src/main.c Outdated
| | ||
| wait_for_network(); | ||
| | ||
| if (strlen(CONFIG_NET_SAMPLE_OCPP_SERVER) < 1) { |
There was a problem hiding this comment.
ditto, ocpp_getaddrinfo endup runtime error.
There was a problem hiding this comment.
the reason for this logic was to warn the user that ocpp server address was not configured, there could also be other reason why getaddrinfo might get fail.
There was a problem hiding this comment.
We could avoid the call to strlen() here
if (CONFIG_NET_SAMPLE_OCPP_SERVER[0] == '\0') { | CONFIG_NET_DHCPV4=n | ||
| CONFIG_NET_CONFIG_SETTINGS=y | ||
| CONFIG_NET_CONFIG_NEED_IPV4=y | ||
| CONFIG_NET_CONFIG_MY_IPV4_ADDR="192.0.2.1" |
Disable DHCPv4 and use static network configuration for native_sim board Signed-off-by: Muhammad Waleed Badar <walid.badar@gmail.com>
walidbadar force-pushed the ocpp_sample branch from 2729817 to c5537e0 Compare walidbadar changed the title 
|
4 participants
Uh oh!
There was an error while loading. Please reload this page.