- Notifications
You must be signed in to change notification settings - Fork 8.2k
treewide: adjust CMakeLists.txt files indentation #99440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
josuah wants to merge 143 commits into zephyrproject-rtos:main Choose a base branch from josuah:pr_cmakelists_txt_indentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
treewide: adjust CMakeLists.txt files indentation #99440
josuah wants to merge 143 commits into zephyrproject-rtos:main from josuah:pr_cmakelists_txt_indentation
+3,595 −3,727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Apply the CMake style guidelines to all CMakeList.txt files in boards/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to all CMakeList.txt files in arch/. Signed-off-by: Josuah Demangeon <me@josuah.net>
ec4d920 to 58840e2 Compare Contributor Author
| Since this touches to every CMakeLists.txt, a second batch of commit also adds If this is too much for a single PR, then I can easily split it. |
Apply the CMake style guidelines to all CMakeList.txt files in cmake/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/adc/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/display/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/ethernet/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/flash/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/gnss/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/i3c/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/misc/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/mm/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/modem/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/sensor/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in drivers/usb/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/bluetooth/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/llext/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/lorawan/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/mgmt/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/modbus/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/net/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/rtio/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/sensing/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/testsuite/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Apply the CMake style guidelines to CMakeList.txt files in subsys/usb/. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
Use the # zephyr-keep-sorted-start/stop comment to have CI check the alphabetical order of includes, to help reducing the chance of conflicts while contributing drivers. Signed-off-by: Josuah Demangeon <me@josuah.net>
58840e2 to 5351b5e Compare |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.



The rules are interpolated from what there is on the docs:
https://docs.zephyrproject.org/latest/contribute/style/cmake.html#commands-and-syntax
And what seemed to be common on in-tree, in particular for
if()andmessages():at the end of the last continuation line
as an UPPERCASE label) the closing parenthesis is on its own line,
with same indentation level as the first line.
of "... " strings, with an empty space at the end if separation between
words is needed.
If anything seems wrong choice, let me know of what to apply and I'd be glad to apply it again tree-wide.
If the scope of modifications is wrong (i.e. should do all
CMakeLists.txtand.cmake), then let me know and I would change the scope for this PR.I am keeping it as a draft for now to avoid triggering the bot.