lorawan: Move invalid requirement of 2KiB system workqueue #98711
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The LoRaWAN subsystem does not require 2KiB of system workqueue, testing on nrf54l15 flpr (RISCV) CPU (with custom cryptography code) shows it uses about 700 bytes of the system workqueue, therefore it is assumed that the real requirement for 2KiB is the software cryptography features, not the LoRaWAN stack itself, and the cryptography parts of LoRaWAN can be replaced with alternatives that do not need this high of a memory requirement, so the requirement has been moved to the specific Kconfig for software cryptography instead Signed-off-by: Jamie McCrae <spam@helper3000.net>
|
martinjaeger approved these changes Nov 2, 2025
JordanYates approved these changes Nov 2, 2025
mniestroj approved these changes Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The LoRaWAN subsystem does not require 2KiB of system workqueue, testing on nrf54l15 flpr (RISCV) CPU (with custom cryptography code) shows it uses about 700 bytes of the system workqueue, therefore it is assumed that the real requirement for 2KiB is the software cryptography features, not the LoRaWAN stack itself, and the cryptography parts of LoRaWAN can be replaced with alternatives that do not need this high of a memory requirement, so the requirement has been moved to the specific Kconfig for software cryptography instead
To clarify, the whole application running on this core is using at most ~700 bytes of the system workqueue, this includes LoRaWAN and other parts of the code, including a duplex cross-core communication system for running commands, so it is likely that the LoRaWAN subsystem needs less than 700 bytes but I have not made a direct measurement as to how much