dts: arm: xilinx: fix zynqmp RPU IPI mailbox base addresses #95967
Conversation
zephyrbot requested review from henrikbrixandersen, ibirnbaum and michalsimek 
WangHanChi force-pushed the fix/zynqmp-rpu branch from 0002bae to 5157a3e Compare 
The RPU0 mailbox node in `zynqmp_rpu.dtsi` used incorrect IPI message buffer base addresses. According to UG1085 (Table 13-3)[1], RPU0 should use the channel 1 message buffer region at `0xFF99_0000` for local request/response and `0xFF99_0400` for remote request/ response. The previous values pointed to the APU channel 0 buffer (`0xFF99_0200`), which does not match the hardware mapping. The same is true for rpu1. Fix the DTS by updating the RPU0, RPU1 mailbox nodes to use the correct base addresses from the documentation. [1] https://docs.amd.com/v/u/en-US/ug1085-zynq-ultrascale-trm Signed-off-by: Hank Wang <wanghanchi2000@gmail.com>
WangHanChi force-pushed the fix/zynqmp-rpu branch from 5157a3e to 2f01ecd Compare 
|
| <0xff990040 0x20>, | ||
| <0xff990060 0x20>; | ||
| reg = <0xff990000 0x20>, | ||
| <0xff990020 0x20>, |
There was a problem hiding this comment.
reg = <0xff990080 0x20>, <0xff9900a0 0x20>, <0xff990400 0x20>, <0xff990420 0x20>;
This is because the IPI buffer base looks something like this:
IPI1 - 0xFF990000
IPI2 - 0xFF990200
IPI0 - 0xFF990400
The local and remote regions are also calculated in this order
| reg = <0xff990040 0x20>, | ||
| <0xff990060 0x20>, | ||
| <0xff990200 0x20>, | ||
| <0xff990220 0x20>; |
| reg = <0xff990200 0x20>, | ||
| <0xff990220 0x20>, | ||
| <0xff990440 0x20>, | ||
| <0xff990460 0x20>; |
There was a problem hiding this comment.
reg = <0xff990280 0x20>, <0xff9902a0 0x20>, <0xff990440 0x20>, <0xff990460 0x20>;
| <0xff990440 0x20>, | ||
| reg = <0xff990240 0x20>, | ||
| <0xff990260 0x20>, | ||
| <0xff990280 0x20>; |
There was a problem hiding this comment.
reg = <0xff990200 0x20>, <0xff990220 0x20>, <0xff990040 0x20>, <0xff990060 0x20>;
| This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
3 participants
The RPU0 mailbox node in
zynqmp_rpu.dtsiused incorrect IPI message buffer base addresses. According to UG1085 (Table 13-3)[1], RPU0 should use the channel 1 message buffer region at0xFF99_0000for local request/response and0xFF99_0400for remote request/ response. The previous values pointed to the APU channel 0 buffer (0xFF99_0200), which does not match the hardware mapping. The same is true for rpu1.Fix the DTS by updating the RPU0, RPU1 mailbox nodes to use the correct base addresses from the documentation.
[1] https://docs.amd.com/v/u/en-US/ug1085-zynq-ultrascale-trm