Skip to content

drivers: spi: mchp_mss: Make the driver a bit more universal #93008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2025
Merged

drivers: spi: mchp_mss: Make the driver a bit more universal #93008

merged 3 commits into from
Oct 2, 2025
+11 −18

Conversation

@c-mauderer
Copy link
Contributor

The current driver has a workarround that seem to be targeted to SPI flashes. It completely throws away the first Rx buffer without any warning or error. This patch set:

  • Removes that behavior and processes the first SPI buffer normally.
  • Makes sure that NULL-Buffers are handled correctly.
  • Avoids sending extra bytes if the transmit is already done while the receive is not yet finished.
@github-actions
Copy link

Hello @c-mauderer, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊
@github-actions github-actions bot added area: SPI SPI bus platform: Microchip MEC Microchip MEC Platform labels Jul 11, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@sebhub
Copy link
Contributor

sebhub commented Jul 22, 2025

@con-pax Please have a look at this.
@con-pax
Copy link
Contributor

con-pax commented Jul 22, 2025

@con-pax Please have a look at this.

Hey @sebhub, will do. I see this PR is opened 2 weeks, unfortunately I wasn't notified. I will test this out in the coming days
@con-pax
Copy link
Contributor

con-pax commented Aug 8, 2025

Hi @sebhub @c-mauderer, I haven't forgotten about this PR. team mates have been on vacation, hence not getting to fully test it. should be tested next week
con-pax
con-pax approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@con-pax con-pax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@tomi-font
Copy link
Contributor

@jvasanth1 please review
@con-pax
Copy link
Contributor

con-pax commented Sep 15, 2025

Hi @jvasanth1 could we please get a review on this?
@tomi-font
Copy link
Contributor

Don't know why some checks are pending, @c-mauderer can you rebase your PR?
@c-mauderer
drivers: spi: mchp_mss: Make more universal
ceb11bf 
The driver has ignored the first RX buffer. Most likely it has been modeled for accesses to a SPI flash or similar where the first read data is not relevant. This commit makes sure that the driver can work as a universal SPI master instead. Signed-off-by: Christian Mauderer <christian.mauderer@embedded-brains.de>
@c-mauderer
drivers: spi: mchp_mss: Handle NULL buffers better
6ae4ce2 
At the moment, if you would pass a NULL buffer to the driver, the rx and tx counts of that buffer would not advance. This patch fixes that. Signed-off-by: Christian Mauderer <christian.mauderer@embedded-brains.de>
@c-mauderer
drivers: spi: mchp_mss: Avoid sending extra bytes
3170d37 
The driver did send some extra 0 bytes when the receive hasn't been finished yet. This patch makes sure to avoid that. Signed-off-by: Christian Mauderer <christian.mauderer@embedded-brains.de>
@c-mauderer
Copy link
Contributor Author

Don't know why some checks are pending, @c-mauderer can you rebase your PR?

I rebased the changes.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@kartben kartben merged commit f042a1c into zephyrproject-rtos:main Oct 2, 2025
26 checks passed
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Hi @c-mauderer!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: SPI SPI bus platform: Microchip MEC Microchip MEC Platform

6 participants

@c-mauderer @sebhub @con-pax @tomi-font @jvasanth1 @kartben