Rework the I2C driver for the Microchip Polarfire SoC #92208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added area: I2C platform: Microchip MEC 
| @con-pax Would you mind reviewing this MR? |
github-actions bot requested review from VenkatKotakonda, albertofloyd, jvasanth1 and teburd 
sebhub force-pushed the i2c-mchp-mss-rework branch from 9852ad9 to d040c43 Compare 
sebhub force-pushed the i2c-mchp-mss-rework branch from d040c43 to 66072fb Compare 
teburd requested changes Jun 26, 2025
There was a problem hiding this comment.
Looks pretty good to me, I've not looked in great depth at the changes in the flow using an ISR state machine as I'm not familiar with this hardware, but looked for common things across i2c drivers.
A small nit using k_sem_reset like other drivers rather than a take with no wait.
sebhub force-pushed the i2c-mchp-mss-rework branch from 66072fb to 6dfc2ad Compare teburd previously approved these changes Jun 26, 2025
Clear the clock bits before setting new ones. Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
Use a mutex to protect the I2C bus from concurrent access. Replace busy waiting with a binary semaphore. Process the messages in the interrupt handler state machine to generate a single transaction. In the interrupt handler, process the states until nothing more is to do. This prevents superfluous interrupt entry/exit pairs. Return error conditions to the caller. Check the messages for consistency and return an error for unsupported message lists. Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
sebhub force-pushed the i2c-mchp-mss-rework branch from 6dfc2ad to f320651 Compare 
|
con-pax approved these changes Jun 30, 2025
teburd approved these changes Jun 30, 2025
nandojve approved these changes Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use a mutex to protect the I2C bus from concurrent access. Replace busy waiting with a binary semaphore. Process the messages in the interrupt handler state machine to generate a single transaction. In the interrupt handler, process the states until nothing more is to do. This prevents superfluous interrupt entry/exit pairs. Return error conditions to the caller. Check the messages for consistency and return an error for unsupported message lists.
The driver was tested using an Icicle development board connected to another board with an I2C target.