fb: cfb: Use signed-integer for API that specifies coordinations #85443
+100 −47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
soburi force-pushed the cfb_signed_coord branch from 1fd4684 to 92922fb Compare 
| This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Since there is no way to run this test with `harness: display` configuration, we will change it so that execution can be controlled by specifying a fixture. This method has already been proven with `tests/drivers/display/display_read_write`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Make it allow to run the tests on `native_sim/native/64` platform. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
There are several issues to be fixed. - cfb.c: draw_char_htmono It appears that some parts of the process have been ported from `draw_char_vtmono`, but the loop is different, causing the calculations to be incorrect. - cfb.c: cfb_framebuffer_finalize The inversion condition is "XOR-ish". The original that before de9dd98 is correct. - cfb:c cfb_invert_area - utils.c display_pixel The implementation for HTILED was not. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Change the arguments of `cfb_invert_area`, `cfb_print`, and `cfb_draw_(point|line|rect)`, which used unsigned integers to specify coordinates to signed integers. This is because coordinate calculations are usually based on real numbers, so it is difficult to use unless negative numbers are accepted. We clip drawings outside the drawable area on the implementation side. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi force-pushed the cfb_signed_coord branch from 92922fb to 8f5a95d Compare 
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Change the arguments of
cfb_invert_area,cfb_print, andcfb_draw_(point|line|rect), which used unsigned integers to specify coordinates to signed integers.This is because coordinate calculations are usually based on real numbers, so it is difficult to use unless negative numbers are accepted.
We clip drawings outside the drawable area on the implementation side.