Skip to content

Conversation

@Snape3058
Copy link
Contributor

Struct girq_regs has an array field of length 1 at its end. Since this field is never used in the code base, we can replace it with a non-array field of its original element type to remove the flexible-array-like behaviors and avoid using a flexible array file in the middle of a struct or defining an array of flexible array struct type.

Fixes #84251

@zephyrbot zephyrbot added size: XS A PR changing only a single line of code platform: Microchip MEC Microchip MEC Platform labels Jan 21, 2025
@github-actions
Copy link

Hello @Snape3058, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@Snape3058
Copy link
Contributor Author

I have tried to do some local tests on this change. But there will still be some places that I cannot cover. Wait for the CI results and apologize in advance in case it fails.

@Snape3058
Copy link
Contributor Author

It seems that all tests pass for this change. Please help me update the commit message if it looks good to merge, or provide me with other suggestions for further updates. Thanks.

@albertofloyd
Copy link
Contributor

It seems that all tests pass for this change. Please help me update the commit message if it looks good to merge, or provide me with other suggestions for further updates. Thanks.

Do change commit message as indicated in CI error.
e.g.
soc: mec172x: ecia: Adjust girq_regs to avoid flexible-array-like behaviors

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Apr 21, 2025
…aviors Struct girq_regs has an array field of length 1 at its end. Since this field is never used in the code base, we can replace it with a non-array field of its original element type to remove the flexible-array-like behaviors and avoid using a flexible array file in the middle of a struct or defining an array of flexible array struct type. Fixes zephyrproject-rtos#84251 Signed-off-by: Ella MA <xutong.ma@inria.fr>
@Snape3058
Copy link
Contributor Author

Hi, how is this patch going? Do I need to take any action with it? thx

@Snape3058
Copy link
Contributor Author

Thank you. Can we merge now?

@nashif nashif merged commit 3f58d49 into zephyrproject-rtos:main Jun 18, 2025
24 of 25 checks passed
@github-actions
Copy link

Hi @Snape3058!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Microchip MEC Microchip MEC Platform size: XS A PR changing only a single line of code

6 participants