Skip to content

A new non volatile storage system #77930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2024
Merged

A new non volatile storage system #77930

merged 4 commits into from
Oct 24, 2024

Conversation

@rghaddab
Copy link
Contributor

@rghaddab rghaddab commented Sep 3, 2024 •
edited
Loading

Implements RFC #77929

This is the a new storage system that is designed especially to work on non erasable devices but supports as well erasable devices.

It is intended that some features described in the RFC are not implemented yet to make it easier to review for contributors that are familiar with NVS filesystem.

Already included feature :

  • Simple Key-Value Storage (i.e. no file/folder abstractions)
  • 32-bit IDs
  • Metadata entries can also store small (1 to 8 bytes) data entries
  • Support for no-erase-required flash drivers (i.e. RRAM, MRAM, etc)

Features in progress:

  • No limits in value length
  • Support for entries in multiple formats
  • CRC-24 for entries that require it (part of multiple format entries)
  • Efficiency for Settings subsystem
  • Efficiency for Secure Storage subsystem
@nordicjm nordicjm linked an issue Sep 4, 2024 that may be closed by this pull request
New non-volatile storage system #77929
Closed
@butok
Copy link
Contributor

butok commented Sep 4, 2024

There is no a ZMS User Documentation.
@rghaddab
Copy link
Contributor Author

rghaddab commented Sep 4, 2024

There is no a ZMS User Documentation.

Yes there is no Documentation yet as this could change a lot from its initial proposal.
The PR is still in Draft mode and some work is still in Progress.
I will add some information about what is already included in this PR and what is coming next
@rghaddab rghaddab force-pushed the rghaddab/zms branch 9 times, most recently from 363962a to 013a303 Compare September 9, 2024 07:59
@rghaddab rghaddab marked this pull request as ready for review September 9, 2024 13:17
@de-nordic de-nordic requested a review from tomi-font September 9, 2024 14:39
@rghaddab rghaddab force-pushed the rghaddab/zms branch 2 times, most recently from 716277d to acdc1b8 Compare September 10, 2024 18:40
RICCIARDI-Adrien
RICCIARDI-Adrien reviewed Sep 16, 2024
View reviewed changes
RICCIARDI-Adrien
RICCIARDI-Adrien reviewed Sep 16, 2024
View reviewed changes
RICCIARDI-Adrien
RICCIARDI-Adrien reviewed Sep 16, 2024
View reviewed changes
RICCIARDI-Adrien
RICCIARDI-Adrien reviewed Sep 16, 2024
View reviewed changes
RICCIARDI-Adrien
RICCIARDI-Adrien reviewed Sep 16, 2024
View reviewed changes
RICCIARDI-Adrien
RICCIARDI-Adrien reviewed Sep 16, 2024
View reviewed changes
RICCIARDI-Adrien
RICCIARDI-Adrien reviewed Sep 16, 2024
View reviewed changes
frkv
frkv reviewed Sep 16, 2024
View reviewed changes
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 25, 2024
@rghaddab
[nrf fromlist] fs: zms: multiple fixes from previous PR review
396cdfb 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Upstream PR: zephyrproject-rtos/zephyr#80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit 494e0cff17dbccbd8093911f063fdd47e26b35eb)
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 25, 2024
@rghaddab
[nrf fromlist] fs: zms: multiple fixes from previous PR review
c4ea84d 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Upstream PR: zephyrproject-rtos/zephyr#80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit 494e0cff17dbccbd8093911f063fdd47e26b35eb)
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Oct 28, 2024
@rghaddab
fs: zms: multiple fixes from previous PR review
a40ba48 
This resolves some addressed comments in this PR zephyrproject-rtos#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 28, 2024
@rghaddab
[nrf fromlist] fs: zms: multiple fixes from previous PR review
586ac63 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Upstream PR #: 80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2)
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 28, 2024
@rghaddab
[nrf fromlist] fs: zms: multiple fixes from previous PR review
afaa5e5 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Upstream PR #: 80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2)
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 28, 2024
@rghaddab
[nrf fromlist] fs: zms: multiple fixes from previous PR review
9b837ce 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Upstream PR #: 80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2)
@rghaddab rghaddab mentioned this pull request Oct 28, 2024
Closed
rlubos pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Oct 28, 2024
@rghaddab @rlubos
[nrf fromlist] fs: zms: multiple fixes from previous PR review
53f2704 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Upstream PR #: 80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2)
NordicBuilder pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Oct 28, 2024
@rghaddab @github-actions
[nrf fromlist] fs: zms: multiple fixes from previous PR review
e323324 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Upstream PR #: 80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2) (cherry picked from commit 53f2704)
rlubos pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Oct 29, 2024
@rghaddab @rlubos
[nrf fromlist] fs: zms: multiple fixes from previous PR review
b8ec345 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Upstream PR #: 80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2) (cherry picked from commit 53f2704)
tomi-font
tomi-font reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'm done! (Literally and also figuratively.)
mmahadevan108 pushed a commit that referenced this pull request Oct 29, 2024
@rghaddab @mmahadevan108
fs: zms: multiple fixes from previous PR review
46e1635 
This resolves some addressed comments in this PR #77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
@rghaddab rghaddab mentioned this pull request Oct 30, 2024
Merged
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Oct 31, 2024
@rghaddab
[nrf fromtree] fs: zms: multiple fixes from previous PR review
f09ddfd 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit 46e1635)
coreboot-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Oct 31, 2024
@rghaddab
fs: zms: multiple fixes from previous PR review
39fa0ed 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. (cherry picked from commit 46e1635) Original-Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> GitOrigin-RevId: 46e1635 Cr-Build-Id: 8732568629207591185 Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8732568629207591185 Copybot-Job-Name: zephyr-main-copybot-downstream Change-Id: I8c7943abb79cb570bce4493db9eb5fd36616c29f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5982755 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Nov 6, 2024
@rghaddab
fs: zms: multiple style fixes from previous PR review
7262258 
This resolves some addressed comments in this PR zephyrproject-rtos#77930 as well as this PR zephyrproject-rtos#80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
jukkar pushed a commit to jukkar/sdk-zephyr that referenced this pull request Dec 5, 2024
@rghaddab @jukkar
[nrf fromlist] fs: zms: multiple fixes from previous PR review
f73e477 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Upstream PR #: 80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit a40ba482bd65ba75540454468cbce4cfcbcc4bf2) (cherry picked from commit 53f2704)
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Feb 13, 2025
@rghaddab
fs: zms: multiple style fixes from previous PR review
4eb9876 
This resolves some addressed comments in this PR zephyrproject-rtos#77930 as well as this PR zephyrproject-rtos#80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Feb 21, 2025
@rghaddab
fs: zms: multiple fixes from previous PR review
91578bf 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit 46e1635)
rghaddab added a commit to rghaddab/sdk-zephyr that referenced this pull request Feb 21, 2025
@rghaddab
[nrf fromtree] fs: zms: multiple fixes from previous PR review
7e36304 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit 46e1635)
fabiobaltieri pushed a commit that referenced this pull request Feb 21, 2025
@rghaddab @fabiobaltieri
fs: zms: multiple style fixes from previous PR review
5f7cda5 
This resolves some addressed comments in this PR #77930 as well as this PR #80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
carlescufi pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Feb 26, 2025
@rghaddab @carlescufi
[nrf fromtree] fs: zms: multiple fixes from previous PR review
ff2d7b9 
This resolves some addressed comments in this PR zephyrproject-rtos/zephyr#77930 It adds as well a section in the documentation about some recommendations to increase ZMS performance. Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit 46e1635)
rghaddab added a commit to rghaddab/zephyr that referenced this pull request Feb 27, 2025
@rghaddab
[nrf fromtree] fs: zms: multiple style fixes from previous PR review
8bb9581 
This resolves some addressed comments in this PR zephyrproject-rtos#77930 as well as this PR zephyrproject-rtos#80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit 5f7cda5)
RuibinChang pushed a commit to RuibinChang/zephyr that referenced this pull request Mar 4, 2025
fs: zms: multiple style fixes from previous PR review
b5ef0b5 
This resolves some addressed comments in this PR zephyrproject-rtos#77930 as well as this PR zephyrproject-rtos#80407 (cherry picked from commit 5f7cda5) Original-Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> GitOrigin-RevId: 5f7cda5 Cr-Build-Id: 8722327397323422481 Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8722327397323422481 Copybot-Job-Name: zephyr-main-copybot-downstream Change-Id: Iac872e14f83b4dfe3e83f3a3b88fe85cc7dc9171 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/6288236 Commit-Queue: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> Bot-Commit: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
ssekar15 pushed a commit to linumiz/zephyr that referenced this pull request Mar 6, 2025
@rghaddab @ssekar15
fs: zms: multiple style fixes from previous PR review
a0bcb3e 
This resolves some addressed comments in this PR zephyrproject-rtos#77930 as well as this PR zephyrproject-rtos#80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
ssekar15 pushed a commit to linumiz/zephyr that referenced this pull request Mar 7, 2025
@rghaddab @ssekar15
fs: zms: multiple style fixes from previous PR review
ba80c86 
This resolves some addressed comments in this PR zephyrproject-rtos#77930 as well as this PR zephyrproject-rtos#80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>
RICCIARDI-Adrien pushed a commit to RICCIARDI-Adrien/zephyr that referenced this pull request Jun 6, 2025
@rghaddab @bjarki-andreasen
[nrf fromtree] fs: zms: multiple style fixes from previous PR review
d9f9a96 
This resolves some addressed comments in this PR zephyrproject-rtos#77930 as well as this PR zephyrproject-rtos#80407 Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com> (cherry picked from commit 5f7cda5) (cherry picked from commit 6981397) (cherry picked from commit bd07ff6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: File System area: Samples Samples area: Storage Storage subsystem