Resolve connection with Instance::ensure

[AlikDex]

Q	A
Is bugfix?	no
New feature?	no
Breaks BC?	no
Tests pass?	yes
Fixed issues	#195

[samdark]

Please add a line to changelog describing the change

[rob006]

This may break BC and it is inconsistent with yii\db\ActiverRecord which always point to Yii::$app->db (https://github.com/yiisoft/yii2/blob/b79fe7d106b8f901d3f3f2fd01eae811ce2c34ec/framework/db/ActiveRecord.php#L135). You should override this method in your model if you want to use different approach.

[rob006]

We could replace entire initialization of $redis property by Instance::ensure().

yii2-redis/src/Session.php

Lines 83 to 93 in 3fe93b9

	if (is_string($this->redis)) {
	$this->redis = Instance::ensure($this->redis, Connection::className());
	} elseif (is_array($this->redis)) {
	if (!isset($this->redis['class'])) {
	$this->redis['class'] = Connection::className();
	}
	$this->redis = Yii::createObject($this->redis);
	}
	if (!$this->redis instanceof Connection) {
	throw new InvalidConfigException("Session::redis must be either a Redis connection instance or the application component ID of a Redis connection.");
	}

[samdark]

@AlikDex, @rob006 is there a way to fix it in a backwards compatible manner?

[rob006]

IMO changes in ActiveRecord are unnecessary. This how it works for other AR implementations - if you want different component/approach to be used for connection, you should override getDb() in your model. Changing this will only create inconsistency.

[samdark]

Yes. Agree.

[rob006]

@samdark It is still worth to simplify Session::init() by using Instance::ensure() for initialization of redis property. It will be more consistent, simplify implementation and make configuration more flexible.

[samdark]

@rob006 since you're on it, how about a pull request?