modify message maxcount bug #428
Conversation
| this.setState(previousState => { | ||
| return { | ||
| notices: previousState.notices.filter(notice => notice.key !== key), | ||
| notices: previousState.notices.filter(notice => notice.key !== key && notice.updateKey !== key), |
There was a problem hiding this comment.
You are right!
But maybe we should change
const close = createChainedFunction(remove.bind(this, key), onClose);
to
const close = createChainedFunction(remove.bind(this, notice.key), onClose);
is more better solution.
Codecov Report
@@ Coverage Diff @@ ## master #428 +/- ## ======================================= Coverage 87.62% 87.62% ======================================= Files 145 145 Lines 4744 4744 Branches 1404 1404 ======================================= Hits 4157 4157 Misses 543 543 Partials 44 44Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@ ## master #428 +/- ## ======================================= Coverage 87.62% 87.62% ======================================= Files 145 145 Lines 4744 4744 Branches 1404 1404 ======================================= Hits 4157 4157 Misses 543 543 Partials 44 44Continue to review full report at Codecov.
|
| This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
No description provided.