Make parentContext optional in ModalOptions type #1784
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a ...
What's the background?
In b8a0195 the
parentContextfield was added toModalOptions.Since upgrading to 1.4.11 (which is the first release containing this change), I receive build errors in my TypeScript project on code like the following:
It produces a build error because the
parentContextproperty is now required:I don't think it was intentional that this property be required (if it was, that's a breaking change and should have been a major semver bump). So the type definition should make it optional.