fix elasticsearch/user: allow ensure=absent without password #1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
milad-zanganeh force-pushed the fix/delete-user branch 3 times, most recently from c6fa4e2 to e07ddf2 Compare 
Member
| @milad-zanganeh thanks for the PR. Would it be possible that you add a test for this change? |
milad-zanganeh force-pushed the fix/delete-user branch from e07ddf2 to be062fd Compare 
TheMeier approved these changes Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Removing a user previously failed because the elasticsearch::user define always required and passed a password, even when ensure => absent.
This PR fixes the issue by making the password parameter optional and improving the logic for handling user removal.
Related Issue
Fixes #1264
Changes: