Skip to content
This repository was archived by the owner on Sep 22, 2021. It is now read-only.

Conversation

@Himsahu
Copy link

@Himsahu Himsahu commented Oct 12, 2020

IMPORTANT: Please do not create a Pull Request without an issue.

All Submissions:

  • I have read the CONTRIBUTING document.
  • My code is written in Python3 and is ending with .py
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have checked that my submission does pass the test on LeetCode.com
  • Does your filename follow the naming Conventions?
  • Have you linked your PR to an Issue?

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@riwim
Copy link
Contributor

riwim commented Oct 12, 2020

Hi Himsahu again.
Before you make a submission you really have to check that for the very problem

  1. there is no solution present,
  2. there are no open issues, and
  3. there are no open PRs.

In this case there is already an open issue. Use the search function and try to find it. Usually the easiest way is to search for the problem id (so search for 1518 in this repo).

When looking for a new problem to solve just make very sure that there is no solution, PR and issue yet 👍 .

@Himsahu Himsahu changed the title Create 1518_Water_Bottles.py 1518_Water_Bottles.py Oct 13, 2020
@vJechsmayr vJechsmayr added the spam PR does not fit Contibution-Guideline label Oct 29, 2020
@vJechsmayr
Copy link
Owner

Problem already solved - Read Contribution Guideline first!

@vJechsmayr vJechsmayr closed this Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

spam PR does not fit Contibution-Guideline

3 participants