Skip to content
This repository was archived by the owner on Sep 22, 2021. It is now read-only.

Conversation

@Himsahu
Copy link

@Himsahu Himsahu commented Oct 12, 2020

IMPORTANT: Please do not create a Pull Request without an issue.

All Submissions:

  • I have read the CONTRIBUTING document.
  • My code is written in Python3 and is ending with .py
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have checked that my submission does pass the test on LeetCode.com
  • Does your filename follow the naming Conventions?
  • Have you linked your PR to an Issue?

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Copy link
Contributor

@riwim riwim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution ✨

Please

  • Re-check "My code is written in Python3 and is ending with .py"
  • Re-check "Have you linked your PR to an Issue?"
@Himsahu
Copy link
Author

Himsahu commented Oct 12, 2020

I have pushed my code to complete my hacktoberfest task

@Himsahu
Copy link
Author

Himsahu commented Oct 12, 2020

Is there anything wrong in my PR

@riwim
Copy link
Contributor

riwim commented Oct 12, 2020

Yes. You still need to

  1. Add .py to the filename of your solution and
  2. Link your PR with an issue

Check CONTRIBUTING.md for details on both points.

@Himsahu
Copy link
Author

Himsahu commented Oct 12, 2020

Done with the changes

@riwim
Copy link
Contributor

riwim commented Oct 12, 2020

You still haven't linked this PR with an open issue. But after renaming the file to 0004_... it becomes clear that you are trying to solve a problem that was already solved in #4. Please read
https://github.com/vJechsmayr/PythonAlgorithms#opening-issues and submit only solutions to unsolved problems with open issues to avoid your PR being rejected.

@Himsahu
Copy link
Author

Himsahu commented Oct 12, 2020

OK leave that PR I got you. The problem is solved by any other guy. I have requested you another PR named water_glass.py please confirm my code.

@riwim
Copy link
Contributor

riwim commented Oct 12, 2020

Sure. Please close this PR so that the maintainer does not have to review this discussion and PR.
Closing a PR

@Himsahu Himsahu closed this Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants