Skip to content

Upgrade ember-qunit to the v5 style of tests, using the highest suppo… #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NullVoxPopuli wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Upgrade ember-qunit to the v5 style of tests, using the highest suppo… #1574

NullVoxPopuli wants to merge 7 commits into from

Conversation

@NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Oct 12, 2023 •
edited
Loading

Work extracted from: #1573
which is all part of an effort to get C.I. green again without changing the support matrix.

I'd tried to go for a smaller, more focused PR: #1575
But,

  • it seems there is too much inter-connecteness between the dependencies for any smaller PR alone to fix CI
  • it's not really worth it to split up PRs for "changelog generation", when the whole PR is "internal" and doesn't cause any external-noticeable differences in behavior.

This PR

  • uses the highest versions of addons/dependencies that will still support ember-cli-typescript's minimum ember version: 3.28
  • adds auto-import and webpack as devDependecies, as those are required for the dummy app (due to ember-qunit@v5)
  • re-rolls the lockfile
  • addresses types issue due to floating dependencies
@NullVoxPopuli NullVoxPopuli mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal

1 participant

@NullVoxPopuli