Tweak authUser to default empty roles without blowing up #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I've been messing about trying to combine react-redux-firebase-authentication with this react-firestore-authenticationas I want to use both Redux and Firestore. I've managed to do so by looking at the diffs in this repo, but one part kept erroring out. For some reason my snapshot was returning without a data child, so line if (!dbUser.roles) {...} was erroring out as dbUser was returning undefined. I'm not sure if this is due to my setup being fresh, or wrong. But it seems to me this setup of setting the default roles in authUser and letting dbUser overwrite that if it has any is cleaner, as well as solving my problem. I don't have a good grasp of the codebase here, so feel free to reject, but just submitting as it might help some folks. 
| Also, if helpful I can push up my repo which uses Firestore and Redux, just let me know if so. Seems to work though I've not tested it much just yet. |
| Thanks for helping out with this. See my comment over here: #9 (comment) Not sure whether this PR fixes the problem. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
sorry, I created a PR before and deleted the repo by mistake, so ignore the other one
I've been messing about trying to combine
react-redux-firebase-authenticationwith thisreact-firestore-authenticationas I want to use both Redux and Firestore.I've managed to do so by looking at the diffs in this repo, but one part kept erroring out.
For some reason my snapshot was returning without a data child, so
if (!dbUser.roles) {...}was erroring out asdbUserwas returning undefined.I'm not sure if this is due to my setup being fresh, or wrong. But it seems to me this setup of setting the default roles in
authUserand lettingdbUseroverwrite that if it has any is cleaner, as well as solving my problem.I don't have a good grasp of the codebase here, so feel free to reject, but just submitting as it might help some folks.