Skip to content

Conversation

@lkazberova
Copy link
Member

Please take a look at files changes, thank you!

@rwieruch
Copy link
Member

rwieruch commented Dec 8, 2018

Notes to myself:

  • add REACT_APP_CONFIRMATION_EMAIL_REDIRECT=http://localhost:3000
  • userList -> users, messageList to messages
@rwieruch
Copy link
Member

rwieruch commented Dec 8, 2018

Awesome migration with little as possible footprint of changing other code. Exactly what I expected 👍 Thank you @lkazberova

I added a couple of comments like suggestions and questions. Some of them may be really nitpicking, but maybe they are also something to learn from. It's always hard to tell if someone knows already the things I suggest or not, that's why I simply write them out and let the developer decide if it is helpful advice :)

Maybe you want to go over the comments/code a second time. When you are done, let me know and I will merge the PR.

@lkazberova
Copy link
Member Author

@rwieruch thank you for your notes, please take a look at changes!

@rwieruch
Copy link
Member

rwieruch commented Dec 8, 2018

Perfect @lkazberova Thanks for going through the comments. I think your solution is perfect now 👍 I will merge it 💯

@rwieruch rwieruch merged commit f8b6e78 into the-road-to-react-with-firebase:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants