Skip to content

KO: Translations for ko/beta/tutorials/estimators/linear.ipynb #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 20, 2019
Merged

KO: Translations for ko/beta/tutorials/estimators/linear.ipynb #671

merged 13 commits into from
Jun 20, 2019

Conversation

@cre8tor
Copy link
Contributor

@cre8tor cre8tor commented Jun 12, 2019

Translation for tutorials/estimators/linear.ipynb

EN ver.
https://github.com/tensorflow/docs/tree/master/site/en/r2/tutorials/estimators/linear.ipynb

Thank you!
@tfdocsbot tfdocsbot added ko translation Community-provided translation for certain languages labels Jun 12, 2019
@tfdocsbot
Copy link
Collaborator

tfdocsbot commented Jun 12, 2019

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.
@tfdocsbot
Copy link
Collaborator

tfdocsbot commented Jun 12, 2019

Reviewers added, please take a look.
@rickiepark, @Choiuijin1125

When your review is finished, approve the pull request or include "LGTM" in your comment.
@googlebot googlebot added the cla: yes CLA has been signed label Jun 12, 2019
Choiuijin1125
Choiuijin1125 reviewed Jun 13, 2019
View reviewed changes
Copy link
Contributor

@Choiuijin1125 Choiuijin1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation! :)
@cre8tor
Copy link
Contributor Author

cre8tor commented Jun 13, 2019 •
edited
Loading

Great translation! :)

Thanks for the review 😄
@lamberta
Copy link
Member

lamberta commented Jun 13, 2019

I think we're good here?
Can someone add an 'LGTM' comment or mark approved using the GitHub UI? Thank you
@rickiepark
Copy link
Contributor

rickiepark commented Jun 14, 2019

@lamberta I’ll review it in the weekend and let you know approval. :)
@cre8tor
Copy link
Contributor Author

cre8tor commented Jun 15, 2019

@lamberta 'Download notebook' button has added recently, so I also added it.
It seems that the link of 'Download notebook' (https://storage.googleapis.com/tensorflow_docs/site/en...) supports only English version.
I fixed the path for Korean version(site/ko/...) of existing notebook files, but they didn't work.
I also fixed the link of 'Download notebook' of this file, hoping that it may support sometime soon.
Is it OK to leave broken link for Korean version notebook? If it's not OK, I'll delete 'Download notebook',
otherwise, I'll add the link to all notebook files.
Thank you.
Choiuijin1125
Choiuijin1125 reviewed Jun 15, 2019
View reviewed changes
site/ko/beta/tutorials/estimators/linear.ipynb Outdated
},
"outputs": [],
"source": [
"!pip install tensorflow==2.0.0-beta0\n",
Copy link
Contributor

@Choiuijin1125 Choiuijin1125 Jun 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we can available beta1 :)
So 'beta0' → 'beta1' thanks 👍
Copy link
Contributor Author

@cre8tor cre8tor Jun 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I fixed version number
@lamberta lamberta requested a review from yashk2810 June 17, 2019 20:56
@lamberta
Copy link
Member

lamberta commented Jun 17, 2019

Thanks.
@yashk2810 recently added the "Download notebook" button and can give an idea when these will be available for translations.
@yashk2810
Copy link
Member

yashk2810 commented Jun 17, 2019

The download button is available only for TF2 notebooks. So if you add the links for the buttons for TF2 notebooks, @lamberta can enable it.
lamberta
lamberta reviewed Jun 18, 2019
View reviewed changes
site/ko/beta/tutorials/estimators/linear.ipynb Outdated
" <a target=\"_blank\" href=\"https://github.com/tensorflow/docs/blob/master/site/ko/beta/tutorials/estimators/linear.ipynb\"><img src=\"https://www.tensorflow.org/images/GitHub-Mark-32px.png\" />깃허브(GitHub) 소스 보기</a>\n",
" </td>\n",
" <td>\n",
" <a target=\"_blank\" href=\"https://storage.googleapis.com/tensorflow_docs/site/ko/beta/tutorials/estimators/linear.ipynb\"><img src=\"https://www.tensorflow.org/images/download_logo_32px.png\" />노트북 다운로드</a>\n",
Copy link
Member

@lamberta lamberta Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove button for now.
We can add them to the beta notebooks all at once when it's enabled for translations.
Copy link
Contributor Author

@cre8tor cre8tor Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lamberta
Download notebook button has been removed
Choiuijin1125
Choiuijin1125 approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@Choiuijin1125 Choiuijin1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
rickiepark
rickiepark reviewed Jun 20, 2019
View reviewed changes
Copy link
Contributor

@rickiepark rickiepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cre8tor Great translation. Thank you so much! 👍
rickiepark
rickiepark approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@rickiepark rickiepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@cre8tor
Copy link
Contributor Author

cre8tor commented Jun 20, 2019

@Choiuijin1125 @rickiepark Thank you for reviewing my translation!
lamberta
lamberta approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation and reviews 🚀
@lamberta lamberta added the ready to pull Start merge process label Jun 20, 2019
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 6618547 into tensorflow:master Jun 20, 2019
TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Jun 20, 2019
@copybara-github
Merge pull request #671 from cre8tor:linear_ipynb
fc62de3 
PiperOrigin-RevId: 254235401
@cre8tor cre8tor deleted the linear_ipynb branch June 21, 2019 03:24
@cre8tor cre8tor mentioned this pull request Aug 15, 2019
Merged
by-park added a commit to by-park/docs that referenced this pull request Aug 18, 2019
@by-park
Remove button for notebook download
b6501ee 
Remove download button. (It will be applied at once: tensorflow#671)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes CLA has been signed ko ready to pull Start merge process translation Community-provided translation for certain languages

9 participants

@cre8tor @tfdocsbot @lamberta @rickiepark @yashk2810 @Choiuijin1125 @googlebot @kokoro-team @TensorFlow-Docs-Copybara