Skip to content

Conversation

@chicco-carone
Copy link
Contributor

This pull request includes a small change to the site/en/tutorials/images/classification.ipynb file. The change updates the way the dataset directory is specified to ensure compatibility with the extracted folder structure.

@chicco-carone chicco-carone requested a review from a team as a code owner June 19, 2025 12:54
@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs 
$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin fix-classification-download
@8bitmp3
Copy link
Contributor

8bitmp3 commented Jun 30, 2025

can you please undo the indentation changes please

@8bitmp3 8bitmp3 self-assigned this Jun 30, 2025
@8bitmp3 8bitmp3 added the awaiting-contributor-response Indicates a question, draft, or work-in-progress label Jun 30, 2025
@chicco-carone
Copy link
Contributor Author

what indentation changes are causing this issue? I didn't indent anything like the original file so I'm not sure

@MarkDaoust
Copy link
Member

what indentation changes are causing this issue? I didn't indent anything like the original file so I'm not sure

The diff is a lot easier to review if you don't change the indentation. Look at the diff here:

https://github.com/tensorflow/docs/pull/2387/files

The commands printed in the GH actions bot comment explain one way to fix it.

@chicco-carone
Copy link
Contributor Author

I ran the format tool like the comments from github actions so now it should be good to go

MarkDaoust
MarkDaoust previously approved these changes Jul 1, 2025
@MarkDaoust MarkDaoust added ready to pull Start merge process and removed awaiting-contributor-response Indicates a question, draft, or work-in-progress labels Jul 1, 2025
@copybara-service copybara-service bot merged commit 664aa47 into tensorflow:master Jul 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull Start merge process

3 participants