Skip to content

Conversation

@gitshiva
Copy link

@gitshiva gitshiva commented Feb 13, 2024

…then updated Horsepower references to specific columns in array, otherwise this nb was failing due to data type mismatches

closes: #2313

…then updated Horsepower references to specific columns in array, otherwise this nb was failing due to data type mismatches
@gitshiva gitshiva requested a review from a team as a code owner February 13, 2024 22:58
@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs 
$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin master
Generate just one seed, rather than generating two seeds and then tak…
Copy link
Contributor

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@8bitmp3 8bitmp3 added the review in progress Someone is actively reviewing this PR label Feb 24, 2024
@8bitmp3 8bitmp3 assigned MarkDaoust and unassigned MarkDaoust Aug 15, 2024
@MarkDaoust
Copy link
Member

Hi, thanks for pointing this out and taking the time to send a PR.

I always prefer referencing columns by name instead of index, how about we do this:

gitshiva#2

@8bitmp3 8bitmp3 added the awaiting-contributor-response Indicates a question, draft, or work-in-progress label Sep 4, 2024
@github-actions
Copy link

Marking this pull request as stale since it has been open for 14 days with no activity. This PR will be closed if no further activity occurs.

@github-actions
Copy link

github-actions bot commented Oct 3, 2024

This pull request was closed because it has been inactive for 28 days. Please open a new pull request if you need further assistance. Thanks!

@github-actions github-actions bot closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-contributor-response Indicates a question, draft, or work-in-progress review in progress Someone is actively reviewing this PR status:stale

4 participants