Skip to content

Conversation

@eslam69
Copy link
Contributor

@eslam69 eslam69 commented Mar 20, 2023

This is a follow-up pull request regarding #2198, as @markmcd asked, I've run nbfmt on the notebook and passed nblint test locally.

  • Fixed serialize_example() example description where the mentioned function create_message() was meant to be serialize_example().
  • Updated the code cell where the serialize_example() is used, the example_observation variable was initialized but not used, so I filled it with the data, and used it as an argument to serialize_example().
@eslam69 eslam69 requested a review from a team as a code owner March 20, 2023 00:18
@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs 
$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin master
@8bitmp3 8bitmp3 added the awaiting-contributor-response Indicates a question, draft, or work-in-progress label Mar 27, 2023
@eslam69 eslam69 requested review from 8bitmp3 and MarkDaoust April 2, 2023 03:08
@8bitmp3
Copy link
Contributor

8bitmp3 commented Dec 20, 2023

Copy link
Contributor Author

@eslam69 eslam69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled the merge conflict.

@eslam69
Copy link
Contributor Author

eslam69 commented Apr 5, 2024

@MarkDaoust Hello Mark, could you please review my work on the requested changes?

@8bitmp3 8bitmp3 added awaiting-technical-review and removed awaiting-contributor-response Indicates a question, draft, or work-in-progress labels May 3, 2024
@8bitmp3
Copy link
Contributor

8bitmp3 commented May 3, 2024

@MarkDaoust MarkDaoust added the ready to pull Start merge process label May 3, 2024
@eslam69 eslam69 closed this May 10, 2024
@copybara-service copybara-service bot merged commit eea8c52 into tensorflow:master May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants