Skip to content

Conversation

@arshagarwal
Copy link

In response to the discussions in this pull request, this pull request adds Random normal initializer with mean 0 and std-dev 1, and fixes the optimizer hyper-parameters as per DC-GAN paper.

I am sure there is a more graceful way to do this, but I found this way much easier than to fix code in the same pull request.
Sorry about that!

@google-cla google-cla bot added the cla: yes CLA has been signed label Oct 14, 2020
@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs 
$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin test
@MarkDaoust
Copy link
Member

Friendly ping @yashk2810

@lamberta
Copy link
Member

Merge conflict, please rebase

@lamberta lamberta added the awaiting-contributor-response Indicates a question, draft, or work-in-progress label Nov 17, 2020
Comment on lines +253 to +254
"# Random Normal model initializers as per Dc-gan paper\n",
"RN_initializers=tf.keras.initializers.RandomNormal(mean=0.0,stddev=0.02)\n\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great observation about the zero-centered Normal, thanks for bringing this up.

I have a few style-related suggestions, if you don't mind:

Suggested change
"# Random Normal model initializers as per Dc-gan paper\n",
"RN_initializers=tf.keras.initializers.RandomNormal(mean=0.0,stddev=0.02)\n\n",
"# Random Normal weight initializer as per the DCGAN paper\n",
"RN_initializers=tf.keras.initializers.RandomNormal(mean=0.0, stddev=0.02)\n\n",

Also, since it's a weight initializer (singular), maybe you should rename the variable to RN_initializer without the s.

Anyway, these are just recommendations 👍

@8bitmp3 8bitmp3 assigned MarkDaoust and 8bitmp3 and unassigned yashk2810 May 28, 2021
@8bitmp3 8bitmp3 added the review in progress Someone is actively reviewing this PR label May 28, 2021
@8bitmp3 8bitmp3 removed awaiting-contributor-response Indicates a question, draft, or work-in-progress awaiting-technical-review labels Jun 9, 2021
@8bitmp3 8bitmp3 closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes CLA has been signed review in progress Someone is actively reviewing this PR

5 participants