Skip to content

Conversation

@king-p3nguin
Copy link
Contributor

@king-p3nguin king-p3nguin commented May 30, 2024

(I am contributing to this project as a unitaryHACK participant)

@refraction-ray
Copy link
Contributor

thanks for the nice contribution. could you also include an example script in /examples to both check the correctness and compare the efficiency of the sparse Hamiltonian generation for different backends? (say generate Hamiltonian for several typical systems in O(20) qubits). I can also utilize the same script to benchmark the efficiency between previous impl. and the current one in case any performance degradation.

@king-p3nguin king-p3nguin marked this pull request as ready for review May 30, 2024 06:15
@king-p3nguin
Copy link
Contributor Author

I noticed that examples/hamiltonian_building.py does the benchmark for the numpy backend, so I also added the jax and tensorflow backends in the script.

@refraction-ray refraction-ray merged commit 313ddd3 into tencent-quantum-lab:master May 30, 2024
@refraction-ray
Copy link
Contributor

LGTM, I have further added jit for these functions to improve the efficiency

@refraction-ray
Copy link
Contributor

@all-contributors please add @king-p3nguin for example

@allcontributors
Copy link
Contributor

@refraction-ray

I've put up a pull request to add @king-p3nguin! 🎉

@king-p3nguin king-p3nguin deleted the backend-agnostic-h-gen branch May 30, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants