feat: Add OpenTelemetry instrumentation #525
Open
+1,078 −111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…hecks from pre-commit, fix taskiq-python#417
danfimov reviewed Nov 4, 2025
| content: "97DC185FE0A2F5B123861F0790FDFB26" # pragma: allowlist secret | ||
| - - meta | ||
| - name: "yandex-verification" | ||
| content: "9b105f7c58cbc920" |
There was a problem hiding this comment.
Why pragma: allowlist secret is here?
As I see, we already exclude this file from detect-secrets pre-commit hook check. Is some other linter checks fails on this lines?
danfimov reviewed Nov 4, 2025
| @@ -0,0 +1,2 @@ | |||
| # for compatibility with opentelemetry-instrumentation | |||
| _instruments = ("taskiq >= 0.11.19",) | |||
There was a problem hiding this comment.
Just wondering: do we need to update version in this file on every release?
danfimov reviewed Nov 4, 2025
| | ||
| self.assertEqual(result.return_value, {"key": "value"}) | ||
| | ||
| @pytest.mark.anyio |
There was a problem hiding this comment.
I enabled anyio_mode = "auto" flag for pytest. So tests doesn't need to explicitly say that they are async with pytest.mark.anyio marker.
You can just remove it and tests should work as they were)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.