fix: ZeroMQ broker #511
Open
fix: ZeroMQ broker #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
s3rius previously approved these changes Oct 23, 2025
| MyPy is complaining about the code. Can you fix it's error? |
| @s3rius maybe we should change the zeromq architecture? Now the worker is connecting to the publisher, and I suggest that the worker make a bind and the others connect to it. This will allow us to send tasks from multiple processes. For example, from a scheduler and a web service Reference implementaion: |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
I removed socket.connect because it's not needed for bind, as bind is used for connecting. And I added unbind for broker shutdown.
We can see it in this sources
https://github.com/zeromq/pyzmq/blob/b184fed8b6525da5d9234b470800af9a72565b1c/zmq/sugar/socket.py#L270-L289
Closing
fixes #401