- Notifications
You must be signed in to change notification settings - Fork 445
Update & Extend documentation #1078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for the contribution! Before we can merge this, we need @bossenti to sign the Salesforce.com Contributor License Agreement. |
bcantoni left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bossenti thanks for the contribution here! I've added a few corrections to make but otherwise it's looking good.
| Thanks for the contribution! Unfortunately we can't verify the commit author(s): Tim Bossenmaier <t***@c***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated. |
| Thanks @kramantab and @bcantoni for reviewing. |
| All looks good to me. Passing it over to @kramantab for any additional feedback or changes. @bossenti after @kramantab approves, you can merge. Please choose the "Squash and merge" option to combine all your commits into one. |
kramantab left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good Thanks!
| @bcantoni, @kramantab, unfortunately I can't merge the pull request because I lack the appropriate permissions: |
| Done - thanks @bossenti for the contribution! |
While working with the tableau server-client-python library I stumbled about some bugs in the documentation which I fixed within this PR.
Furthermore, I've created documentation for the method
add_to_schedule()of theschedules-endpoint as this was missing so far.Hopefully this PR fits so far, otherwise feel free to let me know.
Thanks for this great library, I really like the API of the client. It's fun to work with it :)