Making APNSClient's Sendable conformance public #223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| @mergesort does this work for you? This is failing CI because you can't mark protocol conformances as public |
Contributor Author
| Sorry for this PR and issue, it looks like this was an Xcode issue all along. I implemented this change on my fork, and it seemed to work, but that turned out to be something related to build artifacts. After trying a clean build it's no longer working, and this error is definitely a bug on my part and should be closed. Worst of all, it looks like I should have never even opened this PR because things already work as I needed them to — not sure what was wrong before. 🤦🏻 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Just a one-liner, but this was useful for me to inject APNSClient into Vapor's StorageKey as described in #222.