Privatize APNSPushType #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
0xTim reviewed Aug 20, 2024
Contributor
0xTim left a comment
0xTim left a comment There was a problem hiding this comment.
Are there changes for the configuration planned? Because this seems like a small change for a major release
Member Author
Member Author
| specifically #181 (comment) |
Member Author
| @0xTim fwiw I don't think we need to go do a major just yet, people can always pull |
Contributor
| Oh yeah for sure, if you're planning a major you don't have to release until you want to. (Would be a good opportunity to remove all the NIO stuff and go full structured concurrency) |
0xTim approved these changes Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This puts the
APNSPushTypeback behind a private enum so that it won't be a breaking change when new ones are added.