Make APNSClient Sendable if coders are Sendable #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
FranzBusch approved these changes Mar 19, 2024
Contributor
FranzBusch left a comment
FranzBusch left a comment There was a problem hiding this comment.
LGTM! @kylebrowning you mind merging this?
Member
| @FranzBusch sure, running checks |
Contributor Author
Hmm, is this TSan failure related to the new conformance? Seems unlikely to me... |
Contributor
GitHub have screwed up their runners on Linux so any LLVM ASAN/TSAN checks are failing. They have a fix that's due to deploy this week (I believe Friday) but as a workaround if you want it you can check out the issue which contains details and the workaround actions/runner-images#9491 (comment) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JSONEncoderandJSONDecoderalso conform toSendable, making the most commonly usedAPNSClientthenSendableas well.